[Bug 17926] New: Wrong Return key handling in file dialog
http://bugs.winehq.org/show_bug.cgi?id=17926 Summary: Wrong Return key handling in file dialog Product: Wine Version: 1.1.18 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: shell32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: gabmoa(a)yahoo.it Start wine notepad then call the open dialog browser. The file list doesn't go inside a directory when RETURN key is pressed on a directory; it only does a refresh of the list or, in some cases, it goes in the wrong directory!! Double click with mouse is not affected by the problem. Also Backspace seems to work correctly. The dialog (tested in other application it has the same behaviour) so is not usable without mouse! Ubuntu 8.04-Wine 1.1.18 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17926 --- Comment #1 from Gabriele Moabiti <gabmoa(a)yahoo.it> 2009-04-01 17:30:42 --- NOTE: is affected also the save dialog -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17926 Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor Component|shell32 |comdlg32 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17926 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 Keywords| |download, source --- Comment #2 from Austin English <austinenglish(a)gmail.com> 2009-04-01 19:07:46 --- Confirming. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17926 --- Comment #3 from Gabriele Moabiti <gabmoa(a)yahoo.it> 2009-04-03 03:37:48 --- Note: there is also a typo in the dll/shell32/shlview.c function: ShellView_OnNotify .. case NM_RETURN -> the trace report NM_DBLCLK -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17926 --- Comment #4 from Gabriele Moabiti <gabmoa(a)yahoo.it> 2009-04-11 17:18:48 --- Test with wine 1.1.19 I think the problem is the Enter key is taken (or processed) before than listview when 'File Name' text box is not empty. In fact if a file is selected in the text box and the focus is in the listview when Enter is pressed on a directory it opens the file (and this is wrong!!) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17926 --- Comment #5 from Gabriele Moabiti <gabmoa(a)yahoo.it> 2009-04-11 17:27:01 --- Other notes: - This bug affects all the open/save dialogs I tested so is a shell32 bug, not a notepad one - Another BUG: in the open/save dialog in the File name field there is written '*.txt' !!!! I also test another application which it has in the filter combo box 'Executable Files *.exe;*.com;*.bat' and the same problem arise: in the File Name filed there is *.exe;*.com;*.bat! So also this bug is not of notepad but is related to the open/save shell dialog I think these are a very annoying bug -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17926 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish(a)gmail.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17926 --- Comment #6 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-12-09 06:55:57 --- (In reply to comment #3)
Note: there is also a typo in the dll/shell32/shlview.c function: ShellView_OnNotify .. case NM_RETURN -> the trace report NM_DBLCLK
Patch sent, thanks. (In reply to comment #5)
- Another BUG: in the open/save dialog in the File name field there is written '*.txt' !!!! I also test another application which it has in the filter combo box 'Executable Files *.exe;*.com;*.bat' and the same problem arise: in the File Name filed there is *.exe;*.com;*.bat! So also this bug is not of notepad but is related to the open/save shell dialog
I think these are a very annoying bug
Native Notepad places *.txt when Open File is requested for the first time. The problem is that it isn't updated in Wine when switching to All Files for example. File a separate bug for this problem please, it's completely unrelated. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17926 --- Comment #7 from Gabriele Moabiti <gabmoa(a)yahoo.it> 2010-02-12 08:53:39 --- I think this fix the problem so it's like on windows: dlls/comdlg32/filedlg.c BOOL FILEDLG95_OnOpen(HWND hwnd) { ... TRACE("hwnd=%p\n", hwnd); /* get the files from the edit control */ nFileCount = FILEDLG95_FILENAME_GetFileNames(hwnd, &lpstrFileList, &sizeUsed); + if (BrowseSelectedFolder(hwnd)) + return FALSE; /* try if the user selected a folder in the shellview */ if(nFileCount == 0) - { - BrowseSelectedFolder(hwnd); return FALSE; - } ... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17926 --- Comment #8 from Gabriele Moabiti <gabmoa(a)yahoo.it> 2010-02-15 07:45:09 --- Created an attachment (id=26258) --> (http://bugs.winehq.org/attachment.cgi?id=26258) Open should try to browse directory first -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17926 Gabriele Moabiti <gabmoa(a)yahoo.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17926 Gabriele Moabiti <gabmoa(a)yahoo.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #9 from Gabriele Moabiti <gabmoa(a)yahoo.it> 2010-02-19 12:52:27 --- Fixed in wine 1.1.39 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17926 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #10 from Alexandre Julliard <julliard(a)winehq.org> 2010-03-05 12:42:55 --- Closing bugs fixed in 1.1.40. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs@winehq.org