[Bug 28754] New: In comdl32/tests/itemdlg.ok, update_layout() uses uninitialized window rect
http://bugs.winehq.org/show_bug.cgi?id=28754 Bug #: 28754 Summary: In comdl32/tests/itemdlg.ok, update_layout() uses uninitialized window rect Product: Wine Version: 1.3.30 Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: comdlg32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: dank(a)kegel.com Classification: Unclassified Running "make itemdlg.ok" in comdlg32/tests, valgrind complains Conditional jump or move depends on uninitialised value(s) at update_layout (itemdlg.c:1114) by IFileDialog2_fnSetFileNameLabel (itemdlg.c:1968) by IFileOpenDialog_fnSetFileNameLabel (itemdlg.c:2231) by func_itemdlg (itemdlg.c:714) by run_test (test.h:556) by main (test.h:624) Uninitialised value was created by a stack allocation at update_layout (itemdlg.c:1098) and a cascade of uninitialized values ensues that would be hard to write a suppression for. The uninitilialized value happens because update_layout() calls GetClientRect on This->dlg_hwnd, which is NULL, and doesn't check whether it succeeded. The attached patch makes all the warnings go away, but I don't know if it's the right thing to do. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28754 --- Comment #1 from Dan Kegel <dank(a)kegel.com> 2011-10-16 15:22:21 CDT --- Created attachment 36938 --> http://bugs.winehq.org/attachment.cgi?id=36938 Patch to work around (or maybe solve) the problem -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=28754 --- Comment #2 from Austin English <austinenglish(a)gmail.com> --- Conditional jump or move depends on uninitialised value(s) at update_layout (itemdlg.c:1118) by IFileDialog2_fnSetFileNameLabel (itemdlg.c:1972) by IFileOpenDialog_fnSetFileNameLabel (shobjidl.h:13997) by test_basics (shobjidl.h:15138) by func_itemdlg (itemdlg.c:1932) by run_test (test.h:584) by main (test.h:654) Uninitialised value was created by a stack allocation at update_layout (itemdlg.c:1102) still present. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=28754 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source, testcase, | |valgrind -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=28754 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|In |valgrind shows an |comdl32/tests/itemdlg.ok, |uninitialized value in |update_layout() uses |comdlg32/tests/itemdlg.ok, |uninitialized window rect |update_layout() -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=28754 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |2afbf9dbbcc56f686c35be03557 | |cabf9589b1a03 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com> --- Looks like this one is fixed with http://source.winehq.org/git/wine.git/commit/2afbf9dbbcc56f686c35be03557cabf... too. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=28754 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.41. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org