[Bug 56177] New: The 64-bit uxtheme:system fails on Windows 10 2004+
https://bugs.winehq.org/show_bug.cgi?id=56177 Bug ID: 56177 Summary: The 64-bit uxtheme:system fails on Windows 10 2004+ Product: Wine Version: unspecified Hardware: x86-64 OS: Windows Status: NEW Severity: normal Priority: P2 Component: uxtheme Assignee: wine-bugs(a)winehq.org Reporter: fgouget(a)codeweavers.com The 64-bit uxtheme:system fails on Windows 10 2004+: system.c:2735: Test failed: Expected value 0, got -1702550272 See http://winetest.dolphin/data/patterns.html#uxtheme:system A bisect shows that this failure started with the commit below: commit b5f4a6a4dbb6f4d7b9f182d0d551393558458712 Author: Louis Lenders <xerox.xerox2000x(a)gmail.com> Date: Thu Oct 19 15:15:36 2023 +0200 uxtheme: Add ShouldAppsUseDarkMode. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55821 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56177 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression, source, | |testcase Regression SHA1| |b5f4a6a4dbb6f4d7b9f182d0d55 | |1393558458712 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56177 --- Comment #1 from François Gouget <fgouget(a)codeweavers.com> --- Sorry, wrong URL See https://test.winehq.org/data/patterns.html#uxtheme:system -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56177 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xerox.xerox2000x(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56177 --- Comment #2 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Hi, It seems that the undocumented dark-theme api's might possibly change from windows version to windows version, as some sites mention (i mentioned a few of those sites in the merge request thread). Also this site mentions even the ordinal number might have changed: https://codereview.qt-project.org/c/qt/qtbase/+/357262 Quote: " Also there's two undocumented API from UxTheme.dll can help us get the current theme: BOOL WINAPI ShouldAppsUseDarkMode() and BOOL WINAPI ShouldSystemUseDarkMode(). They can only be resolved by ordinal name, the former is 132, the latter is 138. Sadly ShouldAppsUseDarkMode() changed it's ordinal number in some unknown version of Windows, so currently, only ShouldSystemUseDarkMode() is usable." ->end quote Long story short: in my opinion a reliable test is maybe not yet achievable, so my suggestion would just be to comment out the failing test. Francois: what do you think of that? Also: maybe Zhiyi could shed a light on this? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=56177 Nikolay Sivov <bunglehead@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Nikolay Sivov <bunglehead@gmail.com> --- There was a fix shortly after: commit 3bd1d1c60d10e96caef40dae6dde8da5f9d03da7 Author: Alexandre Julliard <julliard@winehq.org> Date: Fri Feb 9 11:48:46 2024 +0100 uxtheme: Use BOOLEAN instead of BOOL in ordinal functions. This should fix test failures on Windows. I don't see any failures currently on published tests, and it doesn't crash for me on Win11 with or without a patch. I think we can safely close this. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=56177 Alexandre Julliard <julliard@winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Alexandre Julliard <julliard@winehq.org> --- Closing bugs fixed in 11.0-rc2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
WineHQ Bugzilla -
WineHQ Bugzilla