[Bug 10158] New: Fix proper way to use quotes
http://bugs.winehq.org/show_bug.cgi?id=10158 Summary: Fix proper way to use quotes Product: WineHQ Apps Database Version: unspecified Platform: All OS/Version: All Status: UNCONFIRMED Severity: enhancement Priority: P3 Component: website-bugs AssignedTo: wine-bugs(a)winehq.org ReportedBy: daoo90(a)gmail.com I'm new to this therefor I start with something small to get familiar with the code. Anyway to the bugreport: Double and single quotes are not used properly anywhere in the code which causes parsing slowdowns. Parser does variable interpolation in double-quoted strings. Double-quoted strings should only be used when the string contain a variable that should be parsed. Otherwise use single-quote. I will be tracking those quotes in this bug and attach cvs diffs. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10158 --- Comment #1 from daoo <daoo90(a)gmail.com> 2007-10-24 14:21:08 --- Created an attachment (id=8746) --> (http://bugs.winehq.org/attachment.cgi?id=8746) Update the CODING_STANDARD file Patch to update the CODING_STANDARD file. Please let me know if this isn't the preferred patch format. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10158 Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex(a)thehandofagony.com Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #2 from Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> 2007-10-25 01:43:52 --- The preferred patch format is GIT, and you'll find that GIT is a lot easier to use when you are sending several patches that modify the same file. Do a git clone git://source.winehq.org/git/appdb.git to get started. It will create an appdb directory in the folder where you ran the command. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10158 daoo <daoo90(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8746 is|0 |1 obsolete| | --- Comment #3 from daoo <daoo90(a)gmail.com> 2007-10-25 07:55:17 --- Created an attachment (id=8751) --> (http://bugs.winehq.org/attachment.cgi?id=8751) Update CODING_STANDARD accordingly New try -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10158 --- Comment #4 from Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> 2007-10-25 08:03:07 --- Yes, but before sending changes you should commit them to your local tree and use 'git-format-patch -o out origin' to generat a patchset. If you haven't done so already, run the following commands first git repo-config user.name "Your Name" git repo-config user.email "me(a)example.com" There's also a useful GIT howto at http://wiki.winehq.org/GitWine -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10158 --- Comment #5 from Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> 2007-10-25 08:03:25 --- and don't forget to fix the 'no newline at end of file' thing :) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10158 daoo <daoo90(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8751 is|0 |1 obsolete| | --- Comment #6 from daoo <daoo90(a)gmail.com> 2007-10-25 08:05:49 --- Created an attachment (id=8752) --> (http://bugs.winehq.org/attachment.cgi?id=8752) Fix no new line OK, hopefully this is correct. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10158 --- Comment #7 from Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> 2007-10-25 08:16:29 --- You still need to commit and use format-patch as I explained -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10158 daoo <daoo90(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8752 is|0 |1 obsolete| | --- Comment #8 from daoo <daoo90(a)gmail.com> 2007-10-25 09:05:34 --- Created an attachment (id=8759) --> (http://bugs.winehq.org/attachment.cgi?id=8759) Update CODING_STANDARD Now I think it's as you want. I missed your first message, sorry for any inconvenience. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10158 --- Comment #9 from Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> 2007-10-25 16:33:01 --- That looks good. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10158 --- Comment #10 from Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> 2007-10-29 05:57:07 --- Hve you sent it in yet? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10158 --- Comment #11 from daoo <daoo90(a)gmail.com> 2007-10-31 10:21:56 --- I think so. I just have to get a php4 server to check that everything works since i couldn't get it to run on my php5 server. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10158 --- Comment #12 from Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> 2007-10-31 11:55:09 --- AppDB uses PHP5, and will not work with PHP4. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10158 --- Comment #13 from Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> 2007-11-25 16:30:08 --- Patch for coding standards applied. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10158 --- Comment #14 from daoo <daoo90(a)gmail.com> 2007-12-03 06:53:11 --- Hi again, I've not had time to update anything the past weeks because I got very busy. Also I lost a lot of work in a hard disk crash and not enough backups. Now when I've gone through almost all files I think it's better if I work with some real bugs to improve the appdb feature-wise. The CODING_STANDARD have been updated so I think we can close this bug now and hope that the standards are followed better in the future. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10158 Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #15 from Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> 2007-12-03 07:49:36 --- Some real improvements would be great! There's a list at http://wiki.winehq.org/AppdbInfo, but feel free to do something which is not listed there. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10158 Ken Sharp <kennybobs(a)o2.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #16 from Ken Sharp <kennybobs(a)o2.co.uk> 2009-05-27 18:42:17 --- Fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10158 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Platform|All |Other OS/Version|All |other --- Comment #17 from Austin English <austinenglish(a)gmail.com> 2012-02-23 15:13:53 CST --- Removing deprecated 'All' Platform/OS. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org