[Bug 25265] New: Foobar2000 won't watch folders
http://bugs.winehq.org/show_bug.cgi?id=25265 Summary: Foobar2000 won't watch folders Product: Wine Version: 1.3.7 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: lucisandor(a)gmail.com Foobar2000 is a media player with an automatically updated media library. The library updates correctly when updates are triggered manually, but, under Wine, it does not detect changes in folders. Moreover, Foobar2000 provides for such cases a "polling" function, but that is useless too. The most upsetting is that changes in watched folders are not detected even when they were produced by Fooobar2000, e.g., by using the menu option "move file". If I move a file from one watched folder to another, the media library will not be aware of the changes in any of the two locations. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25265 Matt Lichtenberg <kerobaros(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kerobaros(a)gmail.com --- Comment #1 from Matt Lichtenberg <kerobaros(a)gmail.com> 2010-11-22 23:42:55 CST --- Confirming this bug report. I use foobar2000 1.1 on Wine 1.3.7, on Arch Linux, x86_64. Library does not update on anything but a restart, even when changes are made by foobar2000 itself. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25265 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dank(a)kegel.com --- Comment #2 from Dan Kegel <dank(a)kegel.com> 2010-11-23 05:57:40 CST --- IIRC, the FindFirstChange function in Wine has a known limitation: it won't set linux watches on subdirectories if the calling app doesn't explore the directories once itself after calling FindFirstChange. This could be related. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25265 Michael Pujos <pujos.michael(a)laposte.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pujos.michael(a)laposte.net --- Comment #3 from Michael Pujos <pujos.michael(a)laposte.net> 2011-01-22 06:21:25 CST --- Folder watching do not work in foobar 2000 because ReadDirectoryChangesW() implementation in wine is horribly broken. In 2008 I did a patch that fixed it, but it didn't get accepted because it was not a trivial patch, was modifying wine server protocol, and was my first submitted patch and I was recommended to breakdown the patch into several sub-patches, which didn't make sense at all. Not having the patience to wait for an eventual approval by 2015 if lucky, I abandonned. The problem in ReadDirectoryChangesW() is the following: "1. move and rename of files and directories in a monitored directory are not notified 2. the current implementation allow to only get one change (FILE_NOTIFY_INFORMATION structure) at a time. No change is actually lost but the calling application using ReadDirectoryChangesW() expect to retrieve all changes since the last call. With the current implementation it would only get the first and would have to call ReadDirectoryChangesW() again to get the other. With this patch , it gets all notification (as many consecutive FILE_NOTIFY_INFORMATION structs) since the last call to ReadDirectoryChangesW(). These move operations are implemented by this patch and conform to what win32 does: - Moving a directory or a file inside the monitored directory. A FILE_NOTIFY_INFORMATION structure with action FILE_ACTION_ADDED is returned - Moving a directory or a file out of the monitored directory. A FILE_NOTIFY_INFORMATION structure with action FILE_ACTION_REMOVED is returned - Renaming a directory or a file in the monitored directory. Two consecutive FILE_NOTIFY_INFORMATION structures with actions FILE_ACTION_RENAMED_OLD_NAME and FILE_ACTION_RENAMED_NEW_NAME are returned within the same reply. This can actually be done because issue 2 above is corrected." The original patch addressing problems above can be found here: http://bubbleguuum.free.fr/0001-server-implement-move-rename-change-notifica... It would be great if a high profile wine developper would take on it, as this really needs to be fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25265 --- Comment #4 from Dan Kegel <dank(a)kegel.com> 2011-01-22 10:31:54 CST --- Could you pull out the tests from that patch and submit them by themselves? That might help. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25265 Bazyli <bart8472+winehq(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bart8472+winehq(a)gmail.com --- Comment #5 from Bazyli <bart8472+winehq(a)gmail.com> 2011-01-29 04:01:08 CST --- (In reply to comment #3)
The original patch addressing problems above can be found here:
http://bubbleguuum.free.fr/0001-server-implement-move-rename-change-notifica...
Hi, Would simply applying this 3 year old patch still work or were there too many changes to the Wine server files to make it work at all? Cheers -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25265 --- Comment #6 from Michael Pujos <pujos.michael(a)laposte.net> 2011-01-29 14:57:51 CST --- @Dan Kegel Not a bad idea but do not have the time at the moment. @Bazily Patch would need some bit of adaptation to be integrated into current wine I think. It already needed some last I looked, 1.5 years ago. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25265 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download Status|UNCONFIRMED |NEW URL| |http://www.foobar2000.org/d | |ownload CC| |focht(a)gmx.net Ever Confirmed|0 |1 --- Comment #7 from Anastasius Focht <focht(a)gmx.net> 2011-05-15 12:27:09 CDT --- Hello, still present, filling some fields ... $ sha1sum foobar2000_v1.1.6.exe f6af381a0465e012f42b6eb291eb12666ac8e57a foobar2000_v1.1.6.exe $ wine --version wine-1.3.20 Regards -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25265 piroxiline(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |piroxiline(a)gmail.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25265 Jarkko K <jarkko_korpi(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jarkko_korpi(a)hotmail.com --- Comment #8 from Jarkko K <jarkko_korpi(a)hotmail.com> --- I tried this with 1.7.18. I added mp3 file into monitored directory and I couldnt see foobar doing anything, then I removed it there. Same thing. Doesn't see it responding. Also the linked patch seem to gone... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25265 hanska2(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hanska2(a)luukku.com --- Comment #9 from hanska2(a)luukku.com --- Didnt try with newest wine I assume the situation is the same. But I have been reading wine source code and done some googling. http://msdn.microsoft.com/en-us/library/windows/desktop/aa364391%28v=vs.85%2... http://msdn.microsoft.com/en-us/library/windows/desktop/aa365465%28v=vs.85%2... These are related. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25265 --- Comment #10 from piroxiline(a)gmail.com --- When installing F000bar or when trying to add all folder through menu "Open" can't select folder and click to add it - 'cuz it enters folder. Hack I use is to place '.' in file name field. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25265 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man(a)post.com --- Comment #11 from super_man(a)post.com --- Still an issue. There is a patch here https://www.winehq.org/pipermail/wine-patches/2008-December/066225.html but it doesnt apply cleanly anymore. wine 1.7.49 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25265 noonsbirthdays59(a)ruggedinbox.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noonsbirthdays59(a)ruggedinbo | |x.com --- Comment #12 from noonsbirthdays59(a)ruggedinbox.com --- and still an issue in 2016 - using wine 1.9.3 and foobar2000 1.3.9 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25265 joaopa <jeremielapuree(a)yahoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree(a)yahoo.fr --- Comment #13 from joaopa <jeremielapuree(a)yahoo.fr> --- Does the bug still occur with wine-5.11? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25265 Michael McGuire <spoon0042(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |spoon0042(a)hotmail.com --- Comment #14 from Michael McGuire <spoon0042(a)hotmail.com> --- seems to work here but then I never tried before? at least I copied some albums to ~/Music and they showed up in the library. wine-devel 5.11 and foobar2000 1.5.3 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25265 LingM <lingm+winebz(a)posteo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lingm+winebz(a)posteo.org --- Comment #15 from LingM <lingm+winebz(a)posteo.org> --- Same as the previous commenter. Works for me with Wine 6.4 and foobar2000 1.6.4. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25265 --- Comment #16 from joaopa <jeremielapuree(a)yahoo.fr> --- Reported working twice. Can an administrator close this bug as FIXED? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25265 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |b614a15328b05d962c31b54b7e0 | |78580be23be8a Summary|Foobar2000 won't watch |Foobar2000 does not |folders |automatically update media | |library (folder watch does | |not work) URL|http://www.foobar2000.org/d |https://web.archive.org/web |ownload |/20210217111254/https://www | |.foobar2000.org/files/fooba | |r2000_v1.1.18.exe Status|NEW |RESOLVED Component|-unknown |wineserver Resolution|--- |FIXED --- Comment #17 from Anastasius Focht <focht(a)gmx.net> --- Hello folks, this was fixed a long time ago in Wine 1.3 series. * https://source.winehq.org/git/wine.git/commitdiff/b614a15328b05d962c31b54b7e... ("server: Return multiple events in read_changes.") * https://source.winehq.org/git/wine.git/commitdiff/be5a757c7acaa83cd651e5e043... ("server: Don't report rename events when file is moved between directories.") Part of Wine 1.3.12 release Thanks Piotr. The testing was done incorrectly (including myself in comment #7). The main UI (default playlist listview) won't show anything. You have to open 'Library' -> 'Album List' and keep watching there for folder content changes. $ sha1sum foobar2000_v1.* f3b010dbe90160ebb954544598ddefbb876651c4 foobar2000_v1.1.18.exe 14e088f3418e51991e9ec797819250094c2ffbb2 foobar2000_v1.3.exe 03f448c4e86f7d74a92029ce63f2c0d947c80711 foobar2000_v1.6.5.exe $ du -sh foobar2000_v1.* 3.3M foobar2000_v1.1.18.exe 3.6M foobar2000_v1.3.exe 4.6M foobar2000_v1.6.5.exe Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25265 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #18 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 6.7. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla