[Bug 41560] New: BCGPOutlookDemo.exe example fails to draw Themed Scrollbars
https://bugs.winehq.org/show_bug.cgi?id=41560 Bug ID: 41560 Summary: BCGPOutlookDemo.exe example fails to draw Themed Scrollbars Product: Wine Version: 1.9.7 Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs(a)winehq.org Reporter: leslie_alistair(a)hotmail.com Distribution: --- When using the BCGPOutlookDemo example, the standard window scrollbars are displayed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |9d91fce444fab9dc408f1e3834b | |2b0738843ec41 CC| |bunglehead(a)gmail.com Keywords| |regression --- Comment #1 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- commit 9d91fce444fab9dc408f1e3834b2b0738843ec41 Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon Mar 21 17:36:13 2016 +0300 user32: For EnableScrollBar() always go through EnableWindow() in SB_CTL cas Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 --- Comment #2 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- When the BCG Framework calls EnableScrollBar, it assumes that the custom draw code will be called via standard WM_PAINT messages. However, wine just calls though to its own SCROLL_DrawScrollBar which is why the standard scrollbars appear. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 --- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com> --- Where can I can this test application? How does this theming work - is it a custom draw style theming or uxtheme? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 --- Comment #4 from Nikolay Sivov <bunglehead(a)gmail.com> --- (In reply to Nikolay Sivov from comment #3)
Where can I can this test application? How does this theming work - is it a custom draw style theming or uxtheme?
Er, it should read "Where can I get", sorry. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://www.bcgsoft.com/down | |load.htm -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 --- Comment #5 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Updated the URL. It doesn't use uxtheme.
From a very basic test, I changed SCROLL_RefreshScrollBar to just Invalidate the control when EnableScrollBar was called. This fixed the problem but I have no idea on what other side effects it might have.
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|http://www.bcgsoft.com/down |http://www.bcgsoft.com/down |load.htm |load/samples/BCGPOutlookDem | |o.zip -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 --- Comment #6 from Nikolay Sivov <bunglehead(a)gmail.com> --- Where are those scrollbars on the demo UI? I can see on in message list, but it's working fine. And another one in folder treeview that is hard to tell if it's working or not, because treeview constantly repaints itself when I reduce its width to make scrollbar appear. P.S. demo needs mfc42. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 --- Comment #7 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- (In reply to Nikolay Sivov from comment #6)
Where are those scrollbars on the demo UI? I can see on in message list, but it's working fine. And another one in folder treeview that is hard to tell if it's working or not, because treeview constantly repaints itself when I reduce its width to make scrollbar appear.
The constant redraws maybe another issue or related. Not sure. I've reproduce the issue with another demo which is easier to spot. Run BCGPVisualStudioGUIDemo.exe Move the "Solution Explorer" splitter bar left so it will causes a scrollbar to appear in the Solution Explorer. Now both the Solution Explorer and Stage Page window scrollbars will appear unthemed. If then you mouse over the start page buttons, the scrollbar will revert back to it proper style. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 --- Comment #8 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Created attachment 56426 --> https://bugs.winehq.org/attachment.cgi?id=56426 Image to show the issue In the image you can see the themed scrollbar with the standard scrollbar being drawn on top (Start Page) window -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|BCGPOutlookDemo.exe example |BCGPVisualStudioGUIDemo.exe |fails to draw Themed |example fails to draw |Scrollbars |Themed Scrollbars -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bunglehead(a)gmail.com | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 --- Comment #9 from Nikolay Sivov <bunglehead(a)gmail.com> --- I see that Solution Explorer panel scrollbar is always standard. While Start Page one is always themed, unless you resize it quickly enough to see standard one repainted with a custom one. Not sure how if it's related yet, but Solution Explorer scrollbar works a bit differently on Windows too, if you make the panel narrow enough, scroll bar does not correctly repaint on window resize, instead you have to move mouse over it to update scroll thumb width. Could you attach diff you used to make it work? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 --- Comment #10 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Created attachment 59868 --> https://bugs.winehq.org/attachment.cgi?id=59868 Requested patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 --- Comment #11 from Nikolay Sivov <bunglehead(a)gmail.com> --- Does this patch help at all https://bugs.winehq.org/show_bug.cgi?id=42038#c7 ? I can't tell if demo program was changed, or if it's harder to reproduce now. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 --- Comment #12 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- (In reply to Nikolay Sivov from comment #11)
Does this patch help at all https://bugs.winehq.org/show_bug.cgi?id=42038#c7 ? I can't tell if demo program was changed, or if it's harder to reproduce now.
No, this didn't help. Open the Demo BCGPVisualStudioGUIDemo.exe The easiest way is to resize the dialog slowly, the "start page" scroll bar flickers between themed and not while it's moving. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|http://www.bcgsoft.com/down |https://web.archive.org/web |load/samples/BCGPOutlookDem |/20200407091952/https://www |o.zip |.bcgsoft.com/download/sampl | |es/BCGPVisualStudioGUIDemo. | |zip CC| |focht(a)gmx.net Summary|BCGPVisualStudioGUIDemo.exe |Multiple MFC-based |example fails to draw |BCGControlBar Library |Themed Scrollbars |examples fail to draw | |Themed Scrollbars | |(BCGPVisualStudioGUIDemo, | |BCGPOutlookDemo) --- Comment #13 from Anastasius Focht <focht(a)gmx.net> --- Hello folks, still present. Refining summary and adding stable download link via Internet Archive: https://web.archive.org/web/20200407091952/https://www.bcgsoft.com/download/... $sha1sum BCGPVisualStudioGUIDemo.zip 74dc39f48ed0481b7a4517ff8cd0d2a2505acc71 BCGPVisualStudioGUIDemo.zip $ du -sh BCGPVisualStudioGUIDemo.zip 5.3M BCGPVisualStudioGUIDemo.zip $ wine --version wine-5.5-325-gca092dcf81 Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zzhang(a)codeweavers.com Status|NEW |RESOLVED Fixed by SHA1| |0a83027e20ecddc3cb87d1ee6d9 | |eca88f92b1897 Resolution|--- |FIXED --- Comment #14 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Fixed by 0a83027e20ecddc3cb87d1ee6d9eca88f92b1897 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41560 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #15 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 6.15. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla