[Bug 37723] New: [regression][workaround] Elevated demo is broken since wine-1.3.24
https://bugs.winehq.org/show_bug.cgi?id=37723 Bug ID: 37723 Summary: [regression][workaround] Elevated demo is broken since wine-1.3.24 Product: Wine Version: 1.7.33 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: debuser1(a)mt2014.com Distribution: --- Created attachment 50218 --> https://bugs.winehq.org/attachment.cgi?id=50218 elevated_1024x768.exe Steps to reproduce: 1. Install `winetricks winxp vd=1024x768 d3dx9` in empty wineprefix (d3dx9_33 is enough, but winetricks doesn't have a term for it) 2. Run elevated_1024x768.exe ( http://www.pouet.net/prod.php?which=52938 ) Expected result: awesome demo playing Actual result: very slow playback under wine-1.3.23, crash under wine-1.3.24, silent exit under wine-1.3.25 and newer Regression history: * wine-1.3.23-213-g704f0ef - assertion failed crash * wine-1.3.24-61-g901af51 + wine-1.3.24-62-gbe158e4 - silent exit -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37723 --- Comment #1 from debuser <debuser1(a)mt2014.com> --- Created attachment 50219 --> https://bugs.winehq.org/attachment.cgi?id=50219 Workaround hack With this patch applied Elevated works again. Notes: waveOutGetPosition() is called with uSize==32, while sizeof(MMTIME)==12. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37723 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leslie_alistair(a)hotmail.com --- Comment #2 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> ---
if(!uSize || !lpTime || uSize != sizeof(MMTIME)) This properly should be
if(!uSize || !lpTime || uSize < sizeof(MMTIME)) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37723 --- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com> --- Needs a test in any case. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37723 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://www.pouet.net/prod.p | |hp?which=52938 CC| |mstefani(a)redhat.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37723 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from Michael Stefaniuc <mstefani(a)redhat.com> --- Patch to fix the d3d9/shader.c regressions submitted. https://source.winehq.org/patches/data/108241 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37723 Andrew Eikum <aeikum(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aeikum(a)codeweavers.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37723 --- Comment #5 from Michael Stefaniuc <mstefani(a)redhat.com> --- The patch from comment 4 is incorrect but the fixed one makes the app have a garbled output. So it needs more research. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37723 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[regression][workaround] |Elevated demo silently |Elevated demo is broken |exits |since wine-1.3.24 | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37723 --- Comment #6 from Michael Stefaniuc <mstefani(a)redhat.com> --- This gets more puzzling the longer I look at it... Replacing both d3d9/shader.c asserts with a WARN produces: warn:d3d9:unsafe_impl_from_IDirect3DVertexShader9 Vertex shader 0x191110 with the wrong vtbl (nil) warn:d3d9:unsafe_impl_from_IDirect3DPixelShader9 Pixel shader 0x1bc210 with the wrong vtbl (nil) Both interfaces where created with trace:d3d9:d3d9_device_CreateVertexShader Created vertex shader 0x191110. respectively trace:d3d9:d3d9_device_CreatePixelShader Created pixel shader 0x1bc210. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37723 --- Comment #7 from Michael Stefaniuc <mstefani(a)redhat.com> --- The wimm part of the regression fixed by http://source.winehq.org/git/wine.git/?a=commit;h=cba322d71d317bc52e9de5a057... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37723 --- Comment #8 from Michael Stefaniuc <mstefani(a)redhat.com> --- Now the proper patch with tests https://source.winehq.org/patches/data/108258 Tests succeed on the w8 WTB machine (all others skip) and on a WinXP box on real hardware (thanks debuser!) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37723 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |51406b471aa81a56dc38e4b266b | |51e09646987c7 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #9 from Michael Stefaniuc <mstefani(a)redhat.com> --- Patch for the d3d9/shader.c regression committed too: http://source.winehq.org/git/wine.git/?a=commit;h=51406b471aa81a56dc38e4b266... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37723 --- Comment #10 from debuser <debuser1(a)mt2014.com> --- It works! Thanks a lot! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37723 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |focht(a)gmx.net Component|-unknown |directx-d3dx9 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37723 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #11 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.34. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org