[Bug 52679] New: Anno 1602 / 1602 A.D. graphics too dark / black
https://bugs.winehq.org/show_bug.cgi?id=52679 Bug ID: 52679 Summary: Anno 1602 / 1602 A.D. graphics too dark / black Product: Wine Version: 6.11 Hardware: x86-64 URL: https://archive.org/details/1602ADdemo OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: marc.pluhar+winehq(a)gmail.com Distribution: ArchLinux Created attachment 72012 --> https://bugs.winehq.org/attachment.cgi?id=72012 Screenshot of the game with black graphics When starting the game "Anno 1602" an intro video plays fine, but when arriving at the menu, everything is very dark (see 1602_ad_wine_6.11.png). I remember playing this game a while ago, so I tried different versions and it starts failing like this in version 6.11. When compiling the current master (8a52d3e93f5690fd0833c228d54a996a784afad7) directly from source, the problem also persists. Version 6.10 works fine. The demo of the game exhibits the same behaviour, so I added a download link for it. I also attached the console log, but I don't see anything different between the two starts. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52679 --- Comment #1 from Marc P <marc.pluhar+winehq(a)gmail.com> --- Created attachment 72013 --> https://bugs.winehq.org/attachment.cgi?id=72013 Screenshot of the game working correctly -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52679 --- Comment #2 from Marc P <marc.pluhar+winehq(a)gmail.com> --- Created attachment 72014 --> https://bugs.winehq.org/attachment.cgi?id=72014 Logfile of start with black graphics The message 0118:fixme:d3d:surface_cpu_blt Filter WINED3D_TEXF_LINEAR not supported in software blit. repeats during the intro video (which works fine) and is also logged with the version 6.10. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52679 Marc P <marc.pluhar+winehq(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |gdi32 Regression SHA1| |d171d1116764260f4ae272c69b5 | |4e5dfd13c6835 --- Comment #3 from Marc P <marc.pluhar+winehq(a)gmail.com> --- I did a bisect and found the commit that breaks. If I revert either of the changes from the commit on current master, the game works correctly again. Anything I can do to narrow this down? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52679 --- Comment #4 from Marc P <marc.pluhar+winehq(a)gmail.com> --- Created attachment 72019 --> https://bugs.winehq.org/attachment.cgi?id=72019 revert1.patch Reverts dlls/winex11.drv/init.c from d171d1116764260f4ae272c69b54e5dfd13c6835 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52679 --- Comment #5 from Marc P <marc.pluhar+winehq(a)gmail.com> --- Created attachment 72020 --> https://bugs.winehq.org/attachment.cgi?id=72020 revert2.patch Reverts dlls/user32/tests/monitor.c from d171d1116764260f4ae272c69b54e5dfd13c6835 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52679 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zzhang(a)codeweavers.com Keywords| |download, regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52679 Marc P <marc.pluhar+winehq(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72019|0 |1 is obsolete| | Attachment #72020|0 |1 is obsolete| | --- Comment #6 from Marc P <marc.pluhar+winehq(a)gmail.com> --- Created attachment 72044 --> https://bugs.winehq.org/attachment.cgi?id=72044 NUMCOLORS_ignore_bpp.patch I did some more tests and it seems the main culprit is the NUMCOLORS capability. It returns 256 for 8 bpp, but -1 in all other cases. If it returns -1 unconditionally, the game works. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52679 --- Comment #7 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- (In reply to Marc P from comment #6)
Created attachment 72044 [details] NUMCOLORS_ignore_bpp.patch
I did some more tests and it seems the main culprit is the NUMCOLORS capability. It returns 256 for 8 bpp, but -1 in all other cases. If it returns -1 unconditionally, the game works.
Makes sense. 8-bit color depth is actually emulated. Could add some tests and submit the patch? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52679 --- Comment #8 from Marc P <marc.pluhar+winehq(a)gmail.com> --- (In reply to Zhiyi Zhang from comment #7)
Makes sense. 8-bit color depth is actually emulated. Could add some tests and submit the patch?
Thanks, that would be great. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52679 --- Comment #9 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- (In reply to Marc P from comment #8)
(In reply to Zhiyi Zhang from comment #7)
Makes sense. 8-bit color depth is actually emulated. Could add some tests and submit the patch?
Thanks, that would be great.
Hi, how is it going? If you're having trouble writing the tests or submitting the patch, I can do it instead. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52679 --- Comment #10 from Marc P <marc.pluhar+winehq(a)gmail.com> --- (In reply to Zhiyi Zhang from comment #9)
Hi, how is it going? If you're having trouble writing the tests or submitting the patch, I can do it instead.
Hi, I realised I misread your comment. After looking at the tests I don't really know what to do. I am not a C developer. If you could submit it instead, that would be really appreciated. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52679 --- Comment #11 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- (In reply to Marc P from comment #10)
Hi, I realised I misread your comment. After looking at the tests I don't really know what to do. I am not a C developer.
If you could submit it instead, that would be really appreciated.
Alright, I will take it from here. Thanks for the investigation. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52679 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Fixed by SHA1| |a1dda8c376e11ace204e8b97a9b | |a9344e400e2a5 Resolution|--- |FIXED --- Comment #12 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Fixed by a1dda8c376e11ace204e8b97a9ba9344e400e2a5 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52679 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #13 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 7.7. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52679 --- Comment #14 from Marc P <marc.pluhar+winehq(a)gmail.com> --- Confirmed working in 7.7. Thanks for your work. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52679 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |7.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52679 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|7.0.x |--- --- Comment #15 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 7.0.x milestone from bug fixes included in 7.0.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla