New subject: [Bug 54425] user32:clibpoard - test_string_data_process() fails on Windows in mixed locales

1 Feb 2023

      https://bugs.winehq.org/show_bug.cgi?id=54425

            Bug ID: 54425
           Summary: user32:clibpoard - test_string_data_process() fails on
                    Windows in mixed locales
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: user32
          Assignee: wine-bugs(a)winehq.org
          Reporter: fgouget(a)codeweavers.com
      Distribution: ---

user32:clibpoard - test_string_data_process() fails on Windows in mixed
locales:

clipboard.c:2351: Test failed: 7: wrong size 2 / 3
clipboard.c:2352: Test failed: 7: wrong data "a\x00", expected "\x83\xbf\x00"
1020:clipboard: 7 tests executed (0 marked as todo, 0 as flaky, 2 failures), 0
skipped.
clipboard.c:231: 2 failures in child process
clipboard.c:2351: Test failed: 8: wrong size 3 / 5
clipboard.c:2352: Test failed: 8: wrong data "a\xdf\x00", expected
"\x83\xbf\x83\xc0\x00"
2024:clipboard: 7 tests executed (0 marked as todo, 0 as flaky, 2 failures), 0
skipped.
clipboard.c:231: 2 failures in child process
clipboard.c:2351: Test failed: 9: wrong size 3 / 5
clipboard.c:2352: Test failed: 9: wrong data "a\xdf\x00", expected
"\x83\xbf\x83\xc0\x00"
1a7c:clipboard: 7 tests executed (0 marked as todo, 0 as flaky, 2 failures), 0
skipped.
clipboard.c:231: 2 failures in child process
clipboard.c:2351: Test failed: 10: wrong size 4 / 7
clipboard.c:2352: Test failed: 10: wrong data "a\xdf?\x00", expected
"\x83\xbf\x83\xc0\x83\xc1\x00"
1538:clipboard: 7 tests executed (0 marked as todo, 0 as flaky, 2 failures), 0
skipped.
clipboard.c:231: 2 failures in child process
clipboard.c:2351: Test failed: 11: wrong size 4 / 7
clipboard.c:2352: Test failed: 11: wrong data "a\xdf?\x00", expected
"\x83\xbf\x83\xc0\x83\xc1\x00"
05bc:clipboard: 7 tests executed (0 marked as todo, 0 as flaky, 2 failures), 0
skipped.
clipboard.c:231: 2 failures in child process

See https://test.winehq.org/data/patterns.html#user32:clipboard

The failures happen in the w10pro64-mx-MX test configuration. What's special
about it is that it uses a mix of locales:

SystemDefaultLCID    0411
UserDefaultLCID    040c
ThreadLocale    0411
SystemPreferredUILanguages    0412,0409
UserDefaultUILanguage    0412
ThreadUILanguage    0412
Country    231
ACP    932

The failures started happening with the commit below:

commit 605ecafa67a4e034328b69396581e2f9b60d7af3
Author: Francois Gouget <fgouget(a)codeweavers.com>
Date:   Wed Dec 21 18:48:29 2022 +0100

    user32: Fix a SetClipboardData() buffer overflow.

    Wine would append a correctly aligned NUL Unicode character to
    terminate the string but overflow the buffer by one byte for odd-sized
    strings.
    Windows instead overwrites the last two buffer bytes with a NUL Unicode
    character which ends up being misaligned for odd-sized strings.
    The clipboard data has a size field anyway so match the Windows
    behavior.
    Tweak the tests to show that SetClipboardData() can overwrite half of
    the Unicode string's last character.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 54425] New: user32:clibpoard - test_string_data_process() fails on Windows in mixed locales

WineHQ Bugzilla

WineHQ Bugzilla

WineHQ Bugzilla

WineHQ Bugzilla

WineHQ Bugzilla

tags

participants (2)