[Bug 48396] New: 'cmd.exe /c move file1 file2' doesn't respect non-interactive mode, causing prompt for overwrite if destination file exists
https://bugs.winehq.org/show_bug.cgi?id=48396 Bug ID: 48396 Summary: 'cmd.exe /c move file1 file2' doesn't respect non-interactive mode, causing prompt for overwrite if destination file exists Product: Wine Version: 5.0-rc3 Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: cmd Assignee: wine-bugs(a)winehq.org Reporter: focht(a)gmx.net Distribution: --- Hello folks, as it says. Noticed this with some scene installers that use batch files to uncompress and concatenate files. At one point the progress stalls and a number of 'cmd.exe' processes just sit around, waiting for input (they are non-interactive). Reason: Wine's cmd.exe 'move' doesn't take non-interactive mode into account when destination file exists. Cmd's 'copy' works. --- snip --- $ echo "1" > test1 $ echo "2" > test2 # fails but should work $ wine cmd /c move test1 test2 Overwrite Z:\home\focht\test2? (Yes|No) --- snip --- Setting 'COPYCMD' environment variable to '/Y' avoids the prompt, but still doesn't overwrite the destination file with original which is another bug. Oh boy, cmd.exe really needs some love. Still so broken after years. Wine source: https://source.winehq.org/git/wine.git/blob/HEAD:/programs/cmd/builtins.c#l2... --- snip --- 2959 void WCMD_move (void) 2960 { 2961 BOOL status; 2962 WIN32_FIND_DATAW fd; 2963 HANDLE hff; 2964 WCHAR input[MAX_PATH]; 2965 WCHAR output[MAX_PATH]; 2966 WCHAR drive[10]; 2967 WCHAR dir[MAX_PATH]; 2968 WCHAR fname[MAX_PATH]; 2969 WCHAR ext[MAX_PATH]; ... 3023 /* If destination exists, prompt unless /Y supplied */ 3024 if (GetFileAttributesW(dest) != INVALID_FILE_ATTRIBUTES) { 3025 BOOL force = FALSE; 3026 WCHAR copycmd[MAXSTRING]; 3027 DWORD len; 3028 3029 /* /-Y has the highest priority, then /Y and finally the COPYCMD env. variable */ 3030 if (wcsstr (quals, parmNoY)) 3031 force = FALSE; 3032 else if (wcsstr (quals, parmY)) 3033 force = TRUE; 3034 else { 3035 static const WCHAR copyCmdW[] = {'C','O','P','Y','C','M','D','\0'}; 3036 len = GetEnvironmentVariableW(copyCmdW, copycmd, ARRAY_SIZE(copycmd)); 3037 force = (len && len < ARRAY_SIZE(copycmd) && !lstrcmpiW(copycmd, parmY)); 3038 } 3039 3040 /* Prompt if overwriting */ 3041 if (!force) { 3042 WCHAR* question; 3043 3044 /* Ask for confirmation */ 3045 question = WCMD_format_string(WCMD_LoadMessage(WCMD_OVERWRITE), dest); 3046 ok = WCMD_ask_confirm(question, FALSE, NULL); 3047 LocalFree(question); 3048 3049 /* So delete the destination prior to the move */ 3050 if (ok) { 3051 if (!DeleteFileW(dest)) { 3052 WCMD_print_error (); 3053 errorlevel = 1; 3054 ok = FALSE; 3055 } 3056 } 3057 } 3058 } ... --- snip --- While at it you could really refactor/unify the code more. Even basic 'COPYCMD' handling is implemented in different code style (move vs. copy): https://source.winehq.org/git/wine.git/blob/HEAD:/programs/cmd/builtins.c#l7... $ wine --version wine-5.0-rc3 Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48396 --- Comment #1 from Anastasius Focht <focht(a)gmx.net> --- Hello folks, I've created bug 48397 ("'cmd.exe /c move file1 file2' doesn't overwrite existing destination file in non-interactive mode") for the second issue mentioned here. Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48396 Franc[e]sco <lolisamurai(a)tfwno.gf> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lolisamurai(a)tfwno.gf --- Comment #2 from Franc[e]sco <lolisamurai(a)tfwno.gf> --- can confirm that this broke a few installers for me. would be nice to have it fixed. since windows 2000, move should never ask for confirmation in non-interactive mode -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48396 --- Comment #3 from Franc[e]sco <lolisamurai(a)tfwno.gf> --- Created attachment 68132 --> https://bugs.winehq.org/attachment.cgi?id=68132 patch that fixes the bug I propose this patch to fix this and the associated bug with COPYCMD -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48396 qsniyg <qsniyg(a)mail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |qsniyg(a)mail.com --- Comment #4 from qsniyg <qsniyg(a)mail.com> --- Should be fixed with d1790c984bebb55e4d08644e84cfabd85abeefe2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48396 --- Comment #5 from Franc[e]sco <lolisamurai(a)tfwno.gf> --- yeah this is fixed, thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48396 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |d1790c984bebb55e4d08644e84c | |fabd85abeefe2 Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #6 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- Can confirm this is fixed, marking as such. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48396 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 5.18. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48396 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |5.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48396 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|5.0.x |--- --- Comment #8 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 5.0.x milestone from bug fixes included in 5.0.4. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla