[Bug 52465] New: Toolbar: Wrong TB_GETBUTTON message processing, returns (-1) instead of separator width in TBBUTTON structure
https://bugs.winehq.org/show_bug.cgi?id=52465 Bug ID: 52465 Summary: Toolbar: Wrong TB_GETBUTTON message processing, returns (-1) instead of separator width in TBBUTTON structure Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs(a)winehq.org Reporter: yal(a)csoftcom.com Distribution: ---
From MSDN documents about TB_GETBUTTON : If the button is a separator, that is, if fsStyle is set to BTNS_SEP, iBitmap determines the width of the separator, in pixels.
So, this code needs to change: /wine/dlls/comctl32/toolbar.c:3373 static LRESULT TOOLBAR_GetButton (const TOOLBAR_INFO *infoPtr, INT nIndex, TBBUTTON *lpTbb) { ---------------------------<cut>------------------------ /*From MSDN documents: If the button is a separator, that is, if fsStyle is set to BTNS_SEP, iBitmap determines the width of the separator, in pixels*/ lpTbb->iBitmap = (btnPtr->fsStyle & BTNS_SEP) ? SEPARATOR_WIDTH : btnPtr->iBitmap; ---------------------------<cut>------------------------ -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52465 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> --- Thanks, I just sent some tests for this [1]. We'll need more things tested before fixing this, but submitted test already shows that we'll need to maintain correct value, rather than conditionally return a constant. [1] https://www.winehq.org/pipermail/wine-devel/2022-January/205810.html -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52465 --- Comment #2 from YAL <yal(a)csoftcom.com> --- I've tested Win10/11 with different monitor/font scaling - it always return constant 8. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52465 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |7.0 CC| |dark.shadow4(a)web.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=52465 KRosUser <kyle.kcsoftwares(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.kcsoftwares(a)gmail.com --- Comment #3 from KRosUser <kyle.kcsoftwares(a)gmail.com> --- Problem still present in 10.7: https://github.com/wine-mirror/wine/blob/master/dlls/comctl32/toolbar.c#L336... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla