[Bug 16704] New: wineconsole: Allow specifying the console backend to use when wineconsole is launched implicitly
http://bugs.winehq.org/show_bug.cgi?id=16704 Summary: wineconsole: Allow specifying the console backend to use when wineconsole is launched implicitly Product: Wine Version: CVS/GIT Platform: All OS/Version: All Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: programs AssignedTo: wine-bugs(a)winehq.org ReportedBy: wine(a)martin.st Created an attachment (id=18363) --> (http://bugs.winehq.org/attachment.cgi?id=18363) Proposed patch for fixing the issue When wineconsole is launched implicitly, when an application in wine opens a console, it currently defaults to using the user backend of wineconsole, without any possibility of changing which backend to use. The console application to launch can be changed using the WINECONSOLE environment variable, and wine appends --use-event=xx to that command line when launching the console program. Setting WINECONSOLE to "wineconsole --backend=curses" is ignored, since wineconsole chooses the user backend as soon as the --use-event argument is parsed. This isn't necessary, since the user backend is the default one. By removing the explicit setting of the user backend when parsing the --use-event argument, choosing another backend through the WINECONSOLE environment variable works as expected. The attached patch implements this proposed change. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16704 Dmitry Timoshkov <dmitry(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- OS/Version|All |other Platform|All |Other Version|CVS/GIT |1.1.11 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16704 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch CC| |austinenglish(a)gmail.com --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2009-07-08 14:45:12 --- Please send patches to wine-patches(a)winehq.org -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16704 --- Comment #2 from Martin Storsjö <wine(a)martin.st> 2009-07-08 14:50:16 --- Yes, this patch was initially sent to wine-patches(a)winehq.org in November 2008 (http://www.winehq.org/pipermail/wine-patches/2008-November/065234.html) but received no attention at that point. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16704 --- Comment #3 from Austin English <austinenglish(a)gmail.com> 2009-07-08 14:52:10 --- (In reply to comment #2)
Yes, this patch was initially sent to wine-patches(a)winehq.org in November 2008 (http://www.winehq.org/pipermail/wine-patches/2008-November/065234.html) but received no attention at that point.
Try resending to wine-devel and ask for comments. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16704 --- Comment #4 from Austin English <austinenglish(a)gmail.com> 2009-07-08 15:11:09 --- Is this still an issue in current (1.1.25 or newer) wine? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16704 --- Comment #5 from Martin Storsjö <wine(a)martin.st> 2009-07-09 04:06:11 --- Yes, the issue is unchanged in the latest version in git. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16704 --- Comment #6 from Austin English <austinenglish(a)gmail.com> 2009-07-09 13:48:29 --- (In reply to comment #5)
Yes, the issue is unchanged in the latest version in git.
I resent it for you: http://www.winehq.org/pipermail/wine-patches/2009-July/075683.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16704 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #7 from Austin English <austinenglish(a)gmail.com> 2010-07-23 15:11:47 --- Still present in wine-1.2-422-ge158bb0. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16704 --- Comment #8 from Martin Storsjö <wine(a)martin.st> 2010-12-21 06:42:12 CST --- The patch you resent in July 2009 actually is an incorrect version, removing the general default, not removing the statement where the previous value is overwritten when handling the --use-event parameter. Did I send it in that form somewhere, or did you modify it? While the patch still hasn't been applied, and still would be useful, I'm not able to reproduce the cases that triggered a wineconsole to be launched implicitly any longer, with the latest version from git. In all those cases, AllocConsole is able to find an existing console internally, so the actual need for this isn't that big any longer. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16704 --- Comment #9 from Austin English <austinenglish(a)gmail.com> 2010-12-21 14:52:40 CST --- (In reply to comment #8)
The patch you resent in July 2009 actually is an incorrect version, removing the general default, not removing the statement where the previous value is overwritten when handling the --use-event parameter. Did I send it in that form somewhere, or did you modify it?
While the patch still hasn't been applied, and still would be useful, I'm not able to reproduce the cases that triggered a wineconsole to be launched implicitly any longer, with the latest version from git. In all those cases, AllocConsole is able to find an existing console internally, so the actual need for this isn't that big any longer.
The patch was the same as you sent. Feel free to send a fixed version. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16704 --- Comment #10 from Martin Storsjö <wine(a)martin.st> 2010-12-21 16:08:58 CST --- Sent the old patch again. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16704 Martin Storsjö <wine(a)martin.st> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #11 from Martin Storsjö <wine(a)martin.st> 2010-12-23 12:24:00 CST --- Fixed by http://source.winehq.org/git/wine.git/?a=commitdiff;h=0f3ff8b4b162202e687ebe... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16704 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #12 from Alexandre Julliard <julliard(a)winehq.org> 2010-12-24 13:13:13 CST --- Closing bugs fixed in 1.3.10. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16704 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.2.x -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16704 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.2.x |--- -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org