[Bug 46972] New: Adobe DNG Converter 11.2+ no longer works in wine
https://bugs.winehq.org/show_bug.cgi?id=46972 Bug ID: 46972 Summary: Adobe DNG Converter 11.2+ no longer works in wine Product: Wine Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: api-ms-win-* Assignee: wine-bugs(a)winehq.org Reporter: lebedev.ri(a)gmail.com Distribution: --- download for 11.2: https://supportdownloads.adobe.com/detail.jsp?ftpID=6589 Errors: 0039:err:combase:RoGetActivationFactory Failed to find library for L"Windows.Foundation.Metadata.ApiInformation" wine: Call from 0x7b44fd66 to unimplemented function api-ms-win-core-winrt-error-l1-1-0.dll.GetRestrictedErrorInfo, aborting -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 Louis Lenders <xerox.xerox2000x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |xerox.xerox2000x(a)gmail.com Ever confirmed|0 |1 URL| |https://supportdownloads.ad | |obe.com/detail.jsp?ftpID=65 | |89 Keywords| |download --- Comment #1 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Confirming + added some info. sha1sum /media/louis/aqqa/DNGConverter_11_2_1.exe 27685928e5d884f1ac45488d7acc115e252fcd5a /media/louis/aqqa/DNGConverter_11_2_1.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 Louis Lenders <xerox.xerox2000x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Adobe DNG Converter 11.2+ |Adobe DNG Converter 11.2+ |no longer works in wine |runs into Call to | |unimplemented function | |api-ms-win-core-winrt-error | |-l1-1-0.dll.GetRestrictedEr | |rorInfo --- Comment #2 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- + adjust title I -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 --- Comment #3 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Created attachment 64141 --> https://bugs.winehq.org/attachment.cgi?id=64141 stub for GetRestrictedErrorInfo Hi riman, here`s a patch (stub for GetRestrictedErrorInfo) that makes the program start fine for me. Not 100% sure if i did everything correctly, so if someone could give tips/hints that would be fine. Also attach required headerfile hereafter -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 --- Comment #4 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Created attachment 64142 --> https://bugs.winehq.org/attachment.cgi?id=64142 required idl file for patchfrom previous comment required idl file for patchfrom previous comment -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 --- Comment #5 from Nikolay Sivov <bunglehead(a)gmail.com> --- According to function description, you don't need to create stub object for it, and instead should rely on object set with SetErrorInfo(). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 --- Comment #6 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Created attachment 64143 --> https://bugs.winehq.org/attachment.cgi?id=64143 crash log with staging
According to function description, you don't need to create stub object for it, >and instead should rely on object set with SetErrorInfo().
i tried simpler stub but couldn`t get it work. Wouldn`t it be so that the app then would crash in an expected unimplemented SetRestrictedErrorInfo? I`ve attached +relay log made with Staging, i don`t see anything related to SetRestrictedErrorInfo (or SetErrorInfo). But maybe i don`t get the decsription right -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 Louis Lenders <xerox.xerox2000x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64141|0 |1 is obsolete| | --- Comment #7 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Created attachment 64144 --> https://bugs.winehq.org/attachment.cgi?id=64144 patch 2 But i guess you were right. This much simpler patch fixes the crash too, somehow i did something wrong/different yesterday It runs into extra unimplemented RoOriginateLanguageException, with stub for that the application starts fine. I`ll send (polished up )patch later -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 --- Comment #8 from Nikolay Sivov <bunglehead(a)gmail.com> --- (In reply to Louis Lenders from comment #7)
Created attachment 64144 [details] patch 2
But i guess you were right.
This much simpler patch fixes the crash too, somehow i did something wrong/different yesterday
It runs into extra unimplemented RoOriginateLanguageException, with stub for that the application starts fine.
I`ll send (polished up )patch later
It should return S_FALSE if error object does not support this interface. This is easy to implement correctly, but needs some tests, e.g. you can set error object supporting this interface with SetErrorInfo too. If that's not picked up with GetRestrictedErrorInfo(), we probably should move error object handling to combase but that involves moving more unrelated code from ole32. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 --- Comment #9 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- (In reply to Nikolay Sivov from comment #8)
(In reply to Louis Lenders from comment #7)
It should return S_FALSE if error object does not support this interface. This is easy to implement correctly, but needs some tests, e.g. you can set error object supporting this interface with SetErrorInfo too. If that's not picked up with GetRestrictedErrorInfo(), we probably should move error object handling to combase but that involves moving more unrelated code from ole32.
huh, sounds like rather complex task then. If you don`t mind i`ll leave this bug to someone else then to solve as i think i`m not the right person to tackle this. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED Staged patchset| |https://github.com/wine-sta | |ging/wine-staging/tree/mast | |er/patches/combase-GetRestr | |ictedErrorInfo CC| |leslie_alistair(a)hotmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|api-ms-win-* |ole32 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 sami(a)boukortt.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sami(a)boukortt.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 theywantemail-winehq(a)yahoo.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |theywantemail-winehq(a)yahoo. | |com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 Tomáš Bžatek <bugs(a)bzatek.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugs(a)bzatek.net --- Comment #10 from Tomáš Bžatek <bugs(a)bzatek.net> --- Affects Adobe Lightroom since 8.2 (AFAIR) as well, still an issue with recent Lightroom 9.1 release. The staged patch from 8 Apr 2019 works fine, Lightroom is running stable for hours. wine-5.0_rc3:
005a:fixme:combase:RoGetActivationFactory (L"Windows.Foundation.Metadata.ApiInformation", {997439fe-f681-4a11-b416-c13a47e8ba36}, 000000000022D1F8): semi-stub 005a:err:combase:RoGetActivationFactory Failed to find library for L"Windows.Foundation.Metadata.ApiInformation" wine: Call from 0x7f6a1887f398 to unimplemented function api-ms-win-core-winrt-error-l1-1-0.dll.GetRestrictedErrorInfo, aborting wine: Unimplemented function api-ms-win-core-winrt-error-l1-1-0.dll.GetRestrictedErrorInfo called at address 00007F6A1887F398 (thread 005a), starting debugger...
The combase:RoGetActivationFactory() stub is apparently not fatal for Lightroom. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|STAGED |RESOLVED Fixed by SHA1| |774aaa1d309dfc9eaa0cd639089 | |0d88387fbae4b --- Comment #11 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Fixed by https://source.winehq.org/git/wine.git/?a=commit;h=774aaa1d309dfc9eaa0cd6390... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 Theodore Bumpers <wine(a)londonlight.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wine(a)londonlight.org --- Comment #12 from Theodore Bumpers <wine(a)londonlight.org> --- As of which version of wine (tag) will this fix be included? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #13 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 5.0-rc5. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |4.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|4.0.x |--- --- Comment #14 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 4.0.x milestone from bug fixes included in 4.0.4. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46972 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |4.5 CC| |focht(a)gmx.net URL|https://supportdownloads.ad |https://web.archive.org/web |obe.com/detail.jsp?ftpID=65 |/20201223220530/http://down |89 |load.adobe.com/pub/adobe/dn | |g/win/DNGConverter_11_2_1.e | |xe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla