[Bug 39547] New: OllyDbg 2.x tooltips steal focus from their parent window
https://bugs.winehq.org/show_bug.cgi?id=39547 Bug ID: 39547 Summary: OllyDbg 2.x tooltips steal focus from their parent window Product: Wine Version: 1.7.52 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs(a)winehq.org Reporter: b7.10110111(a)gmail.com Distribution: --- To reproduce: 1. Start OllyDbg 2.x 2. Run some win32 executable (try using native dbghelp if it crashes on loading) 3. Double-click a register, e.g. EAX, see its edit dialog 4. Hover an entry field, e.g. Hexadecimal EAX 5. See appearing tooltip to make the dialog inactive (so you have to move cursor away or use Alt-Tab to actually enter something into the text field) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 Ruslan Kabatsayev <b7.10110111(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://www.ollydbg.de/ -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 lilydjwg(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lilydjwg(a)gmail.com --- Comment #1 from lilydjwg(a)gmail.com --- This happens with me too. I'm running QQ7.5Light (QQLite 7.5). All tooltips tend to steal focus. I can tell from my Awesome window manager showing the underlying window unfocused when the tooltip is shown. I'm using complex code to tell Awesome not to give those windows focus (and borders). The code is here: https://github.com/lilydjwg/myawesomerc/blob/master/rc.lua#L930-L944 This breaks when I try to search in the QQ main window. Every result entry shown there has two buttons; hovering on it a tooltip will show to tell the user what it does. Before I read the tooltip, however, the search state is gone, because the focus is no longer on the main window and I type nothing to search. The tooltip steals the focus. If I remembered correctly, this also broke QQ's "@nick" completion, before I added the rules to not give focus to it. I suggest you set override_redirect on every window with the class TOOLTIPS_CLASSW. That class says the window is a tooltip, and a tooltip shouldn't be managed by a window manager. Surely I don't have this issue when I run programs with virtual desktop, or I configure wine to not permit window managers to control windows with winecfg. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 Robert Munteanu <robert.munteanu(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robert.munteanu(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 Chituc Georgian <dianaxxyyzz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dianaxxyyzz(a)gmail.com --- Comment #2 from Chituc Georgian <dianaxxyyzz(a)gmail.com> --- To make tool tips not to steal focus on Photoshop Cs6 (and maybe others apps too) I modified /dlls/user32/win.c . //add this to your include #include <string.h> #include <stdio.h> #include "commctrl.h" //find this function HWND WIN_CreateWindowEx( CREATESTRUCTW *cs, LPCWSTR className, HINSTANCE module, BOOL unicode ) { INT cx, cy, style, sw = SW_SHOW; LRESULT result; RECT rect; WND *wndPtr; HWND hwnd, parent, owner, top_child = 0; MDICREATESTRUCTW mdi_cs; CBT_CREATEWNDW cbtc; CREATESTRUCTW cbcs; ///////add this if (strcmp ( debugstr_w(className) ,debugstr_w(TOOLTIPS_CLASSW) ) == 0 ) { cs->style = WS_POPUP; cs->dwExStyle = 0; /* This next line patch for some tools tips that do not dissapear from screen */ if ( cs->hInstance == NULL ) return 0; } ///////////////////// -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #3 from Robert Munteanu <robert.munteanu(a)gmail.com> --- (In reply to comment #2)
To make tool tips not to steal focus on Photoshop Cs6 (and maybe others apps too) I modified /dlls/user32/win.c .
If you found a fix that's great! Maybe you want to take a look at https://wiki.winehq.org/Submitting_Patches and submit the patch to the project, not everyone where is able to rebuild wine easily :-) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #4 from Chituc Georgian <dianaxxyyzz(a)gmail.com> --- Ok , I tested OllyDbg 2.0.1 ,and using the patch I put in previous comment , I can confirm this problem is gone , It has gone for photoshop too.Maybe somebody have a way to submit this patch to wine git . -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #5 from Chituc Georgian <dianaxxyyzz(a)gmail.com> --- I tested about 5-10 apps that display tool tips and from what I see all is fine for all the app . In photoshop all toot tips work great , except from some tool tips what are created via CreateWindowW() using a NULL hInstance .These are just few tool tips and not very important in Photoshop Cs6. Photoshop use CreateWindowW() to create them and send a NULL hInstance . And having NULL hInstance , the linux windows manager can not control and make this tool tips dissappear from screen .So I choose to just do not display this tool tips taht are created with a null hInstance . That way I put this line : if ( cs->hInstance == NULL ) return 0; . Maybe there is a fix , but for momment I do nto have time to dig more . Over all for me all looks good. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 winetest(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest(a)luukku.com --- Comment #6 from winetest(a)luukku.com --- I am not 100% sure, but I think there are other bugs open related to this issue. It would be worth to test if the patch fixes other bugs too. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #7 from Chituc Georgian <dianaxxyyzz(a)gmail.com> --- This bug related to tool tips that steal focus i see was also present since 2007 ,but not fixed . My code fix tool tips to do not steal focus . It do not fix the bug related to wine : Some tool tips do not dissaper from screen. So for now I just preffered to make it to do not display the tool tips that have the problem to not dissapearing from screen. 90% of the tool tips ,are the ones who just steal focus , and this is resolved. But some tool tips ,witch are created with a null hinstance , do not steal focus , but refuse to dissappear , and this are not resolved yet. Some ppls said this is a problem in compiz , but I use cinnamon (linux mint) and problem is here too.I tried to fix this tool tips too,modifying wine source code , but till now I failed.I just had succes to make tool tips to do not steal focus . -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #8 from Chituc Georgian <dianaxxyyzz(a)gmail.com> --- I fixed also the tool tips that refused till now to dissapear from screen , I patched wine ,and all is good ,In cinnamon linux mint 18 all is perfect regarding to tool tips ,and I can say I got a perfect photoshop now . I think must work for compiz too . I have to test but from what I see , the is no problem now will tool tips , tehy no longer steal focus and no longer remain on screen. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #9 from Chituc Georgian <dianaxxyyzz(a)gmail.com> --- Created attachment 55833 --> https://bugs.winehq.org/attachment.cgi?id=55833 This is a patch for wine 1.8.4 stable , and fix the Brush Tool ,and fix the Tool Tips to do not steal focus ,and the tool tips that do not dissaper from screen -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 fjfrackiewicz(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fjfrackiewicz(a)gmail.com --- Comment #10 from fjfrackiewicz(a)gmail.com --- (In reply to Chituc Georgian from comment #9)
Created attachment 55833 [details] This is a patch for wine 1.8.4 stable , and fix the Brush Tool ,and fix the Tool Tips to do not steal focus ,and the tool tips that do not dissaper from screen
I am no expert on this matter at all but based on my observations, the stable version (so the 1.8.X series) gets updated via cherry picked commits from Wine development (so the 1.9.X series). You might want to try and make the patch for the development version of Wine and see if you can submit it and get it committed where it will eventually get implemented in the stable version of Wine :) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #11 from Chituc Georgian <dianaxxyyzz(a)gmail.com> --- I just hope it to be implemented , It is so easy to implement it , cause is just few lines to add in just 3 files , so easy that it can be added manualy in a minute. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #12 from fjfrackiewicz(a)gmail.com --- (In reply to Chituc Georgian from comment #11)
I just hope it to be implemented , It is so easy to implement it , cause is just few lines to add in just 3 files , so easy that it can be added manualy in a minute.
Yeah I hear you :) I always found that it's best to go through the official channels in cases like this that way it will be a part of Wine and those with less coding knowledge (such as myself :P ) won't have to do this by hand :) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 Dmitry Timoshkov <dmitry(a)baikal.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|user32 |-unknown Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #13 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Chituc Georgian from comment #11)
I just hope it to be implemented , It is so easy to implement it , cause is just few lines to add in just 3 files , so easy that it can be added manualy in a minute.
Unfortunately, the patches you've attached are just a set of very dirty hacks, and by their nature they will never be committed to the official Wine source tree. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #14 from Chituc Georgian <dianaxxyyzz(a)gmail.com> --- Yes I know they are not extreme polished , But they works .And works very good for me .So extreme wine developers can inspire and use the ideea .And implement it how they think it is the best way. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #15 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Chituc Georgian from comment #14)
Yes I know they are not extreme polished , But they works .And works very good for me .So extreme wine developers can inspire and use the ideea .And implement it how they think it is the best way.
There is nothing to be inspired from in these hacks, or an idea to base a real solution on. I'd suggest to start with a proper problem analysis, and as a result - create a test application that reproduces the problem. Creating a test case for Wine would be much better of course, but starting with just some test app would be a good start. Once there is a simple test to play with, and there is a good understanding what exactly is going on (and what's wrong with it), only then one could start looking at a ways of a possible fix -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #16 from Chituc Georgian <dianaxxyyzz(a)gmail.com> --- Hello , I've created a lot of cases ,like photoshop , that reproduce the tool tips stealing focus and not dissapearing and for me this paches fixed it . The code is simple , and extreme wine developers can inspire and rewrite the patches how they think it is the best . The idea for tool tips ,to do not stealing focus, is that every window created that has the class TOOLTIPS_CLASS , has to have a WS_POPUP style , or it will steal focus . And also the tool tips that are created via CreateWindow ,and are managed by the window manager, and refuse to dissapear , must be hidden using the ShowWindow( hwnd, 0 ) , or they will refuse to dissapear. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #17 from Ruslan Kabatsayev <b7.10110111(a)gmail.com> --- (In reply to Chituc Georgian from comment #16)
Hello , I've created a lot of cases ,like photoshop , that reproduce the tool tips stealing focus and not dissapearing and for me this paches fixed it . Photoshop isn't neither simple nor opensource, not even freely downloadable.
The code is simple , and extreme wine developers can inspire and rewrite the patches how they think it is the best . This code just works around the real problem and most likely breaks something else you didn't even think to test.
The idea for tool tips ,to do not stealing focus, is that every window created that has the class TOOLTIPS_CLASS , has to have a WS_POPUP style , or it will steal focus . Do they have this style in Windows? If not, this is another reason why this isn't a fix, but rather a workaround.
Wine isn't a collection of workarounds, it's intended to be a clean implementation of Windows API, matching Windows behavior as close as practical. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #18 from Chituc Georgian <dianaxxyyzz(a)gmail.com> --- As I said , this is a start for extreme developers to implement a super fix :) I just post it so others to do not have problems anymore . If it will be implemented or not for me is not a problem cause I can implement it myself ,in next wine versions too , and enjoy a perfect photoshop. But I just wanted to help others too who complain about tool tips. Have a great day !I have to work now! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #19 from Ruslan Kabatsayev <b7.10110111(a)gmail.com> --- Still present in wine-2.0-235-g2dd0fb8. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #20 from Chituc Georgian <dianaxxyyzz(a)gmail.com> --- You the one who think "This code just works around the real problem and most likely breaks something else you didn't even think to test." I'm the one who use patch and enjoy :) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #21 from Ruslan Kabatsayev <b7.10110111(a)gmail.com> --- (In reply to Chituc Georgian from comment #20)
I'm the one who use patch and enjoy :)
This doesn't invalidate my comment. I also use many flawed patches for many softwares and enjoy, but these patches don't become fixes instead of hacks just because of my enjoyment. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #22 from Chituc Georgian <dianaxxyyzz(a)gmail.com> --- Wine itself is a hack , is a middle man between Linux os and windows app . It must to do all it could just to make windwos apps to work good and to feel comfortable , so users enjoy . It dnt have to rewrite windows api in a better way , it just have to do what it can so it to make windows apps to work good on linux . -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #23 from Ruslan Kabatsayev <b7.10110111(a)gmail.com> --- (In reply to Chituc Georgian from comment #22)
Wine itself is a hack , is a middle man between Linux os and windows app . If we follow you, any adaptor is a hack. POSIX subsystem in WinNT architecture is then also a hack, although it was never meant to be this.
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #24 from Chituc Georgian <dianaxxyyzz(a)gmail.com> --- We do not rewrite windows here , we do a software that is able to run windows applications .So even windows bugs must be implemented too , if that make the windows apps to work good. All I care is end users good feeling and security -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #25 from Ruslan Kabatsayev <b7.10110111(a)gmail.com> --- This also happens with Rigs of Rods (tested on version 0.38.67 with wine-2.5). See rorconfig — hovering mouse cursor over any buttons or other controls where you have tooltips steals focus from the dialog window. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #26 from Ruslan Kabatsayev <b7.10110111(a)gmail.com> --- Still present in wine-2.22-158-g47e9e91. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #27 from Ruslan Kabatsayev <b7.10110111(a)gmail.com> --- Still present in wine-3.1-286-g389c3ad. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 --- Comment #28 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- Please try again in Wine 5.6 or later. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 S. Christian Collins <s_chriscollins(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s_chriscollins(a)hotmail.com --- Comment #29 from S. Christian Collins <s_chriscollins(a)hotmail.com> --- This bug still occurs in Wine 5.6, tested using two affected free applications: OllyDbg 2.0 and Endless WAV 1.77 (https://www.bjoernbojahr.de/endlesswav.html). In the case of Endless WAV, all audio playback stops when the application loses focus. With everything in the application having a tooltip, this makes the application nearly impossible to use in Wine. However, I have found the following workarounds for the issue: Workaround #1 (best): If you use the KDE Plasma 5 desktop environment, you can set a window rule to avoid the tooltip stealing application focus: 1. Start the affected Wine application. 2. Click the app icon in the titlebar and go to More Actions -> Configure Special Application Settings..., then go to the "Appearance & Fixes" tab, tick the box for "Focus stealing prevention", and to the right of that select "Force" and "Extreme", then click OK. Workaround #2: Run winecfg, and from the "Graphics" tab, disable "Allow the window manager to control the windows". You can add the affected app via the Applications tab to prevent this setting from affecting all Windows programs run in Wine. The drawback to this approach is the lack of window management you now have. Workaround #3: Run winecfg, and from the "Graphics" tab, enable "Emulate a virtual desktop" and set the desktop size appropriately. You can add the affected app via the Applications tab to prevent this setting from affecting all Windows programs run in Wine. The drawback to this approach is that if you try to run another program simultaneously in Wine, it will also be restricted to the virtual desktop size. ** My System ** OS: KDE Neon 5.18 64-bit (Plasma Desktop 5.18.4, KDE Frameworks 5.69.0, Qt 5.14.1) Linux Kernel: 5.3.0-46-generic Motherboard: ASRock X58 Extreme3 (Intel X58 chipset) CPU: Intel Core i7-990x Bloomfield (3.46 GHz hexa-core, Socket 1366) RAM: 12GB DDR3 Video: EVGA NVIDIA GeForce GTX 980 Ti SC (GAMING ACX 2.0+?) w/ 6GB RAM (PCI Express) NVIDIA video driver: 440.82 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|http://www.ollydbg.de/ |https://web.archive.org/web | |/20140209193012/http://olly | |dbg.de/odbg201.zip CC| |focht(a)gmx.net -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39547 debilerpc(a)web.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |debilerpc(a)web.de --- Comment #30 from debilerpc(a)web.de --- Still present in wine-6.4 in Foobar2000 in KDE on Arch Linux. Thanks for the workaround. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla