[Bug 58229] New: _SH_SECURE sharing flag is not supported and causing _wfsopen to fail
http://bugs.winehq.org/show_bug.cgi?id=58229 Bug ID: 58229 Summary: _SH_SECURE sharing flag is not supported and causing _wfsopen to fail Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: msvcrt Assignee: wine-bugs(a)winehq.org Reporter: bruvzg13(a)proton.me Distribution: --- Calling _wfsopen with _SH_SECURE sharing flag result in failure and "012c:err:msvcrt:_wsopen_dispatch Unhandled shflags 0x80" error in the terminal. 0x80 value correspond to _SH_SECURE Discovered while debugging Godot Engine - https://github.com/godotengine/godot/pull/106392 Seems like the case for this flag is missing: https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/msvcrt/file.c?ref_typ... The flag is documented as "shared read, exclusive write access" (https://learn.microsoft.com/en-us/cpp/c-runtime-library/sharing-constants?vi...), and the issue can be worked around by substituting it with "(mode_flags == READ) ? _SH_DENYWR : _SH_DENYRW", which result in the same behavior as on Windows (at least in our use case). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58229 Piotr Caban <piotr.caban(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr.caban(a)gmail.com --- Comment #1 from Piotr Caban <piotr.caban(a)gmail.com> --- I've sent a patch that implements _SH_SECURE flag: https://gitlab.winehq.org/wine/wine/-/merge_requests/8413 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58229 --- Comment #2 from Piotr Caban <piotr.caban(a)gmail.com> --- It should be fixed by 972862c128906af3973cb5c6b2153f478abfb6e9. Please retest. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58229 Piotr Caban <piotr.caban(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |972862c128906af3973cb5c6b21 | |53f478abfb6e9 --- Comment #3 from Piotr Caban <piotr.caban(a)gmail.com> --- Marking as fixed since it works for me. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58229 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 10.18. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla