[Bug 11555] New: Need a real WinHttpDetectAutoProxyConfigUrl, not a stub for .NET
http://bugs.winehq.org/show_bug.cgi?id=11555 Summary: Need a real WinHttpDetectAutoProxyConfigUrl, not a stub for .NET Product: Wine Version: 0.9.54. Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: joshudson(a)gmail.com Am trying very slowly to get a particular large .NET app working under Wine. I can't test anything under .55 due to a regression that makes the .NET installer fail. A first pass indicates we need a WinHttpDetectAutoProxyConfigUrl (it dies hard otherwise). Funny, this always fail implementation is good enough, possibly because it sets an error code or nulls out its result pointer. OK, this patch creates one. --- wine-0.9.54/dlls/winhttp/main.bak 2008-02-11 20:54:48.000000000 -0800 +++ wine-0.9.54/dlls/winhttp/main.c 2008-02-11 21:00:01.000000000 -0800 @@ -129,3 +129,16 @@ SetLastError(ERROR_NOT_SUPPORTED); return NULL; } + +/********************************************************************** + * WinHttpDetectAutoProxyUrl + */ + +BOOL WINAPI WinHttpDetectAutoProxyConfigUrl(DWORD flags, LPWSTR *url) +{ + /* This can never work in this environment. + * Hope that it assumes transparent. */ + SetLastError(ERROR_NOT_SUPPORTED); + *url = NULL; + return FALSE; +} --- wine-0.9.54/dlls/winhttp/winhttp.spec 2008-02-11 20:54:39.000000000 -0800 +++ wine-0.9.54/dlls/winhttp/winhttp.spec.bak 2008-02-11 20:52:39.000000000 -0800 @@ -8,7 +8,7 @@ @ stub WinHttpConnect @ stub WinHttpCrackUrl @ stub WinHttpCreateUrl -@ stdcall WinHttpDetectAutoProxyConfigUrl(long ptr) +@ stub WinHttpDetectAutoProxyConfigUrl @ stub WinHttpGetDefaultProxyConfiguration @ stdcall WinHttpGetIEProxyConfigForCurrentUser(ptr) @ stub WinHttpGetProxyForUrl -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11555 --- Comment #1 from Maarten Lankhorst <m.b.lankhorst(a)gmail.com> 2008-02-11 23:24:04 --- If it makes the installer happy, please send it to wine-patches . http://www.winehq.org/site/forums Note that you will need to subscribe to the list to send to it. But once subscribed you can disable email delivery in options so you won't get flooded. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11555 Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xerox_xerox2000(a)yahoo.co.uk --- Comment #2 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> 2008-02-14 01:48:17 --- Hi Joshua, your patch did not apply cleanly here as well (see also http://www.winehq.org/pipermail/wine-devel/2008-February/062525.html ) Could you please send a new patch , preferably generated from git (git diff), that applies correctly against the current wine tree. Also, it might be an idea to just let the SetLastError set ERROR_WINHTTP_AUTODETECTION_FAILED ; FriendBot (another .Net app i tried is just happy with that as well, see http://msdn2.microsoft.com/en-us/library/aa384094(VS.85).aspx ) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11555 Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #3 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> 2008-02-14 01:49:42 --- Confirming, quite some .Net apps crash because of this unimplemented function. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11555 --- Comment #4 from Joshua <joshudson(a)gmail.com> 2008-02-14 21:41:42 --- Created an attachment (id=10779) --> (http://bugs.winehq.org/attachment.cgi?id=10779) winhttpproxy patch, gzipped version -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11555 --- Comment #5 from Joshua <joshudson(a)gmail.com> 2008-02-14 21:42:46 --- Created an attachment (id=10780) --> (http://bugs.winehq.org/attachment.cgi?id=10780) winhttpproxy patch, streight same patch, not gzipped (hoping it doesn't wrap this time) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11555 --- Comment #6 from Joshua <joshudson(a)gmail.com> 2008-02-14 21:43:50 --- Sorry, I cannot pull git trees. However, this version should apply. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11555 --- Comment #7 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> 2008-02-15 01:18:34 ---
Sorry, I cannot pull git trees. However, this version should apply.
Yes, please send it to wine-patches ( with something like [try 2] in the message) Regards -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11555 --- Comment #8 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> 2008-02-20 14:37:10 --- Joshua, to get the patch into the wine-tree you should also at least add a "FIXME" in the stubbed function. See other examples in the wine-tree. That's try 3 then ... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11555 Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #9 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> 2008-03-06 13:04:26 --- Joshua, a slightly different stub (patch by Hans Leidekker) just went into git, that should be enough to work around this bug. It works for other .net apps. Please reopen if you still run into trouble -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11555 --- Comment #10 from Joshua <joshudson(a)gmail.com> 2008-03-06 20:52:35 --- Great. I'll know for sure that it worked as soon as Wine 0.9.57 is released. The same reason I couldn't submit a GIT-patch is the reason I can't find out any sooner. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11555 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #11 from Alexandre Julliard <julliard(a)winehq.org> 2008-03-07 11:28:41 --- Closing bugs fixed in 0.9.57. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11555 --- Comment #12 from Joshua <joshudson(a)gmail.com> 2008-03-11 21:10:48 --- Fix confirmed in 0.9.57 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs@winehq.org