[Bug 46555] New: cygwin-x86_64.exe: AddAccessAllowedAceEx(, group) failed: 1337
https://bugs.winehq.org/show_bug.cgi?id=46555 Bug ID: 46555 Summary: cygwin-x86_64.exe: AddAccessAllowedAceEx(, group) failed: 1337 Product: Wine Version: 4.0 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: minor Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: larrowe.semaj11(a)gmail.com Distribution: --- Altogether, the Cygwin installer runs wonderfully, however I have noticed one problem. There are hundreds of lines stating this: AddAccessAllowedAceEx(, group) failed: 1337 I would assume that these are probably file permission errors, as they are shown when downloading and extracting packages. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46555 James Larrowe <larrowe.semaj11(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |advapi32 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46555 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Keywords| |download, source CC| |dark.shadow4(a)web.de URL| |https://www.cygwin.com/setu | |p-x86_64.exe Ever confirmed|0 |1 --- Comment #1 from Fabian Maurer <dark.shadow4(a)web.de> --- Still an issue as of wine-8.1 1337 = ERROR_INVALID_SID -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46555 --- Comment #2 from Fabian Maurer <dark.shadow4(a)web.de> --- Still present in wine-9.11 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46555 manschwetus(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |manschwetus(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46555 Joel Holdsworth <joel(a)airwebreathe.org.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joel(a)airwebreathe.org.uk -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=46555 Bernhard Übelacker <bernhardu@mailbox.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bernhardu@mailbox.org --- Comment #3 from Bernhard Übelacker <bernhardu@mailbox.org> --- Created attachment 80147 --> http://bugs.winehq.org/attachment.cgi?id=80147 46555_cygwin_AddAccessAllowedAceEx.txt Still present in wine-11.0-rc5. This are the steps that lead to this logging by the installer: - [1] calls SetTokenInformation with TokenOwner, which fails because in NtSetInformationToken TokenOwner is not yet implemented. There is also a line "NtSetInformationToken unimplemented class 4" written. - Because of this failure of SetTokenInformation the function setDefaultSecurity is left early and the line [2] in the installer is not reached, which assigns the global variable "groupSID", which therefore stays NULL. - This "groupSID" is used to initialize a local variable in GetPosixPerms [4], which gets used in a call to AddAccessAllowedAceEx, which fails because group_sid is NULL, which fails the RtlValidSid test returning STATUS_INVALID_SID, and therefore causes the logging. [1] https://cygwin.com/cgit/cygwin-apps/setup/tree/win32.cc#n348 [2] https://cygwin.com/cgit/cygwin-apps/setup/tree/win32.cc#n361 [3] https://cygwin.com/cgit/cygwin-apps/setup/tree/win32.cc#n70 [4] https://cygwin.com/cgit/cygwin-apps/setup/tree/win32.cc#n80 Adding another stub block for TokenOwner in NtSetInformationToken, like at the bottom of attached file, avoids the logging of AddAccessAllowedAceEx. Therefore this bug is about SetTokenInformation supporting TokenOwner. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=46555 Bernhard Übelacker <bernhardu@mailbox.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|advapi32 |ntdll Keywords| |Installer -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=46555 --- Comment #4 from Bernhard Übelacker <bernhardu@mailbox.org> --- (In reply to Bernhard Übelacker from comment #3)
like at the bottom of attached file,
Sorry, did not save before attaching the file, the modification I wanted to add is this: dlls/ntdll/unix/security.c @@ -722,4 +722,9 @@ NTSTATUS WINAPI NtSetInformationToken( HANDLE token, TOKEN_INFORMATION_CLASS cla break; + case TokenOwner: + FIXME( "TokenOwner stub!\n" ); + ret = STATUS_SUCCESS; + break; + default: FIXME( "unimplemented class %u\n", class ); -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=46555 --- Comment #5 from Joel Holdsworth <joel@airwebreathe.org.uk> --- Nice work Bernhard - yet again! Seems like this would be a straightforward change to get upstream. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=46555 --- Comment #6 from Fabian Maurer <dark.shadow4@web.de> --- Is this causing any issues or is this just logging messages? As long as it's only the log I'm not sure how likely a fix is accepted. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=46555 --- Comment #7 from Bernhard Übelacker <bernhardu@mailbox.org> --- (In reply to Fabian Maurer from comment #6)
Is this causing any issues or is this just logging messages? As long as it's only the log I'm not sure how likely a fix is accepted.
I am not aware of any other effects other than polluting the log output of the installer. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (3)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla -
WineHQ Bugzilla