[Bug 42090] New: Highway Pursuit constantly emits loud noise when sound effects enabled
https://bugs.winehq.org/show_bug.cgi?id=42090 Bug ID: 42090 Summary: Highway Pursuit constantly emits loud noise when sound effects enabled Product: Wine Version: 1.7.42 Hardware: x86 URL: http://retrospec.sgn.net/game-links.php?link=highwaypu rsuit OS: Linux Status: NEW Keywords: download, regression Severity: normal Priority: P2 Component: directx-dsound Assignee: wine-bugs(a)winehq.org Reporter: gyebro69(a)gmail.com CC: aeikum(a)codeweavers.com Regression SHA1: 2edb4bf320f5c09b658c382c8d8b9d9600d1f1e7 Distribution: --- Created attachment 56602 --> https://bugs.winehq.org/attachment.cgi?id=56602 audio debug log (pulseaudio) The game opens with an animated screen which shows some logos. Audio (music) works fine here. If you press <Esc> the game loads the menu and you should hear the loud, constantly playing noise which is originating from the cars passing by the camera. Their sounds should intensify and faint away as they come closer to the player then passing by. Instead, this loud sound is always played without changing it's volume or frequency even after starting a race. This becomes quite annoying after some time. Tested with Windows XP and Win 7 profiles. Reproduced with Alsa and Pulseaudio. Reverting the following commit on top of 2.0-rc3 fixes the problem: commit 2edb4bf320f5c09b658c382c8d8b9d9600d1f1e7 Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Tue Apr 28 10:21:04 2015 -0500 dsound: Apply rolloff factor to distance attenuation. Native dsound.dll also works around the problem. Wine 2.0-rc3 Fedora 25 Pulseaudio 9.0 / Alsa 1.1.1 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42090 --- Comment #1 from Béla Gyebrószki <gyebro69(a)gmail.com> --- Created attachment 56603 --> https://bugs.winehq.org/attachment.cgi?id=56603 audio debug log (alsa) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42090 --- Comment #2 from Andrew Eikum <aeikum(a)codeweavers.com> --- Thanks, I can reproduce this. Prior to that commit, we were treating the rolloff factor as if it were always 1. After that commit, we respect its actual value. Highway Pursuit sets the rolloff factor to 0.1, which results in the audio being 10x louder than it was before, so now you always hear it. Either we're interpreting this value incorrectly or something else is wrong with our positional volume calculation. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42090 --- Comment #3 from Andrew Eikum <aeikum(a)codeweavers.com> --- Created attachment 56621 --> https://bugs.winehq.org/attachment.cgi?id=56621 dsound: Fix rolloff factor calculation This patch should correct the rolloff factor calculation. It behaves much more like native dsound in the tests. It doesn't quite fix the game, however. The sound effects are still a little too loud, I think. The game does use the doppler effect to change pitch, and in my testing it affected the length of the played sample. Maybe that ties in here, too? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42090 --- Comment #4 from Béla Gyebrószki <gyebro69(a)gmail.com> --- (In reply to Andrew Eikum from comment #3)
Created attachment 56621 [details] dsound: Fix rolloff factor calculation
This patch should correct the rolloff factor calculation. It behaves much more like native dsound in the tests.
It doesn't quite fix the game, however. The sound effects are still a little too loud, I think. The game does use the doppler effect to change pitch, and in my testing it affected the length of the played sample. Maybe that ties in here, too?
The sound effects are still a bit louder, especially during races, but it's much more tolerable than before. I'm fine with the patch if no one else complains. Thanks for taking the time for looking into this. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42090 Andrew Eikum <aeikum(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |1671a83f55bee46ee57cc0c8869 | |e943d67f14ea5 Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #5 from Andrew Eikum <aeikum(a)codeweavers.com> --- Fixed by commit 1671a83f55bee46ee57cc0c8869e943d67f14ea5 Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Wed Dec 28 14:02:54 2016 -0600 dsound: Fix rolloff factor calculation. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42090 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 2.0-rc4. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42090 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.8.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42090 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.8.x |--- --- Comment #7 from Michael Stefaniuc <mstefani(a)redhat.com> --- Removing 1.8.x milestone from bugs included in 1.8.7. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org