Re: [Bug 590] Changed - Memory leak: When running any program under Wine, the memory usage increases in certain instances.

[Robert Yaklin]

I downloaded the Wine source from today's CVS and applied the patch and 
found the memory leak still exists in all tested programs including 
AbiWord. I then downloaded the 20020310 source code and applied the 
patch. This time I found that all the other programs no longer 
exhibited this memory leak. Great job, Andreas, and many thanks!

On 2002.05.27 13:46 wine-bugs(a)winehq.com wrote:
> http://bugs.winehq.com/show_bug.cgi?id=590
>
> *** shadow/590	Mon May 20 21:38:06 2002
> --- shadow/590.tmp.6901	Mon May 27 13:46:05 2002
> ***************
> *** 2,8 ****
>   | Memory leak: When running any program under Wine, the memory usage
> increas |
>
> +----------------------------------------------------------------------------+
>   |        Bug #: 590                         Product: Wine
>         |
> ! |       Status: ASSIGNED                    Version: 20020310
>         |
>   |   Resolution:                            Platform:
>         |
>   |     Severity: major                    OS/Version: All
>         |
>   |     Priority: P1                        Component: wine-kernel
>         |
> --- 2,8 ----
>   | Memory leak: When running any program under Wine, the memory usage
> increas |
>
> +----------------------------------------------------------------------------+
>   |        Bug #: 590                         Product: Wine
>         |
> ! |       Status: RESOLVED                    Version: 20020310
>         |
>   |   Resolution:                            Platform:
>         |
>   |     Severity: major                    OS/Version: All
>         |
>   |     Priority: P1                        Component: wine-kernel
>         |
> ***************
> *** 58,60 ****
> --- 58,71 ----
>   Another program you could try is AOL Instant Messenger. Again, try
> moving the
>   cursor quickly and continuously over the buttons, allowing time for
> the
>   tooltips to show.
> +
> + ------- Additional Comments From andi(a)rhlx01.fht-esslingen.de
> 2002-05-27 13:46 -------
> + OK, I just submitted a patch to wine-patches that fixes a major
> memleak in
> + windows/winpos.c/find_child_from_point() (several return cases
> didn't free the
> + window list).
> + This cures AbiWord eating memory when over the toolbar.
> + See http://wine.codeweavers.com/fom-meta/cache/230.html for a
> description
> + of how to debug such things.
> + Robert, could you try the various other problematic apps with this
> patch ?
> + I'm just assuming it's resolved now :-)
> + (feel free to reopen in case of remaining memleaks with the other
> apps mentioned)
> \ No newline at end of file

[Bug 590] Changed - Memory leak: When running any program under Wine, the memory usage increases in certain instances.

[Andreas Mohr]

On Tue, May 28, 2002 at 09:06:25PM -0500, Robert Yaklin wrote:
> I downloaded the Wine source from today's CVS and applied the patch and 
> found the memory leak still exists in all tested programs including 
> AbiWord. I then downloaded the 20020310 source code and applied the 
> patch. This time I found that all the other programs no longer 
> exhibited this memory leak. Great job, Andreas, and many thanks!

I said "submitted", not "committed"...
There's a huge difference... ;-)

Having said that, it *just* did go into CVS.

Glad you're happy now :-)
> On 2002.05.27 13:46 wine-bugs(a)winehq.com wrote:
> > http://bugs.winehq.com/show_bug.cgi?id=590
> >
> > *** shadow/590	Mon May 20 21:38:06 2002
> > --- shadow/590.tmp.6901	Mon May 27 13:46:05 2002
> > ***************
> > *** 2,8 ****
> >   | Memory leak: When running any program under Wine, the memory usage
> > increas |
> >
> > +----------------------------------------------------------------------------+
> >   |        Bug #: 590                         Product: Wine
> >         |
> > ! |       Status: ASSIGNED                    Version: 20020310
> >         |
> >   |   Resolution:                            Platform:
> >         |
> >   |     Severity: major                    OS/Version: All
> >         |
> >   |     Priority: P1                        Component: wine-kernel
> >         |
> > --- 2,8 ----
> >   | Memory leak: When running any program under Wine, the memory usage
> > increas |
> >
> > +----------------------------------------------------------------------------+
> >   |        Bug #: 590                         Product: Wine
> >         |
> > ! |       Status: RESOLVED                    Version: 20020310
> >         |
> >   |   Resolution:                            Platform:
> >         |
> >   |     Severity: major                    OS/Version: All
> >         |
> >   |     Priority: P1                        Component: wine-kernel
> >         |
> > ***************
> > *** 58,60 ****
> > --- 58,71 ----
> >   Another program you could try is AOL Instant Messenger. Again, try
> > moving the
> >   cursor quickly and continuously over the buttons, allowing time for
> > the
> >   tooltips to show.
> > +
> > + ------- Additional Comments From andi(a)rhlx01.fht-esslingen.de
> > 2002-05-27 13:46 -------
> > + OK, I just submitted a patch to wine-patches that fixes a major
> > memleak in
> > + windows/winpos.c/find_child_from_point() (several return cases
> > didn't free the
> > + window list).
> > + This cures AbiWord eating memory when over the toolbar.
> > + See http://wine.codeweavers.com/fom-meta/cache/230.html for a
> > description
> > + of how to debug such things.
> > + Robert, could you try the various other problematic apps with this
> > patch ?
> > + I'm just assuming it's resolved now :-)
> > + (feel free to reopen in case of remaining memleaks with the other
> > apps mentioned)
> > \ No newline at end of file

-- 
Andreas Mohr                        Stauferstr. 6, D-71272 Renningen, Germany
Tel. [phone]                http://mohr.de.tt