[Bug 47885] New: [regression] [bisected] games are now restricted to resolutions not bigger than the virtual desktop
https://bugs.winehq.org/show_bug.cgi?id=47885 Bug ID: 47885 Summary: [regression] [bisected] games are now restricted to resolutions not bigger than the virtual desktop Product: Wine Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: winex11.drv Assignee: wine-bugs(a)winehq.org Reporter: mtmkls(a)gmail.com Distribution: --- If wine is set to emulate a virtual desktop of 1024x768 for example, games cannot set any resolution higher than that. Previously they were able to set any resolution up to the real resolution of the monitor. 25167fb286822c93582457815bcf069fef040976 is the first bad commit commit 25167fb286822c93582457815bcf069fef040976 Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Wed Aug 14 16:23:55 2019 +0800 winex11.drv: Make screen helpers independent of Xinerama. So that other display device handlers such as XRandR can be introduced because they might report a virtual screen size with different top-left corner and the primary screen may be different as well. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> dlls/winex11.drv/display.c | 70 +++++++++++++++++++++++++++++++++++++++++++++ dlls/winex11.drv/xinerama.c | 33 --------------------- 2 files changed, 70 insertions(+), 33 deletions(-) Please revert to the old behavior. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47885 Vincent Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zzhang(a)codeweavers.com Regression SHA1| |25167fb286822c93582457815bc | |f069fef040976 Keywords| |regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47885 Vincent Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |huw(a)codeweavers.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47885 Vincent Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[regression] [bisected] |games are now restricted to |games are now restricted to |resolutions not bigger than |resolutions not bigger than |the virtual desktop |the virtual desktop | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47885 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Hi, https://source.winehq.org/patches/data/170936 https://source.winehq.org/patches/data/170937 https://source.winehq.org/patches/data/170938 Should fix it. Sorry for the trouble. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47885 Paul Gofman <gofmanp(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gofmanp(a)gmail.com --- Comment #2 from Paul Gofman <gofmanp(a)gmail.com> --- That looks like a fix rather than a bug to me. If I set up virtual desktop, I don't normally expect the programs inside to escape it and work with my real full screen. Or am I missing something in the problem concerned or why it is a problem? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47885 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12(a)gmail.com --- Comment #3 from Zebediah Figura <z.figura12(a)gmail.com> --- Personally I preferred the old behaviour, essentially just because it was convenient not to have to manually set the virtual desktop size. But it's a minor inconvenience at best, and I'm not sure I can think of any other benefits of the old behaviour. One question that deserves answering, though it's a bit orthogonal to this bug (and I think was always broken in some sense) is: what about a virtual desktop that's the same size as the real screen? How should this interact with window decorations? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47885 --- Comment #4 from Vincent Povirk <madewokherd(a)gmail.com> --- I don't know how it behaves now, but I had it set up to set fullscreen mode, which has the side-effect of removing decorations (but without having to set any other hints). This allows virtual desktop to be used as a work-around for windowing problems when you still want fullscreen. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47885 Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |o.dierick(a)piezo-forte.be --- Comment #5 from Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> --- Hello, It is not 'normal' behavior of desktops to prevent applications from switching to higher, available, resolutions. I just checked and Wine does change the resolution when virtual desktop is disabled and the application request a higher resolution, so the old behavior is consistent with that, and with Windows if I remember correctly. Virtual desktop is an emulation of Windows desktop (with shell features) in a window, converting resolution changes to window resizing. I don't think that the virtual desktop feature was intended to be a screen emulation or jail. If you really want that feature, it can be implemented as a separate option. I think it should not depend on virtual desktop mode anyway. When that feature is enabled, Wine should not allow the application to switch to resolutions higher than the current (real or virtual) desktop size. It should hide those resolutions from the application. What about opening an enhancement bug for that? (In reply to Vincent Povirk from comment #4)
I don't know how it behaves now, but I had it set up to set fullscreen mode, which has the side-effect of removing decorations (but without having to set any other hints). This allows virtual desktop to be used as a work-around for windowing problems when you still want fullscreen.
It still works like that. Regards. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47885 --- Comment #6 from Miklós Máté <mtmkls(a)gmail.com> --- Thanks for the quick reply, Zhiyi, the three patches solve this issue and #47815 as well. It's not entirely stable though. Sometimes the blue desktop background does appear, but the actual window of the wine desktop is borderless full screen, and the area outside the blue desktop is uninitialized. Rarely, the wine desktop can't start at all, and this appears in the terminal: 0020:err:ntdll:RtlpWaitForCriticalSection section 0x7e71ea60 "sysparams.c: monitors_section" wait timed out in thread 0020, blocked by 0029, retrying (60 sec) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47885 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |acf03ed9da0f7d3f94de9b47c44 | |366be3ee47f8e Status|NEW |RESOLVED --- Comment #7 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Fixed by -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47885 --- Comment #8 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Fixed by acf03ed9da0f7d3f94de9b47c44366be3ee47f8e -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47885 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #9 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 4.20. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla