[Bug 21592] New: ResTrax: Up-down common control doesn't process arrow keys the same as mouse clicks
http://bugs.winehq.org/show_bug.cgi?id=21592 Summary: ResTrax: Up-down common control doesn't process arrow keys the same as mouse clicks Product: Wine Version: 1.1.37 Platform: x86 URL: http://www.cockrumpublishing.com/rttrial OS/Version: Linux Status: UNCONFIRMED Severity: minor Priority: P3 Component: comctl32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: rickcockrum(a)gmail.com Using stock Wine 1.1.37 on Ubuntu 9.10. I have several dialogs in my application which create an up-down control and set it's buddy to a static control. The up-down control has an acceleration of 25, with a time interval of 0. The up-down control also has the UDS_ARROWKEYS style set.Under Windows clicking the up-down control's arrows with the mouse, or pressing both change the position of the up-down control by 25. Under Wine, using the mouse changes the position by 25. If I use the arrow keys, the position only changes by 1. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21592 --- Comment #1 from rickcockrum(a)gmail.com 2010-02-03 14:38:38 --- Using stock Wine 1.1.37 on Ubuntu 9.10. I have several dialogs which have an up-down control with a static control as a buddy. The up-down control has the UDS_ARROWKEYS style, acceleration increment set to 25, and delay time set to 0. Under Windows, using the mouse and the arrow keys both change the position of the up-down control by 25. Under Wine, using the mouse changes the position of the up-down control by 25, but using the arrow keys only changes it by 1. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21592 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21592 --- Comment #2 from Juan Lang <juan_lang(a)yahoo.com> 2010-02-03 18:49:23 --- Created an attachment (id=26047) --> (http://bugs.winehq.org/attachment.cgi?id=26047) Patch: Use acceleration amount when changing the value through arrow keys Does this patch help? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21592 --- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com> 2010-02-03 19:16:04 --- (In reply to comment #2)
Created an attachment (id=26047) --> (http://bugs.winehq.org/attachment.cgi?id=26047) [details] Patch: Use acceleration amount when changing the value through arrow keys
You don't use this amount, it's still 1. Also a tiny test is really needed here (to submit this). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21592 --- Comment #4 from rickcockrum(a)gmail.com 2010-02-03 20:33:44 --- (In reply to comment #2)
Created an attachment (id=26047) --> (http://bugs.winehq.org/attachment.cgi?id=26047) [details] Patch: Use acceleration amount when changing the value through arrow keys
Does this patch help?
I don't have the build environment to test the patch, but, as Nikolay said, if the temp variable were passed to UPDOWN_DoAction(), it probably would work since that appears to be the same thing that is done when the mouse is used. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21592 Juan Lang <juan_lang(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |juan_lang(a)yahoo.com --- Comment #5 from Juan Lang <juan_lang(a)yahoo.com> 2010-02-03 21:57:23 --- (In reply to comment #3)
You don't use this amount, it's still 1. Also a tiny test is really needed here (to submit this).
Haha, I accidentally deleted that change. Thanks! How would one test it? Or if you feel like fixing it, go right ahead :) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21592 --- Comment #6 from Nikolay Sivov <bunglehead(a)gmail.com> 2010-02-04 06:26:53 --- (In reply to comment #5)
(In reply to comment #3)
You don't use this amount, it's still 1. Also a tiny test is really needed here (to submit this).
Haha, I accidentally deleted that change. Thanks! How would one test it? Or if you feel like fixing it, go right ahead :)
Passing keydown message directly. That's a keyboard operation we want to test, so it's simple. Yeah, I could do this of course, will try today. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21592 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #7 from Nikolay Sivov <bunglehead(a)gmail.com> 2010-02-04 09:10:19 --- I can confirm this, it's easily reproducible with ControlSpy. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21592 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #8 from Nikolay Sivov <bunglehead(a)gmail.com> 2010-02-04 10:09:19 --- (In reply to comment #6)
Passing keydown message directly. That's a keyboard operation we want to test, so it's simple. Yeah, I could do this of course, will try today.
It was too fast, tried to test it and it falls to autorepeat, so results aren't stable. I sent a patch anyway, cause this fix looks trivial: http://www.winehq.org/pipermail/wine-patches/2010-February/084568.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21592 Juan Lang <juan_lang(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC|juan_lang(a)yahoo.com | Resolution| |FIXED --- Comment #9 from Juan Lang <juan_lang(a)yahoo.com> 2010-02-04 11:31:56 --- Fixed by commit 8c16c4030b3757a1bd237abce653f92685d3970c. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21592 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #10 from Alexandre Julliard <julliard(a)winehq.org> 2010-02-05 11:39:25 --- Closing bugs fixed in 1.1.38. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21592 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |8c16c4030b3757a1bd237abce65 | |3f92685d3970c -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org