[Bug 41683] New: Gauntlet start background is corrupted.
https://bugs.winehq.org/show_bug.cgi?id=41683 Bug ID: 41683 Summary: Gauntlet start background is corrupted. Product: Wine Version: 1.9.20 Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: directx-d3d Assignee: wine-bugs(a)winehq.org Reporter: leslie_alistair(a)hotmail.com Distribution: --- The Steam version of Gauntlet, has it starting backing background corrupted (the one with the menu). Regression found that this was the cause. commit 60833cb39aba6b7354d7c0de263be017bca24a1b Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Sep 20 11:41:36 2016 +0200 wined3d: Use wine_rb_remove() in delete_glsl_program_entry(). Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> :040000 040000 f660883975a862931272ee1f2d43b1b55d5552f7 2ac54a7cb0036c07e6bffb1a3539f23db0dc7f6d M dlls -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41683 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |60833cb39aba6b7354d7c0de263 | |be017bca24a1b Keywords| |regression CC| |hverbeet(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41683 winetest(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest(a)luukku.com --- Comment #1 from winetest(a)luukku.com --- Is this same bug as bug 41133? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41683 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41133 --- Comment #2 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- (In reply to winetest from comment #1)
Is this same bug as bug 41133?
No. This issue is about the background not showing up or being corrupted in various ways. 41133 has the background image but has missing pixel throughout it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41683 Józef Kucia <joseph.kucia(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joseph.kucia(a)gmail.com --- Comment #3 from Józef Kucia <joseph.kucia(a)gmail.com> --- (In reply to Alistair Leslie-Hughes from comment #0)
The Steam version of Gauntlet, has it starting backing background corrupted (the one with the menu).
Regression found that this was the cause.
commit 60833cb39aba6b7354d7c0de263be017bca24a1b Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Sep 20 11:41:36 2016 +0200
Thanks for running a regression test, but the result seems wrong. I think that this regression was caused by the following commit: commit e58689a3981fae5b312b12e9f6801adf289d04c0 Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Sep 20 11:41:37 2016 +0200 wined3d: Implement the initial texture data upload on top of wined3d_device_update_sub_resource(). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41683 Józef Kucia <joseph.kucia(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1|60833cb39aba6b7354d7c0de263 |e58689a3981fae5b312b12e9f68 |be017bca24a1b |01adf289d04c0 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41683 --- Comment #4 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- (In reply to Józef Kucia from comment #3)
wined3d: Implement the initial texture data upload on top of wined3d_device_update_sub_resource().
Yes, your right. After reverting that patch, the background appears once again. Thanks. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41683 --- Comment #5 from Józef Kucia <joseph.kucia(a)gmail.com> --- Created attachment 56077 --> https://bugs.winehq.org/attachment.cgi?id=56077 Patch This patch implement wined3d_device_update_sub_resource() for 3D textures. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41683 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #6 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- (In reply to Józef Kucia from comment #5)
Created attachment 56077 [details] Patch
This patch implement wined3d_device_update_sub_resource() for 3D textures.
Confirming that the patch allows the background to be seen again. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41683 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |685246b4a17732cb2f7f3f483e3 | |bd5a4f61c8f41 --- Comment #7 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Thanks Józef Branch: master Commit: 685246b4a17732cb2f7f3f483e3bd5a4f61c8f41 URL: http://source.winehq.org/git/wine.git/?a=commit;h=685246b4a17732cb2f7f3f483e... Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Mon Nov 14 17:31:18 2016 +0100 wined3d: Implement wined3d_update_sub_resource() for 3D textures. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=41683 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #8 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.9.24. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org