[Bug 32182] New: GetResolvedNeutrals always returns input

http://bugs.winehq.org/show_bug.cgi?id=32182

             Bug #: 32182
           Summary: GetResolvedNeutrals always returns input
           Product: Wine
           Version: 1.5.17
          Platform: x86-64
               URL: http://source.winehq.org/git/wine.git/blob/1262f07609e
                    6722a841f511445f145d941848800:/dlls/usp10/bidi.c#l562
        OS/Version: Linux
            Status: NEW
          Keywords: source
          Severity: normal
          Priority: P2
         Component: usp10
        AssignedTo: wine-bugs(a)winehq.org
        ReportedBy: nerv(a)dawncrow.de
                CC: aric(a)codeweavers.com, m.b.lankhorst(a)gmail.com
    Classification: Unclassified


coverity (CID 731561) spotted:
http://source.winehq.org/git/wine.git/blob/1262f07609e6722a841f511445f145d94...

action is masked to 0x0f and compared to (1<<8), that won't ever happen.

The code comes from:

commit 032543e54dec387ae0089fe9e5dd0cc0fbc2d253
Author: Maarten Lankhorst <m.b.lankhorst(a)gmail.com>
Date:   Sat Sep 15 15:16:38 2007 +0200

    gdi: Implement neutrals resolving in BiDi.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 32182] GetResolvedNeutrals always returns input

http://bugs.winehq.org/show_bug.cgi?id=32182

--- Comment #1 from André H. <nerv(a)dawncrow.de> 2013-06-30 07:56:17 CDT ---
Still in 1.6-rc4

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 32182] GetResolvedNeutrals always returns input

http://bugs.winehq.org/show_bug.cgi?id=32182

--- Comment #2 from Nikolay Sivov <bunglehead(a)gmail.com> ---
Looks like this code is gone thanks to
http://source.winehq.org/git/wine.git/commit/de5dc96f85449ed3a9d58957e9401ea....
I think it could be closed.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 32182] GetResolvedNeutrals always returns input

http://bugs.winehq.org/show_bug.cgi?id=32182

André H. <nerv(a)dawncrow.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |de5dc96f85449ed3a9d58957e94
                   |                            |01ea37bbf7613
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from André H. <nerv(a)dawncrow.de> ---
marking fixed

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 32182] GetResolvedNeutrals always returns input

https://bugs.winehq.org/show_bug.cgi?id=32182

Alexandre Julliard <julliard(a)winehq.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard <julliard(a)winehq.org> ---
Closing bugs fixed in 1.7.11.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.