[Bug 51219] New: Deferring EC_COMPLETE introduced two new quartz:filtergraph failures
https://bugs.winehq.org/show_bug.cgi?id=51219 Bug ID: 51219 Summary: Deferring EC_COMPLETE introduced two new quartz:filtergraph failures Product: Wine Version: 6.8 Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: quartz Assignee: wine-bugs(a)winehq.org Reporter: fgouget(a)codeweavers.com Distribution: --- Deferring EC_COMPLETE in strmbase introduced two new quartz:filtergraph failures: https://test.winehq.org/data/patterns.html#quartz:filtergraph filtergraph.c:515: Test failed: didn't get EOS filtergraph.c:519: Test failed: expected 1243c8, got 0 The commit that introduced this change is: commit 82b86d470488ae266d3ccd46ae4a6750ff3e79eb Author: Anton Baskanov <baskanov(a)gmail.com> AuthorDate: Wed May 26 23:46:43 2021 +0700 strmbase: Defer EC_COMPLETE until the renderer is running. Signed-off-by: Anton Baskanov <baskanov(a)gmail.com> Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> Note: * On cw-gtx560 and cw-rx460 only the 64-bit tests are impacted. This is because these machines are missing the gstreamer1.0-plugins-bad:i386 due an incompatibility with the :amd64 package in Debian 10. In turn this causes a skip (L"test.mpg": codec not supported) which avoids the failure. * The TestBot's debiant2 VM is on Debian Testing where it was possible to install both the 32- and 64-bit versions of tgstreamer1.0-plugins-bad so that both 32- and 64-bit versions of Wine are failing. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51219 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source, testcase Regression SHA1| |82b86d470488ae266d3ccd46ae4 | |a6750ff3e79eb -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51219 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baskanov(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51219 Zeb Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12(a)gmail.com --- Comment #1 from Zeb Figura <z.figura12(a)gmail.com> --- This is broadly "DirectShow threading is broken". I plan to take a look at this again when I have time, now that wineqtdecoder is gone. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51219 --- Comment #2 from Zeb Figura <z.figura12(a)gmail.com> --- Same bug as bug 51153, actually, I believe. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51219 --- Comment #3 from François Gouget <fgouget(a)codeweavers.com> --- These have been marked as flaky so they don't show up as failing anymore but the underlying issue is still present. Bug 51153 stopped happening a long time ago so it must have been a separate issue. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51219 --- Comment #4 from Zeb Figura <z.figura12(a)gmail.com> --- (In reply to François Gouget from comment #3)
These have been marked as flaky so they don't show up as failing anymore but the underlying issue is still present. Bug 51153 stopped happening a long time ago so it must have been a separate issue.
It's possible that something changed that prevented 51153 specifically from happening; I don't remember what the exact analysis of these bugs were. But they should have the same underlying cause, and that cause still hasn't been addressed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51219 --- Comment #5 from Anton Baskanov <baskanov(a)gmail.com> --- The failing test case ("test.mpg") is a bit unusual as EOS happens before the first frame. IIRC the issue is that the streaming thread gets stuck trying to enter the filter CS while sending EOS. It happens because async_run_cb() calls filter_GetState() in a loop which reenters the filter CS immediately after it was released. It is somewhat similar to bug 53403. The function that locks the filter CS on the streaming thread is pin_ConnectedTo(): sink_EndOfStream() -> sink_eos() -> strmbase_passthrough_eos() -> MediaSeekingPassThru_GetStopPosition() -> get_connected() -> pin_ConnectedTo(). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla