[Bug 42307] New: [download] knownfolder_GetRedirectionCapabilities needs to be implemented for Temple+
https://bugs.winehq.org/show_bug.cgi?id=42307 Bug ID: 42307 Summary: [download] knownfolder_GetRedirectionCapabilities needs to be implemented for Temple+ Product: Wine Version: 2.0 Hardware: x86 URL: https://github.com/GrognardsFromHell/TemplePlus/releas es OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: shell32 Assignee: wine-bugs(a)winehq.org Reporter: farmboy0+winehq(a)googlemail.com Distribution: --- The config application for the Temple+ mod uses a library that calls knownfolder_GetRedirectionCapabilities. It crashes on startup because the method currently returns E_NOTIMPL; To implement this correctly wine needs its known folder definition expanded by the redirection capabilities as this is currently completely missing. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42307 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download Summary|[download] |Temple+: needs |knownfolder_GetRedirectionC |knownfolder_GetRedirectionC |apabilities needs to be |apabilities |implemented for Temple+ | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42307 winetest(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest(a)luukku.com --- Comment #1 from winetest(a)luukku.com --- I looked into msdn documention about this feature and it doesn't look really complicated at all. It seems to only check some hard coded values and returns certain value. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42307 Lucian Poston <lucianposton(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucianposton(a)gmail.com --- Comment #2 from Lucian Poston <lucianposton(a)gmail.com> --- Created attachment 59728 --> https://bugs.winehq.org/attachment.cgi?id=59728 Stubs GetRedirectionCapabilities to not return a failure HRESULT Attached patch to fix this specific issue -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42307 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4(a)web.de --- Comment #3 from Fabian Maurer <dark.shadow4(a)web.de> --- Your patch introduces a test failure:
shellpath.c:2125: Test failed: invalid redirection capabilities returned: 0
If it worked with "redirectionCapabilities==0" on windows, it can't work if you change that. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42307 --- Comment #4 from Lucian Poston <lucianposton(a)gmail.com> --- A stub for GetRedirectionCapabilities was added in wine 2.22, https://source.winehq.org/git/wine.git/commit/349064216a606c9c16be05da71ab59... , resolving this specific issue. Remaining Temple+ bugs are listed in https://bugs.winehq.org/show_bug.cgi?id=44052 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42307 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Fixed by SHA1| |349064216a606c9c16be05da71a | |b5923a63d7c79 Resolution|--- |FIXED --- Comment #5 from Fabian Maurer <dark.shadow4(a)web.de> --- Marking fixed. If this change should not be enough, please reopen. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42307 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 3.0-rc1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42307 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |2.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42307 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|2.0.x |--- --- Comment #7 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 2.0.x milestone from bugs included in 2.0.5. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs@winehq.org