[Bug 57734] New: PHP8 Fatal Errrors
https://bugs.winehq.org/show_bug.cgi?id=57734 Bug ID: 57734 Summary: PHP8 Fatal Errrors Product: WineHQ Apps Database Version: unspecified Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: appdb-unknown Assignee: wine-bugs(a)winehq.org Reporter: jnewman(a)codeweavers.com Distribution: --- While scanning the logs, I see these fatal errors due to the upgrade of PHP8. PHP Fatal error: Uncaught Error: Non-static method testData::objectGetFilterInfo() cannot be called statically in include/testData_queue.php:161 PHP Fatal error: Uncaught Error: Undefined constant "iTestingId" in include/testData.php:972 PHP Fatal error: Uncaught TypeError: sizeof(): Argument #1 ($value) must be of type Countable|array, null given in include/vendor.php:306 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 Jeremy Newman <jnewman(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs(a)winehq.org |accounts.winehq.org(a)vv221.f | |r Status|NEW |ASSIGNED --- Comment #1 from Jeremy Newman <jnewman(a)codeweavers.com> --- Antoine can you take a look into these? Thanks. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |57151 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #2 from vv221 <accounts.winehq.org(a)vv221.fr> --- Sorry for the confusion, the update I submitted was only fixing parts of the PHP 8 compatibility, not all of it. So by itself it was not enough for a full switch to PHP 8. I should have a bit of free time in a couple days, I can use that to focus on fixing the remaining compatibility problems and ensure we can fully switch to PHP 8. Starting with the errors you reported here. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 tin.strunjak(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tin.strunjak(a)gmail.com --- Comment #3 from tin.strunjak(a)gmail.com --- It could be that I've opened a bug issue that is related to this one. This is the bug I've submitted https://bugs.winehq.org/show_bug.cgi?id=57741 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 Chiitoo <chiitoo(a)gentoo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chiitoo(a)gentoo.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 schroedingerscat(a)disroot.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |schroedingerscat(a)disroot.or | |g -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #4 from schroedingerscat(a)disroot.org --- Created attachment 77957 --> https://bugs.winehq.org/attachment.cgi?id=77957 Adding test data to Wine AppDB fails -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #5 from schroedingerscat(a)disroot.org --- Created attachment 77958 --> https://bugs.winehq.org/attachment.cgi?id=77958 Changing test data on Wine AppDB fails -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #6 from schroedingerscat(a)disroot.org --- I'm also unable to add or change test data on Wine AppDB due to this. Attached some logs from when trying to do that. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #7 from vv221 <accounts.winehq.org(a)vv221.fr> --- Thanks for the reports, please keep them coming if you find other errors. I should be able to work on these as soon as tomorrow, and am going to submit the fixes as merge requests on the WineHQ GitLab instance. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #8 from vv221 <accounts.winehq.org(a)vv221.fr> --- Fix for most of the reported errors are proposed here: https://gitlab.winehq.org/winehq/appdb/-/merge_requests/4 About the error reported by tin.strunjak(a)gmail.com (related to a missing curl_init() function), this could probably be fixed by installing the php-curl package on the server. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #9 from vv221 <accounts.winehq.org(a)vv221.fr> --- There might still be other errors that have been masked by the ones I just fixed, so I suggest keeping this bug report open for a little while so we have a centralized place for reporting problems related to this migration to PHP8. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #10 from Jeremy Newman <jnewman(a)codeweavers.com> --- https://gitlab.winehq.org/winehq/appdb/-/merge_requests/4 has been merged. php-curl was not installed on the VM, so I installed that. That will fix any related errors. I'll will continue check the logs daily for for the next few weeks, and report any PHP errors that crop up. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #11 from tin.strunjak(a)gmail.com --- Created attachment 77966 --> https://bugs.winehq.org/attachment.cgi?id=77966 Error while sending e-mail It looks like installing php-curl resolved captcha issue. However, there is another issue. When I click on register I get error message: 'Error while sending e-mail' After that I've tried to create same account with the same e-mail and I get the information that the account already exists with that e-mail. No activation mail was received. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #12 from Jeremy Newman <jnewman(a)codeweavers.com> --- More errors from the logs: PHP Fatal error: Uncaught Error: Non-static method Bug::listSubmittedBy() cannot be called statically in queueditems.php:50 PHP Fatal error: Uncaught Error: Undefined constant "shWorkarounds" in include/testData.php:1085 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #13 from Jeremy Newman <jnewman(a)codeweavers.com> --- (In reply to tin.strunjak from comment #11)
Created attachment 77966 [details] Error while sending e-mail
It looks like installing php-curl resolved captcha issue. However, there is another issue. When I click on register I get error message: 'Error while sending e-mail'
After that I've tried to create same account with the same e-mail and I get the information that the account already exists with that e-mail. No activation mail was received.
I've fixed the email sending issue. I removed your account so you can recreate it and get the email. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 Michael O'Brien <mobrien_spam(a)comcast.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mobrien_spam(a)comcast.net --- Comment #14 from Michael O'Brien <mobrien_spam(a)comcast.net> --- error when attempting to view my queued submission in the applications database at https://appdb.winehq.org/queueditems.php error details: Error Message: Uncaught Error: Non-static method Bug::listSubmittedBy() cannot be called statically in /home/winehq/opt/appdb/queueditems.php:50 Stack trace: #0 {main} thrown File: queueditems.php:50 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #15 from vv221 <accounts.winehq.org(a)vv221.fr> --- Fixes for errors reported on 2025-01-30 and 2025-01-31 are available here: https://gitlab.winehq.org/winehq/appdb/-/merge_requests/5 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #16 from Jeremy Newman <jnewman(a)codeweavers.com> --- (In reply to vv221 from comment #15)
Fixes for errors reported on 2025-01-30 and 2025-01-31 are available here: https://gitlab.winehq.org/winehq/appdb/-/merge_requests/5
Merged. Thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #17 from Michael O'Brien <mobrien_spam(a)comcast.net> --- (In reply to vv221 from comment #15)
Fixes for errors reported on 2025-01-30 and 2025-01-31 are available here: https://gitlab.winehq.org/winehq/appdb/-/merge_requests/5
This has indeed fixed the error that I reported (2025-01-31) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 F H <francisco278herrera(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francisco278herrera(a)gmail.c | |om --- Comment #18 from F H <francisco278herrera(a)gmail.com> --- there is still an error when submitting an app with a new developer Ooops! Something has gone terribly wrong! Our monkey train has derailed! Worry not, a webmaster gopher help army has been dispatched and is on the way. If this error continues to be a problem, please report it to us on our Forums error details: Error Message: Uncaught Error: Call to undefined method Vendor::vendor() in /home/winehq/opt/appdb/include/vendor.php:77 Stack trace: #0 /home/winehq/opt/appdb/include/application_queue.php(58): Vendor->create() #1 /home/winehq/opt/appdb/include/objectManager.php(1445): application_queue->create() #2 /home/winehq/opt/appdb/objectManager.php(81): ObjectManager->processForm() #3 {main} thrown File: vendor.php:77 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #19 from vv221 <accounts.winehq.org(a)vv221.fr> --- The 2025-02-03 error should be fixed with https://gitlab.winehq.org/winehq/appdb/-/merge_requests/6 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #20 from Jeremy Newman <jnewman(a)codeweavers.com> --- (In reply to vv221 from comment #19)
The 2025-02-03 error should be fixed with https://gitlab.winehq.org/winehq/appdb/-/merge_requests/6
This is merged. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #21 from Jeremy Newman <jnewman(a)codeweavers.com> --- Today's list: PHP Fatal error: Uncaught Error: Non-static method maintainer::appHasMaintainer() cannot be called statically in include/application.php:254 PHP Fatal error: Uncaught Error: Object of class GdImage could not be converted to string in image.php:267 PHP Fatal error: Uncaught Error: Non-static method downloadurl::ProcessForm() cannot be called statically in admin/editAppVersion.php:19 PHP Fatal error: Uncaught Error: Non-static method Url::outputEditor() cannot be called statically in admin/editAppVersion.php:48 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #22 from vv221 <accounts.winehq.org(a)vv221.fr> --- Fixes for the 2025-02-03 errors are proposed at https://gitlab.winehq.org/winehq/appdb/-/merge_requests/7 Beware that part of this update is not real fixes, but disabling of broken debug logs. If these logs are really critical, we can discuss in the merge request comments to find a way to fix them for good. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 Jeremy Newman <jnewman(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Starfoxfs(a)gmx.net --- Comment #23 from Jeremy Newman <jnewman(a)codeweavers.com> --- *** Bug 57767 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #24 from Jeremy Newman <jnewman(a)codeweavers.com> --- More errors: PHP Fatal error: Uncaught Error: Call to undefined method Comment::comment() in include/comment.php:79 PHP Fatal error: Uncaught Error: Non-static method vote::getVotesForVersion() cannot be called statically in include/version.php:1904 PHP Fatal error: Uncaught Error: Non-static method maintainer::versionHasMaintainer() cannot be called statically in include/version.php:1544 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #25 from Rosanne DiMesio <dimesio(a)earthlink.net> --- A user reported this one on the forum: Error Message: Uncaught Error: Call to undefined method screenshot::screenshot() in /home/winehq/opt/appdb/include/screenshot.php:119 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 Tom Maneiro <tomman(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomman(a)gmail.com --- Comment #26 from Tom Maneiro <tomman(a)gmail.com> --- Is applying for application super maintainer broken/bugged now? My memory is fuzzy, but if I recall well, you should get a confirmation message on screen when you apply, but this time I didn't got anything (not even a PHP error). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #27 from vv221 <accounts.winehq.org(a)vv221.fr> ---
Is applying for application super maintainer broken/bugged now?
I am going to submit a new batch of fixes later today. When we get a confirmation by Jeremy that they have been included, please give it another try to check if it is still broken. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #28 from vv221 <accounts.winehq.org(a)vv221.fr> --- The following update includes fixes for bugs reported on 2025-02-06 and 2025-02-08: https://gitlab.winehq.org/winehq/appdb/-/merge_requests/8 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #29 from Chiitoo <chiitoo(a)gentoo.org> --- Noticed an error perhaps related to this upgrade as well, when loading up 'Edit version' or 'Edit Application'. The pages load up, at least partially, and the error message is shown in the bottom area. ---- Error Message: Uncaught Error: Non-static method Url::canEdit() cannot be called statically in /home/winehq/opt/appdb/include/url.php:275 Stack trace: #0 /home/winehq/opt/appdb/admin/editAppVersion.php(48): Url::outputEditor() #1 {main} thrown File: url.php:275 ---- Error Message: Uncaught Error: Non-static method Url::canEdit() cannot be called statically in /home/winehq/opt/appdb/include/url.php:276 Stack trace: #0 /home/winehq/opt/appdb/admin/editAppFamily.php(57): Url::outputEditor() #1 {main} thrown File: url.php:276 ---- Thank you! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 --- Comment #30 from vv221 <accounts.winehq.org(a)vv221.fr> --- Thanks for the report Chiito, this is indeed most probably related to the PHP 8 migration. I proposed a fix here: https://gitlab.winehq.org/winehq/appdb/-/merge_requests/9 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57734 Jeremy Newman <jnewman(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED --- Comment #31 from Jeremy Newman <jnewman(a)codeweavers.com> --- MR!9 was merged. Scanning the logs for the last week and didn't really see any other PHP8 related errors so I'm closing this out. New errors should be filed as new bugs. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57734 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #32 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- Closing -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla