[Bug 35353] New: mono/eglib/src/gutf8.c: many bad if expressions ?
http://bugs.winehq.org/show_bug.cgi?id=35353 Bug ID: 35353 Summary: mono/eglib/src/gutf8.c: many bad if expressions ? Product: Wine Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: programs Assignee: wine-bugs(a)winehq.org Reporter: dcb314(a)hotmail.com Classification: Unclassified I just ran the static analyser "cppcheck" over the source code of wine-mono-4.5.2. It said many things including 1. mono/eglib/src/gutf8.c:294]: (style) Expression '(X & 0xc0) != 0xb0' is always true. Source code is if ((*p & 0xc0) != 0xb0) Suggest code rework. 2. [../../../mono/eglib/src/gutf8.c:306]: (style) Expression '(X & 0xc0) == 0xb0' is always false. [../../../mono/eglib/src/gutf8.c:331]: (style) Expression '(X & 0xc0) == 0xb0' is always false. [../../../mono/eglib/src/gutf8.c:294]: (style) Expression '(X & 0xc0) != 0xb0' is always true. [../../../mono/eglib/src/gutf8.c:306]: (style) Expression '(X & 0xc0) == 0xb0' is always false. [../../../mono/eglib/src/gutf8.c:331]: (style) Expression '(X & 0xc0) == 0xb0' is always false. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35353 --- Comment #1 from Vincent Povirk <madewokherd(a)gmail.com> --- Upstream bug if anything. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=35353 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |UPSTREAM --- Comment #2 from Austin English <austinenglish(a)gmail.com> --- (In reply to Vincent Povirk from comment #1)
Upstream bug if anything.
UPSTREAM. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=35353 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|programs |-unknown -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=35353 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #3 from Austin English <austinenglish(a)gmail.com> --- Closing. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=35353 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |RESOLVED --- Comment #4 from Austin English <austinenglish(a)gmail.com> --- This was inadvertently caught up in my unclosed bugs filter. NOTOURBUG should only be closed when fixed upstream. Setting back to RESOLVED NOTOURBUG. Sorry for the spam. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org