[Bug 48157] New: SetThreatDescrption() return value E_NOTIMPL crashes StarCitizen
https://bugs.winehq.org/show_bug.cgi?id=48157 Bug ID: 48157 Summary: SetThreatDescrption() return value E_NOTIMPL crashes StarCitizen Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: kernelbase Assignee: wine-bugs(a)winehq.org Reporter: rawfox(a)freenet.de Distribution: --- Since this commit, StarCitizen does not work with wine: https://github.com/wine-mirror/wine/commit/b4684bc561257de99ce2b3bef29cc9b62... The function SetThreadDesciption() is returning E_NOTIMPL and StarCitizen can not eat that and crashes. Changing the return value to S_OK made the game work fine again. Ive patched dlls/kernelbase/thread.c with this patch https://pastebin.com/GBnQrq3T and tested the game for the last days without issues. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48157 rawfox <rawfox(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SetThreatDescrption() |SetThreatDescription() |return value E_NOTIMPL |return value E_NOTIMPL |crashes StarCitizen |crashes StarCitizen -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48157 rawfox <rawfox(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SetThreatDescription() |SetThreadDescription() |return value E_NOTIMPL |return value E_NOTIMPL |crashes StarCitizen |crashes StarCitizen -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48157 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs(a)winehq.org |bunglehead(a)gmail.com --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> --- I'll take a look at implementing this properly. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48157 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |4.20 Component|kernelbase |kernel32 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48157 --- Comment #2 from Nikolay Sivov <bunglehead(a)gmail.com> --- I sent some patches: https://www.winehq.org/pipermail/wine-devel/2019-November/155366.html https://www.winehq.org/pipermail/wine-devel/2019-November/155367.html https://www.winehq.org/pipermail/wine-devel/2019-November/155368.html -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48157 --- Comment #3 from rawfox <rawfox(a)freenet.de> --- The patches do work fine here, thank you !! Patches applied to a vanilla wine and the game is working well. There is some conflicts with some of the staging patches related to threads, so we cant apply a full staging set yet, but they will know :) Good job, thanks again^^ -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48157 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Assignee|bunglehead(a)gmail.com |wine-bugs(a)winehq.org Fixed by SHA1| |b934f6626ed7cb8a6cc18b26155 | |0d363a0068141 Resolution|--- |FIXED --- Comment #4 from Nikolay Sivov <bunglehead(a)gmail.com> --- This is fixed now: b934f6626ed7cb8a6cc18b261550d363a0068141 179cd78f828c67a113e5f0ad85952cfb99c0a281 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48157 --- Comment #5 from rawfox <rawfox(a)freenet.de> --- Yeah, its fixed :D Incredible fast, we are all pretty impressed. Thanks a lot for your actions! StarCitizen will work on wine-4.21 and thats great! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48157 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 4.21. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla