[Bug 58602] New: Screen Issue in Colin McRae Rally 2
http://bugs.winehq.org/show_bug.cgi?id=58602 Bug ID: 58602 Summary: Screen Issue in Colin McRae Rally 2 Product: Wine Version: 10.13 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: winex11.drv Assignee: wine-bugs(a)winehq.org Reporter: marcinzw(a)gmail.com Regression SHA1: ae487930f8d3811a7434dc2cbb561982c894f5ba Distribution: --- The screen issue in Colin McRae Rally 2, originally reported in Bug #58488, is still happening in Wine 10.13. After the intro video plays, the screen just stays frozen when running the game in “Emulate a virtual desktop” mode – you can still hear the sound, but nothing shows up. The patch I posted in Bug #58488 still fixes it, though. --- a/dlls/winex11.drv/opengl.c +++ b/dlls/winex11.drv/opengl.c @@ -1462,7 +1462,7 @@ static BOOL x11drv_surface_swap( struct opengl_drawable *base ) if (pglXWaitForSbcOML) pglXWaitForSbcOML( gdi_display, gl->drawable, target_sbc, &ust, &msc, &sbc ); } - if (InterlockedCompareExchange( &base->client->offscreen, 0, 0 )) + //if (InterlockedCompareExchange( &base->client->offscreen, 0, 0 )) { if (!pglXWaitForSbcOML) XFlush( gdi_display ); client_surface_present( base->client, gl->hdc ); -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58602 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58602 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rbernon(a)codeweavers.com --- Comment #1 from Ken Sharp <imwellcushtymelike(a)gmail.com> ---
The patch I posted in Bug #58488 Can you check that bug number?
ae487930f8d3811a7434dc2cbb561982c894f5ba winex11: Create client surfaces for opengl drawables.
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58602 --- Comment #2 from MarcinZw <marcinzw(a)gmail.com> ---
The patch I posted in Bug #58488 Can you check that bug number?
Yes, I've checked Bug #58488. The same patch I submitted there as well.
ae487930f8d3811a7434dc2cbb561982c894f5ba winex11: Create client surfaces for opengl drawables.
Commit ae48793.. caused the issue. It included a bunch of refactoring and some extra checks. Looks like removing the condition check in "x11drv_surface_swap" (which wasn't there before) fixes it, and the game is working fine now. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58602 Anton Baskanov <baskanov(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baskanov(a)gmail.com --- Comment #3 from Anton Baskanov <baskanov(a)gmail.com> --- This bug also affects Cobra 11: Nitro Demo: https://fileplanet.download.it/p-30157/Alarm-for-Cobra-11-Nitro-Demo AFAIR the issue is caused by the game using DirectDraw and D3D9 in the same window. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58602 --- Comment #4 from Rémi Bernon <rbernon(a)codeweavers.com> --- Would you mind checking again with 10.15 if this is still happening? I've found and hopefully fixed various issues with GL drawables. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58602 --- Comment #5 from Anton Baskanov <baskanov(a)gmail.com> --- The issue is still present in Wine 10.15. Tested Colin McRae Rally 2.0 and Cobra 11: Nitro Demo. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58602 --- Comment #6 from MarcinZw <marcinzw(a)gmail.com> --- I can confirm the issue is still present for me as well with Wine 10.15. Tested with Colin McRae Rally 2.0 — same behavior as described: after the intro plays, the screen stays frozen in virtual desktop mode while audio continues. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58602 --- Comment #7 from Rémi Bernon <rbernon(a)codeweavers.com> --- I believe https://gitlab.winehq.org/wine/wine/-/merge_requests/8975 should fix this. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58602 --- Comment #8 from Anton Baskanov <baskanov(a)gmail.com> --- (In reply to Rémi Bernon from comment #7)
I believe https://gitlab.winehq.org/wine/wine/-/merge_requests/8975 should fix this.
I tested the patch and can confirm that it fixes the issue in both games. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58602 Rémi Bernon <rbernon(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |36f4400badc14014921d238d3a0 | |2f386c47277fa --- Comment #9 from Rémi Bernon <rbernon(a)codeweavers.com> --- Should be fixed with 36f4400badc14014921d238d3a02f386c47277fa then, thanks for the report. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58602 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #10 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 10.16. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla