[Bug 46485] New: clrmamepro: crash when loading datfiles which contains release elements
https://bugs.winehq.org/show_bug.cgi?id=46485 Bug ID: 46485 Summary: clrmamepro: crash when loading datfiles which contains release elements Product: Wine Version: 4.0-rc7 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs(a)winehq.org Reporter: tomgpdev(a)gmail.com Distribution: --- Created attachment 63322 --> https://bugs.winehq.org/attachment.cgi?id=63322 Crafted .dat file and the crash backtrace The app crashes when trying to load LogiqX .DAT files which has "release" elements inside the "game" elements. From the stack trace, it see something about comctl32, but I don't know the reason about the crash itself. For you to trigger the crash, I crafted an example .dat file. Here's the procedure: 1. Download clrmame pro. 2. Copy the crash.dat file inside its datfiles dir. 3. Run clrmame pro. 4. Click OK in the welcome screen. 5. In [NEW DATAFILES], double click on "Crash test". 6. Click on "Default". 7. The crash should happen. I checked on Windows 10 that it loads the crafted crash.dat file attached to this bug report without crashing. AppDB link: https://appdb.winehq.org/objectManager.php?sClass=application&iId=5692 Program version: 4.035 64 bits -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46485 tomgpdev(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|clrmamepro: crash when |clrmamepro: crash when |loading datfiles which |loading datfiles which |contains release elements |contain release elements -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46485 tomgpdev(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|clrmamepro: crash when |clrmamepro: crash when |loading datfiles which |loading datfiles which |contain release elements |contain a "release" element | |inside "game" elements -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46485 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Assignee|wine-bugs(a)winehq.org |bunglehead(a)gmail.com --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> --- Hi, Tom. I can reproduce. The crash is in Progress Bar control code, PBM_STEPIT handler. It happens that MinVal == MaxVal == 0 at that point, and that indeed leads to division by 0. Your backtrace is showing wrong location for some reason, I get this: Backtrace: =>0 0x00007f6e90d9bfdb ProgressWindowProc+0x52b(hwnd=0x700cc, message=0x405, wParam=0, lParam=0) [/ssd/data/wine/build/wine64/dlls/comctl32/../../../../wine-git/dlls/comctl32/progress.c:662] in comctl32 (0x000000000020c5f0) I simple workaround makes it start and open a toolbar-like window with a row of buttons. I will write some tests for this and get proper fix. Thank you for detailed report. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46485 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |https://mamedev.emulab.it/c | |lrmamepro/binaries/cmp4035_ | |64.zip -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46485 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4(a)web.de Summary|clrmamepro: crash when |PBM_STEPIT crashes with |loading datfiles which |division by zero when |contain a "release" element |MinVal == MaxVal == 0 |inside "game" elements | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46485 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Regression SHA1| |9036a84b0f119a32c8ee9d222a2 | |c691cd144a186 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46485 --- Comment #2 from Nikolay Sivov <bunglehead(a)gmail.com> --- Created attachment 63325 --> https://bugs.winehq.org/attachment.cgi?id=63325 patch I'm afraid this will have to wait until Wine 4.0 is out. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46485 --- Comment #3 from Tom <tomgpdev(a)gmail.com> --- (In reply to Nikolay Sivov from comment #2)
Created attachment 63325 [details] patch
I'm afraid this will have to wait until Wine 4.0 is out.
No worries. Thanks for the quick response & fix. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46485 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |620a25ef1d8e87a1fbf282f94a0 | |ee2c8ec9787f0 Status|NEW |RESOLVED Assignee|bunglehead(a)gmail.com |wine-bugs(a)winehq.org --- Comment #4 from Nikolay Sivov <bunglehead(a)gmail.com> --- Fixed, 620a25ef1d8e87a1fbf282f94a0ee2c8ec9787f0. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46485 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 4.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46485 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |4.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46485 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|4.0.x |--- --- Comment #6 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 4.0.x milestone from bug fixes included in 4.0.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org