[Bug 58261] New: Ys Origin: videos playing upside down
http://bugs.winehq.org/show_bug.cgi?id=58261 Bug ID: 58261 Summary: Ys Origin: videos playing upside down Product: Wine Version: unspecified Hardware: x86-64 URL: https://store.steampowered.com/app/207350/Ys_Origin/ OS: Linux Status: NEW Keywords: regression Severity: normal Priority: P2 Component: quartz Assignee: wine-bugs(a)winehq.org Reporter: gyebro69(a)gmail.com CC: z.figura12(a)gmail.com Regression SHA1: 2f180106471a41fa3d95f21919b87b94d8e13e63 Distribution: --- Created attachment 78600 --> http://bugs.winehq.org/attachment.cgi?id=78600 terminal output Intro and in-game videos are playing upside down in Ys:Origin. Tested with the Steam and GOG.com versions. Demo is available on Steam but it is not affected (the demo uses different video format for videos). This is after commit 2f180106471a41fa3d95f21919b87b94d8e13e63 amstream: Implement the custom ddraw stream allocator. The allocator has a lot of custom behaviour that is very visible in how it interacts with Update(). Naturally this has the benefit of writing directly into the mapped surfaces. The gstreamer errors in my log were present before that commit too. wine-10.8-103-g8f91df4c4e4 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58261 Béla Gyebrószki <gyebro69(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |10.9 --- Comment #1 from Béla Gyebrószki <gyebro69(a)gmail.com> --- Still present in Wine-10.11. Some other games that have problems with playing videos due to that commit: Alien Nations, Sacred Gold, Gabriel Knight 3, Earth 2150 series. These are old games in my GOG library, videos in these games are encoded either with Cinepack codec or in WMV3 format. Ys Origin videos are in MPEG-4/Xvid format. E.g. Sacred Gold skips the videos entirely. Gabriel Knight 3 or Alien Nations play the videos but whenever I try to skip it by pressing <Esc> the games become unresponsive: err:sync:RtlpWaitForCriticalSection section 003B3F98 "../wine-git/libs/strmbase/filter.c: strmbase_filter.stream_cs" wait timed out in thread 0024 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58261 --- Comment #2 from Sven Baars <sven.wine(a)gmail.com> --- I gave this a quick look and the cause (of the original issue) seems to be that the surface is no longer being copied, and therefore it is also no longer being flipped. And easy way to work around the issue is by removing the following lines /* Downstream filters probably expect RGB video to be bottom-up. */ if (format.u.video.height > 0 && wg_video_format_is_rgb(video_formats[index])) format.u.video.height = -format.u.video.height; from quartz_parser.c. That's of course not an actual fix, and I'm not sure what the right place is to fix it, so I'll leave this to someone with more knowledge in this area. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58261 Zeb Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |59097 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58261 --- Comment #3 from Zeb Figura <z.figura12(a)gmail.com> --- These are not actually all the same bug. Ys Origin is a failure of the decodebin parser to handle dynamic reconnection. Apparently all filters just have to inherently support this despite it being a pretty obscure feature. Basically amstream connects with one format (top-down), then dynamically reconnects with a different format (bottom-up). Sacred Gold on Steam doesn't seem to use amstream, so I probably am not testing the right version. Earth 2150 has a size mismatch (possibly in addition to the orientation mismatch.) It creates a custom surface with a sub-rect and passes that to amstream. Things then fail because the size of the sample is wrong. I've split off bug 59097. Gabriel Knight 3 seems to crash instantly here. Not sure if that's a different regression or just the Steam version again? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58261 --- Comment #4 from Zeb Figura <z.figura12(a)gmail.com> --- (In reply to Zeb Figura from comment #3)
Gabriel Knight 3 seems to crash instantly here. Not sure if that's a different regression or just the Steam version again?
I think I was just launching it wrong. Actually this is working already upstream, which means it was probably fixed by one of the amstream fixes that I sent soon after the blamed commit. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58261 Zeb Figura <z.figura12@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |5feec037db9c40a1a61c68bdad6 | |6b3bfcc78dcdf Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #5 from Zeb Figura <z.figura12@gmail.com> --- Fixed by 5feec037db9c40a1a61c68bdad66b3bfcc78dcdf. If there are still broken applications please file new bugs. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
WineHQ Bugzilla -
WineHQ Bugzilla