[Bug 37303] New: Change of paper size in print dialog do not update DEVMODE dmFormName member
https://bugs.winehq.org/show_bug.cgi?id=37303 Bug ID: 37303 Summary: Change of paper size in print dialog do not update DEVMODE dmFormName member Product: Wine Version: 1.6.2 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comdlg32 Assignee: wine-bugs(a)winehq.org Reporter: ralf.habacker(a)freenet.de Created attachment 49615 --> https://bugs.winehq.org/attachment.cgi?id=49615 Update dmFormName when changing paper size (patch) A printer paper size change through the printer dialog of any application do not update the DEVMODE dmFormName struct member. How to reproduce: 1. run WINEDEBUG=+psdrv wine notepad 2. check trace output for the following entry (we assume 'A4' is used) trace:psdrv:dump_devmode dmPaperSize: 9 trace:psdrv:dump_devmode dmFormName: L"A4" 3. open print setting 4. change paper size to a different value (for example 'B5') 5. reopen print settings dialog 6. check trace output for the following entry trace:psdrv:dump_devmode dmPaperSize: 11 trace:psdrv:dump_devmode dmFormName: L"A4" -> dmFormName has still the old value Instead it should have trace:psdrv:dump_devmode dmFormName: L"B5" The appended patch fixes this issue. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37303 --- Comment #1 from Ralf Habacker <ralf.habacker(a)freenet.de> --- Patch has been submitted to wine-devel mailing list. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37303 Qian Hong <fracting(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, patch, source Status|UNCONFIRMED |NEW CC| |fracting(a)gmail.com Ever confirmed|0 |1 --- Comment #2 from Qian Hong <fracting(a)gmail.com> --- Confirming. Thanks for report. Patch is not committed. Could you follow http://wiki.winehq.org/SubmittingPatches and resubmit your patch to wine-patches mailing list? Thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37303 --- Comment #3 from Bruno Jesus <00cpxxx(a)gmail.com> --- Patch commited: http://source.winehq.org/git/wine.git/?a=commit;h=2b9d337f6d7848cde660ddc41c... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37303 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |printing Fixed by SHA1| |2b9d337f6d7848cde660ddc41c4 | |19eaefc446eb9 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- Should be fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37303 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.46. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org