[Bug 22635] New: FindFileFirst should ignore some chars
http://bugs.winehq.org/show_bug.cgi?id=22635 Summary: FindFileFirst should ignore some chars Product: Wine Version: 1.1.44 Platform: x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: kernel32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: plr.vincent(a)gmail.com When FindFileFirst is called with such path (c-style notation): "C:\\Program Files/>" it should match "C:\\Program Files" A test for this is in the works (first attempt: http://www.winehq.org/pipermail/wine-devel/2010-May/083434.html ) and this behavior was confirmed on winxp and win2k. This has been discovered while investigating the problem of Earth 2160 packaged by GOG.com: The installer ciphers the cd key to put it in the registry (as GOG doesn't provide different keys for each user, the installer contains one): HKCU\Software\Reality Pump\Earth2160\SerialKey\SerialKey. One of the components used for this is the creation time of the Earth 2160 installation directory. It looks up the path of that directory using another registry key created during the install: HKLM\Software\Reality Pump\Earth2160\FileSystem\DataPath . This key contains that path with a trailing "/>", which seems to be present on purpose (removing it makes the game fail very early when executed). The result is that this path is not found after installation on wine, so the created registry key is invalid when checked by the game. Note that the problem is really only in the installer, as the parameter received by FindFileFirst when game checks the key doesn't contain the trailing "/>". -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22635 Vincent Pelletier <plr.vincent(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, obfuscation, | |testcase Summary|FindFileFirst should ignore |FindFirstFile should ignore |some chars |some chars --- Comment #1 from Vincent Pelletier <plr.vincent(a)gmail.com> 2010-05-09 03:04:15 --- (In reply to comment #0)
FindFileFirst
Could someone please run s/FindFileFirst/FindFirstFile/g on this whole report ? /me hides -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22635 --- Comment #2 from butraxz(a)gmail.com 2013-05-25 09:52:20 CDT --- No update for over 900 days. Is this still and issue in 1.5.31 or higher or is this abandoned ? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=22635 Béla Gyebrószki <gyebro69(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |gyebro69(a)gmail.com Summary|FindFirstFile should ignore |Earth 2160 (GOG.com) can't |some chars |recognize serial number | |(FindFirstFile should | |ignore some chars) Ever confirmed|0 |1 --- Comment #3 from Béla Gyebrószki <gyebro69(a)gmail.com> --- I can confirm this in wine-1.7.44-173-g42cbc05 with the game Earth 2160 from GOG.com. The installer creates the registry keys that contain the serial number, but the game doesn't recognize it and requires the key on each start. Without the serial number the player can't access the main menu. I installed the game in Windows XP running in Virtualbox and the game starts properly there. setup_earth_2160_2.0.0.48.exe (855 MB) sha1: 68af1bc8a1f8ae9fd3808cc8fa9cb7b0c2d18760 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=22635 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED CC| |dmitry(a)baikal.ru, | |erich.e.hoover(a)wine-staging | |.com, michael(a)fds-team.de, | |sebastian(a)fds-team.de Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/kernel32-FindF | |irstFile -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=22635 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv(a)dawncrow.de Staged patchset|https://github.com/wine-com |https://github.com/wine-sta |pholio/wine-staging/tree/ma |ging/wine-staging/tree/mast |ster/patches/kernel32-FindF |er/patches/kernel32-FindFir |irstFile |stFile -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=22635 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Earth 2160 (GOG.com) can't |Earth 2160 (GOG.com) can't |recognize serial number |recognize serial number |(FindFirstFile should | |ignore some chars) | CC| |z.figura12(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=22635 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |690a0699189b26d4821d614dfa9 | |704f49cf610a7 Resolution|--- |FIXED Status|STAGED |RESOLVED --- Comment #4 from Zebediah Figura <z.figura12(a)gmail.com> --- Fixed by <https://source.winehq.org/git/wine.git/commitdiff/690a0699189b26d4821d614dfa9704f49cf610a7>. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=22635 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|kernel32 |ntdll -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=22635 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 6.2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=22635 WinterSnowfall <winter.snowfall23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winter.snowfall23(a)gmail.com --- Comment #6 from WinterSnowfall <winter.snowfall23(a)gmail.com> --- I was presently surprised to see this marked as fixed. Sadly, I just tried to install and play the game, but it's still not working properly and prompts for a serial key on each startup. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=22635 Otto <b1779506(a)trbvn.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |b1779506(a)trbvn.com --- Comment #7 from Otto <b1779506(a)trbvn.com> --- (In reply to WinterSnowfall from comment #6)
I was presently surprised to see this marked as fixed. Sadly, I just tried to install and play the game, but it's still not working properly and prompts for a serial key on each startup.
Open a new bug. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=22635 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |6.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=22635 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|6.0.x |--- --- Comment #8 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 6.0.x milestone from bug fixes included in 6.0.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=22635 Mehmet gelisin <mehmetgelisin(a)aol.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mehmetgelisin(a)aol.com --- Comment #9 from Mehmet gelisin <mehmetgelisin(a)aol.com> --- When FindFileFirst is called with such path (c-style notation): "C:\\Program Files/>" it should match http://www.compilatori.com/ "C:\\Program Files" his has been discovered while investigating the problem of Earth 2160 packaged by GOG.com: http://www.wearelondonmade.com/ The installer ciphers the cd key to put it in the registry (as GOG doesn't provide different keys for each user, the installer contains one): http://www.jopspeech.com/ HKCU\Software\Reality Pump\Earth2160\SerialKey\SerialKey. One of the components used for this is the creation time of the Earth 2160 installation directory. http://joerg.li/ When FindFileFirst is called with such path (c-style notation): "C:\\Program Files/>" http://connstr.net/ it should match "C:\\Program Files" http://embermanchester.uk/ It looks up the path of that directory using another registry key created during the install: HKLM\Software\Reality Pump\Earth2160\FileSystem\DataPath . This key contains that path with a trailing "/>", http://www.slipstone.co.uk/ which seems to be present on purpose (removing it makes the game fail very early when executed). The result is that this path is not found after installation on wine, so the created registry key is invalid when checked by the game. http://www.logoarts.co.uk/ When FindFileFirst is called with such path (c-style notation): "C:\\Program Files/>" it should match "C:\\Program Files" http://www.acpirateradio.co.uk/ his has been discovered while investigating the problem of Earth 2160 packaged by GOG.com: The installer ciphers the cd key to put it in the registry (as GOG doesn't provide different keys for each user, the installer contains one): HKCU\Software\Reality Pump\Earth2160\SerialKey\SerialKey. One of the components used for this is the creation time of the Earth 2160 installation directory. https://waytowhatsnext.com/ When FindFileFirst is called with such path (c-style notation): "C:\\Program Files/>" it should match "C:\\Program Files" https://www.webb-dev.co.uk/ It looks up the path of that directory using another registry key created during the install: HKLM\Software\Reality Pump\Earth2160\FileSystem\DataPath . This key contains that path with a trailing "/>", which seems to be present on purpose (removing it makes the game fail very early when executed). The result is that this path is not found after installation on wine, so the created registry key is invalid when checked by the game. When FindFileFirst is called with such path (c-style notation): "C:\\Program Files/>" it should match "C:\\Program Files" http://www.iu-bloomington.com/ his has been discovered while investigating the problem of Earth 2160 packaged by GOG.com: The installer ciphers the cd key to put it in the registry (as GOG doesn't provide different keys for each user, the installer contains one): HKCU\Software\Reality Pump\Earth2160\SerialKey\SerialKey. One of the components used for this is the creation time of the Earth 2160 installation directory. When FindFileFirst is called with such path (c-style notation): "C:\\Program Files/>" it should match "C:\\Program Files" http://www-look-4.com/ It looks up the path of that directory using another registry key created during the install: HKLM\Software\Reality Pump\Earth2160\FileSystem\DataPath . This key contains that path with a trailing "/>", which seems to be present on purpose (removing it makes the game fail very early when executed). The result is that this path is not found after installation on wine, so the created registry key is invalid when checked by the game. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla