[Bug 16867] New: Issues with DD_STRUCT_COPY_BYSIZE
http://bugs.winehq.org/show_bug.cgi?id=16867 Summary: Issues with DD_STRUCT_COPY_BYSIZE Product: Wine Version: 1.1.12 Platform: Other OS/Version: other Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-ddraw AssignedTo: wine-bugs(a)winehq.org ReportedBy: spam(a)graph-ix.net DD_STRUCT_COPY_BYSIZE does not properly copy all DDraw structs or is not properly called in at least one location of the Wine code. The example I found is in IDirectDrawImpl_GetCaps, where the ddsCaps within DDCAPS are not correctly copied. There are possibly more occurrences. DD_STRUCT_COPY_BYSIZE is defined in ddraw_private.h -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16867 --- Comment #1 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2009-01-10 13:15:59 --- Have any sample code to show the problem? I don't see anything wrong with the way DD_STRUCT_COPY_BYSIZE is used in IDirectDrawImpl_GetCaps(). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16867 --- Comment #2 from Markus <spam(a)graph-ix.net> 2009-01-10 13:50:49 --- If you add caps.ddsCaps.dwCaps = 0; in front of the line if(DriverCaps) in IDirectDrawImpl_GetCaps and then look at the trace output of DDRAW_dump_DDCAPS a few lines below the addition, you'll see that the ddsCaps it prints is not 0. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16867 --- Comment #3 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2009-01-10 15:03:32 --- Real code please! It's completely valid to get what you say if dwSize of the passed in DriverCaps is not set correctly. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16867 Markus <spam(a)graph-ix.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID --- Comment #4 from Markus <spam(a)graph-ix.net> 2009-01-10 16:01:39 --- It's my fault then and invalid. I had understood that Stefan D. on IRC that it was incorrect behavior and that I should file a bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16867 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|INVALID | --- Comment #5 from Austin English <austinenglish(a)gmail.com> 2009-01-10 16:45:45 --- If Stefand say to file a bug, it's a valid bug. I'm pretty sure he knows the code in question pretty well :-). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16867 Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID --- Comment #6 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2009-01-10 20:35:35 --- (In reply to comment #5)
If Stefand say to file a bug, it's a valid bug. I'm pretty sure he knows the code in question pretty well :-).
REAL CODE PLEASE!!! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16867 Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2009-01-10 20:35:42 --- Closing -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16867 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|directx-ddraw |directx-d3d -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org