[Bug 20977] New: Bad hlp table rendering
http://bugs.winehq.org/show_bug.cgi?id=20977 Summary: Bad hlp table rendering Product: Wine Version: 1.1.34 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: adys.wh(a)gmail.com Created an attachment (id=25145) --> (http://bugs.winehq.org/attachment.cgi?id=25145) Help file Terrible rendering on attached HLP file. Refer to screenshots. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #1 from Jerome Leclanche <adys.wh(a)gmail.com> 2009-12-09 17:53:38 --- Created an attachment (id=25146) --> (http://bugs.winehq.org/attachment.cgi?id=25146) Wine rendering. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #2 from Jerome Leclanche <adys.wh(a)gmail.com> 2009-12-09 17:54:04 --- Created an attachment (id=25147) --> (http://bugs.winehq.org/attachment.cgi?id=25147) Wine rendering. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20977 Jerome Leclanche <adys.wh(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25146|Wine rendering. |Windows rendering. description| | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20977 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20977 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |nerv(a)dawncrow.de Ever Confirmed|0 |1 --- Comment #3 from André H. <nerv(a)dawncrow.de> 2009-12-10 12:05:04 --- confirming in today's git -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20977 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |programs -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #4 from Jerome Leclanche <adys.wh(a)gmail.com> 2010-03-16 15:27:13 --- Still an issue in wine-1.1.40-191-g4b5f6ad. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #5 from Jerome Leclanche <adys.wh(a)gmail.com> 2010-05-02 00:39:05 --- Still an issue in wine-1.1.43-408-g3317fc3. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #6 from Jerome Leclanche <adys.wh(a)gmail.com> 2012-05-08 06:37:18 CDT --- No change in wine-1.5.3. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #7 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- Is this still an issue in Wine 1.7.45 or later? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #8 from André H. <nerv(a)dawncrow.de> --- (In reply to Ken Sharp from comment #7)
Is this still an issue in Wine 1.7.45 or later?
Still present, test with: wine winhlp32 ARCON.HLP -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man(a)post.com --- Comment #9 from super_man(a)post.com --- still an issue, but it's quite close to correct 1.8.rc1 There are some names that are written in windows hlp like this car but in wine c a r -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 Jice <wine(a)cardot.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wine(a)cardot.net --- Comment #10 from Jice <wine(a)cardot.net> --- Created attachment 53083 --> https://bugs.winehq.org/attachment.cgi?id=53083 WinHLP table patch fix I has the same problem with hlp files I'm using. Here is a patch that fixes the tables in winhlp32. I will attach some more screenshots to show how in enhanced the program: in my case, some pages (topics) did not show up at all! This is my first wine patch, please comment. In particular, the way I'm using to get a value from the registry seems quite complicated to me (I copied some code from wordpad IIRC) ; I think there might be a better approach for this but did not find it. Thanks in advance for your comments! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #11 from Matteo Bruni <matteo.mystral(a)gmail.com> --- Thank you for the patch! Notice though that patches are not picked from Bugzilla, they have to be sent to the wine-patches mailing list. http://wiki.winehq.org/SubmittingPatches should have a number of useful tips, other things I noticed at a very quick look: - your patch seems to contain a number of separate fixes, you should split them over multiple patches - C++-style comments are not allowed in Wine - don't add obvious comments e.g. "// JCC read the DPI from the registry", also don't mark your changes with comments, git keeps track of code ownership just fine ;) - don't make random whitespace changes - don't leave commented-out code in the patch if there isn't some particularly good reason (and in that case, if (0) { ... } is preferred) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 curaga(a)operamail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |curaga(a)operamail.com --- Comment #12 from curaga(a)operamail.com --- *** Bug 39946 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #13 from Jice <wine(a)cardot.net> --- Created attachment 53752 --> https://bugs.winehq.org/attachment.cgi?id=53752 0001-winhlp32-fix-table-formatting.patch adding the patches for review as seen with slackner on #wine-staging -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #14 from Jice <wine(a)cardot.net> --- Created attachment 53753 --> https://bugs.winehq.org/attachment.cgi?id=53753 0002-winhlp32-fix-table-formatting.patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #15 from Jice <wine(a)cardot.net> --- Created attachment 53754 --> https://bugs.winehq.org/attachment.cgi?id=53754 0003-winhlp32-fix-table-formatting.patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #16 from Jice <wine(a)cardot.net> --- Created attachment 53755 --> https://bugs.winehq.org/attachment.cgi?id=53755 0004-winhlp32-fix-table-formatting.patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #17 from Jice <wine(a)cardot.net> --- Created attachment 53756 --> https://bugs.winehq.org/attachment.cgi?id=53756 0005-winhlp32-fix-table-formatting.patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #18 from Jice <wine(a)cardot.net> --- Created attachment 53757 --> https://bugs.winehq.org/attachment.cgi?id=53757 0006-winhlp32-fix-table-formatting.patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian(a)fds-team.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #19 from Jice <wine(a)cardot.net> --- here are the 6 patches, hopefully meeting better the guide lines for patches submission ;) Thanks in advance slackner and anyone with the will to check them! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #20 from Jerome Leclanche <jerome(a)leclan.ch> --- Hey Jice, patches are not picked up from Bugzilla. Can you send it to wine-patches? See https://wiki.winehq.org/Submitting_Patches -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #21 from Sebastian Lackner <sebastian(a)fds-team.de> --- (In reply to Jerome Leclanche from comment #20)
Hey Jice, patches are not picked up from Bugzilla. Can you send it to wine-patches?
I was asked to double-check the patches before he submits them, so it is fine to attach them here. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #22 from Jerome Leclanche <jerome(a)leclan.ch> --- My bad. :) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #23 from Sebastian Lackner <sebastian(a)fds-team.de> --- (In reply to Jice from comment #13)
Created attachment 53752 [details] 0001-winhlp32-fix-table-formatting.patch
Just had a look at your patches. As a general remark, the subject line "Fix table formatting" is not really very meaningful and only fits for the last patch. For the other patches, it would be better to describe the real changes, and avoid the extra description in the next line. Some more detailed comments: 1/6 - The idea is fine, but I don't think you catched all occurances of those constants. HLPFILE_SkipParagraph also compares against hardcoded 0x20 and 0x23 values for example. 2/6 - There is never a need to TRACE the function name itself, it will automatically be added by Wine in front of your message. Strings should be passed through debugstr_a() to ensure they are valid before passing them to TRACE. 3/6 - Should be fine. 4/6 - You are adding commented-out code here, which should be avoided. Those parts should probably go into to a later patch, when it is really needed. The detection based on face_offset also looks a bit suspicious. 5/6 - I'm not sure about the rounderr, otherwise it should be fine. 6/6 - There are still various formatting changes in there, I would suggest to remove them or move them to previous patches. Since this is the most critical patch its good to keep the number of unrelated changes as small as possible. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 --- Comment #24 from Jice <wine(a)cardot.net> --- Thank you! 1. OK. I could only find the occurences in HLPFILE_SkipParagraph which had been forgotten. 2. OK. I made use of debugstr_a(). Nevertheless none of the already existing WINE_TRACE make use of it. Should it be addressed in another patch? 3. OK 4. OK. Removed the comments. The face_offset is documented there: http://www.oocities.org/mwinterhoff/helpfile.htm and according to the documentation it is the way to detect the font type (see the |FONT paragraph). 5. Rounderr comes from the fact we have metrics expressed in half points and a scale of 10. This can be removed with very few visual impacts, but the computation is more exact this way. 6. Can you please give me one example of formatting change? I cannot see any, except if you speak of the lines where I added comments for better understanding (like case 0x89: /* hotspot end */)? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx(a)gmail.com --- Comment #25 from super_man(a)post.com --- This bug is fixed. 6 patches were merged into wine. wine-1.9.7-225-g1ccc521 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |markk(a)clara.co.uk --- Comment #26 from Bruno Jesus <00cpxxx(a)gmail.com> --- *** Bug 14288 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |706145c563115afadc4eaab2a4f | |8ae8a7c8b26e5 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #27 from Bruno Jesus <00cpxxx(a)gmail.com> --- I just tested with the file in comment 0 and the rendering is correct as per the Windows screenshot. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #28 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.9.12. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mstefani(a)redhat.com Target Milestone|--- |1.8.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20977 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.8.x |--- --- Comment #29 from Michael Stefaniuc <mstefani(a)redhat.com> --- Removing 1.8.x milestone from bugs included in 1.8.4. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org