[Bug 19210] New: expr_alloc_uconstant() is not used
http://bugs.winehq.org/show_bug.cgi?id=19210 Summary: expr_alloc_uconstant() is not used Product: Wine Version: 1.1.25 Platform: All OS/Version: All Status: NEW Keywords: source, winelib Severity: normal Priority: P2 Component: winedbg AssignedTo: wine-bugs(a)winehq.org ReportedBy: fgouget(a)codeweavers.com programs/winedbg/expr.c defines both an expr_alloc_sconstant() and an expr_alloc_uconstant() function. However: * expr_alloc_uconstant() is not used anywhere. So at first sight it should be removed. * But expr_alloc_sconstant() is used to allocate tNUM constant which, as far as I can see, are unsigned constants. * expr_alloc_sconstant() is used nowhere else. So something is wrong there. This is also related to EXPR_TYPE_U_CONST vs. EXPR_TYPE_S_CONST. Possible fixes: * Modify the lexer to only return unsigned constants (since that's all it can match), and then get rid of expr_alloc_sconstant() and EXPR_TYPE_S_CONST. * Modify the lexer to return both signed and unsigned constants as appropriate. In either case it will likely require modifications in the expression computation package as it only knows how to deal with signed integers. See also this thread: http://www.winehq.org/pipermail/wine-devel/2009-January/072074.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19210 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|winelib | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19210 Dmitry Timoshkov <dmitry(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Platform|All |Other OS/Version|All |other -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19210 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2010-07-23 15:40:11 --- Still present in wine-1.2-422-ge158bb0 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19210 --- Comment #2 from Austin English <austinenglish(a)gmail.com> 2012-10-03 19:26:06 CDT --- Still in wine-1.5.14-142-g730479e -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19210 --- Comment #3 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- Is this still an issue in Wine 1.7.45 or later? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19210 --- Comment #4 from François Gouget <fgouget(a)codeweavers.com> --- This issue is still present. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org