[Bug 40060] New: Crash dialog button unclickable
https://bugs.winehq.org/show_bug.cgi?id=40060 Bug ID: 40060 Summary: Crash dialog button unclickable Product: Wine-staging Version: 1.9.2 Hardware: x86 OS: Mac OS X Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: isakov-sl(a)bk.ru CC: erich.e.hoover(a)wine-staging.com, michael(a)fds-team.de, sebastian(a)fds-team.de Created attachment 53538 --> https://bugs.winehq.org/attachment.cgi?id=53538 The windows in question If a game crashes (for example elevated_1024x768.exe) then dialog windows appeared with two buttons "Show details" and "Close". These buttons are unclickable because of patch https://github.com/wine-compholio/wine-staging/blob/master/patches/user32-Mo... Reverting the patch resolves the issue. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40060 Sergey Isakov <isakov-sl(a)bk.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Crash dialog button |Crash dialog buttons |unclickable |unclickable -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40060 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |dmitry(a)baikal.ru --- Comment #1 from Sebastian Lackner <sebastian(a)fds-team.de> --- Dmitry: Could you maybe have a look? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40060 --- Comment #2 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Sergey Isakov from comment #0)
Created attachment 53538 [details] The windows in question
If a game crashes (for example elevated_1024x768.exe) then dialog windows appeared with two buttons "Show details" and "Close". These buttons are unclickable because of patch https://github.com/wine-compholio/wine-staging/blob/master/patches/user32- Mouse_Message_Hwnd/0001-user32-Try-harder-to-find-a-target-for-mouse-message. patch
Reverting the patch resolves the issue.
I can't reproduce the described behaviour with the patch applied and a simple test application that intentionally causes a crash under Linux and Mate WM. Could that be a Mac specific window management issue? Sergey, do you have any other patches applied that may have a side effect on this behaviour? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40060 --- Comment #3 from Sergey Isakov <isakov-sl(a)bk.ru> --- Half of stage patches. Nj claim that the patch is the reason of such behavior I made regression test. It shows me this commit. Then I reverted the patch and got the result. Bisecting was unambiguos, good - clockable and bad - unclickable. May be some older patch has influence. May be the reason is winemac.drv. I will later test with winex11.drv. I can also proposed that it is MacOSX behaviour that the dialog appears as not active. It is beside black screen and appears after my Alt-Tab. On the other hand let think about the patch. Why it replaces hwnd to null? What is original idea that it must be real handler? Why you decided it is wrong and must be zero? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40060 --- Comment #4 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Sergey Isakov from comment #3)
On the other hand let think about the patch. Why it replaces hwnd to null? What is original idea that it must be real handler? Why you decided it is wrong and must be zero?
The patch asks WindowFromPoint() to look for the event target window starting from desktop window instead of the window specified in the message structure. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40060 --- Comment #5 from Sergey Isakov <isakov-sl(a)bk.ru> --- Is it possible the crash dialog is not in the list? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40060 --- Comment #6 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Sergey Isakov from comment #5)
Is it possible the crash dialog is not in the list?
No, unless you have some hacks in that area. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40060 Dmitry Timoshkov <dmitry(a)baikal.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40060 --- Comment #7 from Sergey Isakov <isakov-sl(a)bk.ru> --- I don't know how to search a reason of the contradiction. May be someone else confirm this. May be no. I reverted this patch and I am happy because the origin of the hack is "Photoshop 7..." is not interesting me in MacOS. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40060 Aaron Franke <arnfranke(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arnfranke(a)yahoo.com --- Comment #8 from Aaron Franke <arnfranke(a)yahoo.com> --- Is this still an issue in Wine 2.6? This issue is marked as a regression, can you confirm whether or not this problem exists in previous versions of Wine? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40060 Sergey Isakov <isakov-sl(a)bk.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEEDINFO |RESOLVED --- Comment #9 from Sergey Isakov <isakov-sl(a)bk.ru> --- Tested staging-4.1. The bug is no more valid. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40060 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #10 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Closing Fixed Staging bugs. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org