[Bug 38279] New: Uninitialized src_rect in wined3d/surface.c:cpu_blit_color_fill
https://bugs.winehq.org/show_bug.cgi?id=38279 Bug ID: 38279 Summary: Uninitialized src_rect in wined3d/surface.c:cpu_blit_color_fill Product: Wine Version: 1.7.39 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-d3d Assignee: wine-bugs(a)winehq.org Reporter: isakov-sl(a)bk.ru Distribution: --- In procedure cpu_blit_color_fill there is local variable static const RECT src_rect; assumed inited by zero? Then it used as parameter return surface_cpu_blt(dst_surface, dst_rect, NULL, &src_rect, WINEDDBLT_COLORFILL, &BltFx, WINED3D_TEXF_POINT); And this function explicitly used the pointer srcheight = src_rect->bottom - src_rect->top; srcwidth = src_rect->right - src_rect->left; What behavior assumed here? I found no assingment to this static constant. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38279 --- Comment #1 from Henri Verbeet <hverbeet(a)gmail.com> --- I'm not quite sure what you think the bug is, but static implies zero initialisation, which is fine because WINEDDBLT_COLORFILL doesn't really use a source rectangle. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38279 --- Comment #2 from Sergey Isakov <isakov-sl(a)bk.ru> --- OK, if it is normal for src_rect to be zero then let it be. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38279 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID --- Comment #3 from Austin English <austinenglish(a)gmail.com> --- (In reply to Sergey Isakov from comment #2)
OK, if it is normal for src_rect to be zero then let it be.
Invalid. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38279 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Bruno Jesus <00cpxxx(a)gmail.com> --- Closing invalid bugs. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs@winehq.org