[Bug 45647] New: chromium x64 sandbox >=win10 needs win10 csrss heap
https://bugs.winehq.org/show_bug.cgi?id=45647 Bug ID: 45647 Summary: chromium x64 sandbox >=win10 needs win10 csrss heap Product: Wine Version: 3.13 Hardware: x86 OS: Linux Status: NEW Keywords: patch Severity: normal Priority: P2 Component: ntdll Assignee: wine-bugs(a)winehq.org Reporter: dark.shadow4(a)web.de Distribution: --- Created attachment 62076 --> https://bugs.winehq.org/attachment.cgi?id=62076 Patch to provide csrss heap and fake win10 heaps Follow up to bug 45646. Starting with win10, the chromium sandbox tries to find a certain heap that's shared with csrss.exe. It does this by enumerating all process heaps, looking in the internal structure for the right flags. For that it assumes the internal structure behind the opaque handle... We need to do 2 things here. 1) Provide a csrss heap in the first place 2) Return handles that have a heap structure similar to win10 heap behind them -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45647 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12(a)gmail.com --- Comment #1 from Fabian Maurer <dark.shadow4(a)web.de> --- Not sure if that's something that's suitable for upstream (yet). If you have a better solution, just tell me, for now I don't see a better way than to provide fake heaps. Would that make sense for staging? Sidenote: The first patch in the series, the one who removes the two lines, is needed because else the test in the second test fails. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45647 --- Comment #2 from Zebediah Figura <z.figura12(a)gmail.com> --- Is this something that we can ask CEF not to do? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45647 --- Comment #3 from Fabian Maurer <dark.shadow4(a)web.de> --- I'm not sure, they added that for security reasons. They'd probably have to check for wine as a workaround. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45647 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|chromium x64 sandbox |chromium 64-bit sandbox |>=win10 needs win10 csrss |>=win10 needs win10 csrss |heap |heap -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45647 mirh <mirh(a)protonmail.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirh(a)protonmail.ch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45647 Robert Walker <bob.mt.wya(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob.mt.wya(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45647 zzzzzyzz(a)hacari.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zzzzzyzz(a)hacari.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45647 --- Comment #4 from Fabian Maurer <dark.shadow4(a)web.de> --- Relevant chromium code: https://github.com/chromium/chromium/blob/2cab8367dd145569c2164306e9b2d24c5a... Seems to currently work on chromium, but I can't test google chrome, since this currently has other issues. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45647 --- Comment #5 from Fabian Maurer <dark.shadow4(a)web.de> --- This seems to work in never chromium versions, although I don't really know why. Not sure what the resolution for this issue should be though. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45647 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #6 from Fabian Maurer <dark.shadow4(a)web.de> --- I can're reproduce this issue anymore, it seems to work reliably now. Not sure what changed, since the code is still there, but it works. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45647 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Austin English <austinenglish(a)gmail.com> --- Closing. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs@winehq.org -
WineHQ Bugzilla