[Bug 9450] New: Wrong rebar height calculation for hidden bands

http://bugs.winehq.org/show_bug.cgi?id=9450

           Summary: Wrong rebar height calculation for hidden bands
           Product: Wine
           Version: 0.9.42.
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Wine-Rebar
        AssignedTo: wine-bugs(a)winehq.org
        ReportedBy: alex(a)thehandofagony.com


Created an attachment (id=7780)
 --> (http://bugs.winehq.org/attachment.cgi?id=7780)
Proposed patch

Currently our builtin rebar code does not calculate 0 as the height of the 
control if no bands are visible, while native does.
Tracing through our rebar code I found this suspicious code:

    for (i = iBeginBand; i < iEndBand; i = next_band(infoPtr, i))
    {
        lpBand = &infoPtr->bands[i];
        yMaxHeight = max(yMaxHeight, lpBand->lcy);
    }

while further down the height of the control is returned as
    return yPos + yMaxHeight;

It does not make sense to include the hight of a hidden band, and my fix 

    for (i = iBeginBand; i < iEndBand; i = next_band(infoPtr, i))
    {
        lpBand = &infoPtr->bands[i];
        if(!HIDDENBAND(lpBand))
            yMaxHeight = max(yMaxHeight, lpBand->lcy);
    }

corrects the problem. 

But this will need a test case, right?


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 9450] Wrong rebar height calculation for hidden bands

http://bugs.winehq.org/show_bug.cgi?id=9450


Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikolaj.zalewski(a)gmail.com




--- Comment #1 from Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com>  2007-08-25 14:40:35 ---
The next_band is supposed to take care of hidden bands. However this doesn't
work if the first band is hidden. I will try to write a patch for this.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 9450] Wrong rebar height calculation for hidden bands

http://bugs.winehq.org/show_bug.cgi?id=9450


Vitaliy Margolen <vitaliy(a)kievinfo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Wine-Rebar                  |wine-comctl32




-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 9450] Wrong rebar height calculation for hidden bands

http://bugs.winehq.org/show_bug.cgi?id=9450





--- Comment #2 from Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com>  2008-02-26 15:53:34 ---
The patch in comment #10 of bug #10239 should fix such bugs. Does it work for
you?


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 9450] Wrong rebar height calculation for hidden bands

http://bugs.winehq.org/show_bug.cgi?id=9450


Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com>  2008-02-28 07:18:41 ---
The patch http://www.winehq.org/pipermail/wine-cvs/2008-February/040832.html
got accepted into Wine Git and should be available in Wine releases starting
from Wine 0.9.57.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 9450] Wrong rebar height calculation for hidden bands

http://bugs.winehq.org/show_bug.cgi?id=9450


Alexandre Julliard <julliard(a)winehq.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED




--- Comment #4 from Alexandre Julliard <julliard(a)winehq.org>  2008-03-07 11:28:26 ---
Closing bugs fixed in 0.9.57.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.