[Bug 36060] New: Hawking control center driver install tool crashes during installation
https://bugs.winehq.org/show_bug.cgi?id=36060 Bug ID: 36060 Summary: Hawking control center driver install tool crashes during installation Product: Wine Version: 1.7.17 Hardware: x86 URL: http://hawkingtech.com/products/downloadfile/983.html OS: Linux Status: NEW Keywords: download Severity: normal Priority: P2 Component: shlwapi Assignee: wine-bugs(a)winehq.org Reporter: austinenglish(a)gmail.com Created attachment 48241 --> https://bugs.winehq.org/attachment.cgi?id=48241 terminal output/backtrace fixme:shell:SHRegCreateUSKeyW unsupported flags 0x00000004 wine: Unhandled page fault on read access to 0x00000004 at address 0x7e955e07 (thread 008b), starting debugger... .. Backtrace: =>0 0x7e955e07 SHRegCloseUSKey+0x17(hUSKey=<couldn't compute location>) [/home/austin/wine-git/dlls/shlwapi/reg.c:196] in shlwapi (0x0033f858) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36060 --- Comment #1 from Austin English <austinenglish(a)gmail.com> --- austin(a)aw25 ~ $ du -h software_Win_HMPS2U.zip 8.4M software_Win_HMPS2U.zip austin(a)aw25 ~ $ sha1sum software_Win_HMPS2U.zip 1609b8f9807be92cba92814cafed8b8dc1f5bf85 software_Win_HMPS2U.zip austin(a)aw25 ~ $ wine --version wine-1.7.17-42-g24c5728 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36060 driuli(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |driuli(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36060 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man(a)post.com --- Comment #2 from super_man(a)post.com --- still an issue 1.7.50 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36060 --- Comment #3 from super_man(a)post.com --- I have a theory of the problem. If it's not correct I at least have an hack to prevent it which could be real fix too. I think the problem could be here. fixme:shell:SHRegCreateUSKeyW unsupported flags 0x00000004 Wine doesn't really do anything. http://source.winehq.org/git/wine.git/blob/253a587e471a653e1b5ed590280452f43... It returns success. And next the program wants to SHRegCloseUSKey key that was never created. To prevent the crash here I created NULL check. --- dlls/shlwapi/reg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/shlwapi/reg.c b/dlls/shlwapi/reg.c index 1653b80..3fbc9b8 100644 --- a/dlls/shlwapi/reg.c +++ b/dlls/shlwapi/reg.c @@ -193,6 +193,7 @@ LONG WINAPI SHRegCloseUSKey( LPSHUSKEY hKey = hUSKey; LONG ret = ERROR_SUCCESS; + if(hUSKey == NULL) return ret; if (hKey->HKCUkey) ret = RegCloseKey(hKey->HKCUkey); if (hKey->HKCUstart && hKey->HKCUstart != HKEY_CURRENT_USER) -- 1.9.1 And no more crash while installing. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36060 --- Comment #4 from Bruno Jesus <00cpxxx(a)gmail.com> --- Thanks for the analysis, that indeed seems to be the problem. I'll do some tests for Windows to check the results. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36060 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Installer Summary|Hawking control center |Hawking Control Center |driver install tool crashes |driver installer tool |during installation |crashes (SHRegCloseUSKey | |crashes on NULL key) --- Comment #5 from Bruno Jesus <00cpxxx(a)gmail.com> --- Patch sent: http://source.winehq.org/patches/data/114251 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36060 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |ffb4d151174be47b728099e0d20 | |3474e5e6d1b5a Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from Bruno Jesus <00cpxxx(a)gmail.com> --- Fixed by ffb4d151174be47b728099e0d203474e5e6d1b5a. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36060 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.52. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36060 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |compunuts(a)yahoo.com --- Comment #8 from Anastasius Focht <focht(a)gmx.net> --- *** Bug 39405 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org