[Bug 46907] New: msi crashes processing a RemoveFile table with an invalid directory
https://bugs.winehq.org/show_bug.cgi?id=46907 Bug ID: 46907 Summary: msi crashes processing a RemoveFile table with an invalid directory Product: Wine Version: 4.4 Hardware: x86 OS: Linux Status: NEW Severity: minor Priority: P2 Component: msi Assignee: wine-bugs(a)winehq.org Reporter: madewokherd(a)gmail.com Distribution: --- This is just something I noticed while splitting up the Wine Mono msi. The action should probably fail without crashing. Backtrace: =>0 0x00007f455c7853c8 remove_folder+0x8(folder=(nil)) [/home/meh/work/wine/wine64/dlls/msi/../../../dlls/msi/files.c:1549] in msi (0x00000000000a1580) 1 0x00007f455c78a350 ACTION_RemoveFiles+0x1ef(package=0xa1580) [/home/meh/work/wine/wine64/dlls/msi/../../../dlls/msi/files.c:1648] in msi (0x00000000000a1580) 2 0x00007f455c74c330 ACTION_HandleStandardAction+0x16f(package=0xa1580, action="RemoveFiles") [/home/meh/work/wine/wine64/dlls/msi/../../../dlls/msi/action.c:7980] in msi (0x00000000000c63c0) 3 0x00007f455c75d298 ACTION_PerformAction+0x27() in msi (0x00000000000b1f10) 4 0x00007f455c75d7b6 execute_script+0x115(package=0xa1580, script=0x2) [/home/meh/work/wine/wine64/dlls/msi/../../../dlls/msi/action.c:1543] in msi (0x00000000000b1f10) 5 0x00007f455c75e5d3 MSI_InstallPackage+0x4f2(package=0xa1580, szPackagePath=<is not available>, szCommandLine=<is not available>) [/home/meh/work/wine/wine64/dlls/msi/../../../dlls/msi/action.c:8178] in msi (0x00000000000b1f10) 6 0x00007f455c79a5c2 MsiInstallProductW+0x1e1(szPackagePath="image/support/winemono-support.msi", szCommandLine=0x0(nil)) [/home/meh/work/wine/wine64/dlls/msi/../../../dlls/msi/msi.c:268] in msi (0x000000000022fa10) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46907 Vincent Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madewokherd(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46907 Vincent Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|msi crashes processing a |msi crashes in RemoveFiles |RemoveFile table with an |action for a broken msi |invalid directory | --- Comment #1 from Vincent Povirk <madewokherd(a)gmail.com> --- It seems my theory about what's causing this crash is incorrect, and I'm not sure what's really going on. I'm attaching the broken msi just in case I accidentally fix it without understanding it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46907 --- Comment #2 from Vincent Povirk <madewokherd(a)gmail.com> --- Created attachment 63985 --> https://bugs.winehq.org/attachment.cgi?id=63985 broken msi -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46907 Vincent Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46907 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Installer -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46907 --- Comment #3 from Vincent Povirk <madewokherd(a)gmail.com> --- Turns out I had an invalid directory key in the component table. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46907 Hans Leidekker <hans(a)meelstraat.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |c7f323107b3b956d206d8d0ee28 | |851d60f19841c --- Comment #4 from Hans Leidekker <hans(a)meelstraat.net> --- Fixed by c7f323107b3b956d206d8d0ee28851d60f19841c. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46907 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 4.5. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46907 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |4.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46907 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|4.0.x |--- --- Comment #6 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 4.0.x milestone from bug fixes included in 4.0.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org