[Bug 44286] New: Regression: Default value in dropdown list is no longer select
https://bugs.winehq.org/show_bug.cgi?id=44286 Bug ID: 44286 Summary: Regression: Default value in dropdown list is no longer select Product: Wine Version: 3.0-rc4 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: wine(a)sagagames.de Distribution: --- Steps to reproduce: 1. Download OpenMPT (https://openmpt.org/) 2. Create a new document 3. Activate the pattern tab. 4. In the pattern tab, click the icon in the toolbar resembling a question mark. 5. The pattern properties dialog pops up. It contains a dropdown list, and the current pattern size (64) should be selected. This is a regression from older Wine versions. In Wine 2.19 (last version I tested), the current pattern size is still selected, like on Windows. on Wine 3.0-rc4, the input field of the dropdown list remains empty instead. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44286 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://openmpt.org/downloa | |d Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC| |dark.shadow4(a)web.de Keywords| |download, regression --- Comment #1 from Fabian Maurer <dark.shadow4(a)web.de> --- Confirming. It does work for you with wine-2.19? Because for me it does not, but it works with wine-2.18... I'm going to do a regression test, adding the results later. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44286 Ulrich Gemkow <ulrich.gemkow(a)ikr.uni-stuttgart.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ulrich.gemkow(a)ikr.uni-stutt | |gart.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44286 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |1a114c9f4bab60463189e3ecb89 | |766d4d2017d53 CC| |piotr(a)codeweavers.com --- Comment #2 from Fabian Maurer <dark.shadow4(a)web.de> --- Bisected to commit 1a114c9f4bab60463189e3ecb89766d4d2017d53 Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Oct 4 12:38:47 2017 +0200 user32: Don't invalidate ComboBox on CB_SETCURSEL message. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> Reverting fixes the issue. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44286 Piotr Caban <piotr.caban(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |910129fcf7a7ade52a78d588685 | |a860acae8d8b8 CC| |piotr.caban(a)gmail.com Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Piotr Caban <piotr.caban(a)gmail.com> --- It's fixed for me by following commit: 910129fcf7a7ade52a78d588685a860acae8d8b8 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44286 --- Comment #4 from Fabian Maurer <dark.shadow4(a)web.de> --- Works fine, thanks for the quick fix. Sorry if I'm being too curious, but why do we need to redraw it even if CBF_NOREDRAW is set? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44286 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |user32 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44286 --- Comment #5 from Piotr Caban <piotr.caban(a)gmail.com> --- (In reply to Fabian Maurer from comment #4)
Sorry if I'm being too curious, but why do we need to redraw it even if CBF_NOREDRAW is set?
In this case we're just passing the message to edit control. The edit control is responsible for handling the WM_SETREDRAW/drawing (WM_SETREDRAW is forwarded to edit control as well). It needs to be done that way so we behave identical as native. In wine edit control ignores WM_SETREDRAW calls so the openmpt application works. Probably edit control should handle WM_SETREDRAW and do redraw when drawing is enabled. But it's a different issue probably not to be fixed during codefreeze. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44286 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 3.0-rc6. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org