[Bug 44504] New: vlc 2.2.6: playback performance hampered
https://bugs.winehq.org/show_bug.cgi?id=44504 Bug ID: 44504 Summary: vlc 2.2.6: playback performance hampered Product: Wine Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: hxerswinagain(a)gmail.com Distribution: --- video playback persistently stalls and skips by several ms at the Players default video settings detected in: vlc player versions 2.2.4-2.2.6; several versions of WINE all the way up to 3.1 problem seen to enter with commit e75bc6228ebcbdc1a3877a6ac6954611dedf8a71 , and reverting the patch fixes the issue -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 Paul <hxerswinagain(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hverbeet(a)gmail.com, | |hxerswinagain(a)gmail.com Regression SHA1| |e75bc6228ebcbdc1a3877a6ac69 | |54611dedf8a71 Distribution|--- |Debian Keywords| |regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 --- Comment #1 from Paul <hxerswinagain(a)gmail.com> --- Created attachment 60461 --> https://bugs.winehq.org/attachment.cgi?id=60461 file:///home2/frodo/Documents/debg-log.txt -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4(a)web.de --- Comment #2 from Fabian Maurer <dark.shadow4(a)web.de> --- Can't reproduce that on my system. Is that related to the file maybe? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 --- Comment #3 from Paul <hxerswinagain(a)gmail.com> --- (In reply to Fabian Maurer from comment #2)
Can't reproduce that on my system. Is that related to the file maybe?
Hi, Fabian - I've observed this on Mageia, Debian and Linux Mint since around 2.6 release of WINE; presumed that the matter would be shot to kingdom come by next patch at the time, funny. I used the stable and development builds from both mageia and debian hardware/driver is all that would've stayed constant. I'm using GTX 660 card + nvidia driver 384.111 right now on Mageia. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 --- Comment #4 from Paul <hxerswinagain(a)gmail.com> --- -oh, naturally this would mean there've been 100s of files -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 --- Comment #5 from Henri Verbeet <hverbeet(a)gmail.com> --- (In reply to Paul from comment #3)
hardware/driver is all that would've stayed constant. I'm using GTX 660 card + nvidia driver 384.111 right now on Mageia.
This never really worked on propritary NVIDIA, so unless you have a reason to avoid Nouveau, you're probably better of with that driver, generally speaking. As for the regression though, does just restoring the XFlush() in X11DRV_ExtEscape() also restore the old behaviour for you? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 --- Comment #6 from Henri Verbeet <hverbeet(a)gmail.com> --- Created attachment 60519 --> https://bugs.winehq.org/attachment.cgi?id=60519 patch (In reply to Henri Verbeet from comment #5)
As for the regression though, does just restoring the XFlush() in X11DRV_ExtEscape() also restore the old behaviour for you? I.e., does the attached patch help?
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 --- Comment #7 from Paul <hxerswinagain(a)gmail.com> --- Hi Henri. short answer, I need about a week to see if I can apply this. the patch helps a lot, but I can't successfully build wine atm. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 Paul <hxerswinagain(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #8 from Paul <hxerswinagain(a)gmail.com> --- (In reply to Henri Verbeet from comment #6)
Created attachment 60519 [details] patch
(In reply to Henri Verbeet from comment #5)
As for the regression though, does just restoring the XFlush() in X11DRV_ExtEscape() also restore the old behaviour for you? I.e., does the attached patch help?
I've been able to confirm applying that patch onto wine 3.1 does indeed change playback again to normal (and good)! This was most satisfying. :) ttyl, guys -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- Ever confirmed|0 |1 --- Comment #9 from Nikolay Sivov <bunglehead(a)gmail.com> --- Reopening. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 Paul <hxerswinagain(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |winex11.drv -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 --- Comment #10 from Paul <hxerswinagain(a)gmail.com> --- Uh, do we know when this patch is getting into master? It's got what it takes, I think... :] Go little patch, go. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 Henri Verbeet <hverbeet(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60519|0 |1 is obsolete| | --- Comment #11 from Henri Verbeet <hverbeet(a)gmail.com> --- Created attachment 60748 --> https://bugs.winehq.org/attachment.cgi?id=60748 patch Sorry, I forgot about this bug for a while. Does the attached patch also help? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 --- Comment #12 from Paul <hxerswinagain(a)gmail.com> --- (In reply to Henri Verbeet from comment #11)
Created attachment 60748 [details] patch
Sorry, I forgot about this bug for a while. Does the attached patch also help?
Henri, I tried applying the above with 'patch diff.file', in the extract directory of a source tarball, but all that does is freeze the terminal up. In all, my circumstances changed, and I wasn't expecting to have to test this anymore. I did attempt to switch my system temporarily to nouveau, and it all came crashing down - I guess that's the wherefore of why I wasn't using it. Maybe I'm just unlucky w hardware. I shall leave you gents to carry on in this matter now, I believe. Godspeed! -paul -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12(a)gmail.com --- Comment #13 from Zebediah Figura <z.figura12(a)gmail.com> --- (In reply to Paul from comment #12)
Henri, I tried applying the above with 'patch diff.file', in the extract directory of a source tarball, but all that does is freeze the terminal up.
You have to use `patch < diff.file`, with the left angle bracket. 'patch' reads from stdin, not its first argument. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 --- Comment #14 from Henri Verbeet <hverbeet(a)gmail.com> --- (In reply to Zebediah Figura from comment #13)
You have to use `patch < diff.file`, with the left angle bracket. 'patch' reads from stdin, not its first argument. Actually, I'd recommend against using "patch" with git, and instead recommend using "git apply".
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 --- Comment #15 from Paul <hxerswinagain(a)gmail.com> --- (In reply to Henri Verbeet from comment #14)
(In reply to Zebediah Figura from comment #13)
You have to use `patch < diff.file`, with the left angle bracket. 'patch' reads from stdin, not its first argument. Actually, I'd recommend against using "patch" with git, and instead recommend using "git apply".
Oh well, when you've put it that way... :) Yeah I've built in attached-# 60748 patch just now and it appears to have resolved all complaints. Looking good! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 Henri Verbeet <hverbeet(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |14ec499d5b12ac4a1b1b9e8a316 | |f2a6fc3943a1c Status|REOPENED |RESOLVED --- Comment #16 from Henri Verbeet <hverbeet(a)gmail.com> --- Should be fixed by commit 14ec499d5b12ac4a1b1b9e8a316f2a6fc3943a1c in Wine 3.4, reopen if not. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #17 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 3.5. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44504 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|3.0.x |--- --- Comment #18 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 3.0.x milestone from bugs included in 3.0.2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org