[Bug 48962] New: Save file dialog doesn't show full label text for some locales
https://bugs.winehq.org/show_bug.cgi?id=48962 Bug ID: 48962 Summary: Save file dialog doesn't show full label text for some locales Product: Wine Version: 5.4 Hardware: x86 OS: Linux Status: NEW Severity: trivial Priority: P2 Component: comdlg32 Assignee: wine-bugs(a)winehq.org Reporter: dark.shadow4(a)web.de Distribution: --- Created attachment 66937 --> https://bugs.winehq.org/attachment.cgi?id=66937 Win7 screenshot See screenshots. Affected locales are for example fr_FR and de_DE. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48962 --- Comment #1 from Fabian Maurer <dark.shadow4(a)web.de> --- Created attachment 66938 --> https://bugs.winehq.org/attachment.cgi?id=66938 Wine screenshot -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48962 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66938|0 |1 is obsolete| | --- Comment #2 from Fabian Maurer <dark.shadow4(a)web.de> --- Created attachment 66939 --> https://bugs.winehq.org/attachment.cgi?id=66939 Wine screenshot See highlight for affected label. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48962 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://jira.reactos.org/br | |owse/CORE-16890 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48962 Kyle_Katarn <contact(a)kcsoftwares.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |contact(a)kcsoftwares.com --- Comment #3 from Kyle_Katarn <contact(a)kcsoftwares.com> --- This is likely due to a too narrow IDC_LOOKINSTATICdefinition in NEWFILEOPENORD ressource -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48962 --- Comment #4 from Kyle_Katarn <contact(a)kcsoftwares.com> --- (In reply to Kyle_Katarn from comment #3)
This is likely due to a too narrow IDC_LOOKINSTATICdefinition in NEWFILEOPENORD ressource
My mistake, This is due to a too narrow array "WCHAR buf[16];" in filedlg.c ComDlg ressource. WCHAR buf[16] ==> WCHAR buf[24]; /* change Open to Save */ if (fodInfos->DlgInfos.dwDlgProp & FODPROP_SAVEDLG) { WCHAR buf[16]; LoadStringW(COMDLG32_hInstance, IDS_SAVE_BUTTON, buf, ARRAY_SIZE(buf)); SetDlgItemTextW(hwnd, IDOK, buf); LoadStringW(COMDLG32_hInstance, IDS_SAVE_IN, buf, ARRAY_SIZE(buf)); SetDlgItemTextW(hwnd, IDC_LOOKINSTATIC, buf); } -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48962 --- Comment #5 from Kyle_Katarn <contact(a)kcsoftwares.com> --- Dear Wine team, do tou validate the proposed solution ? (array size increased up to [24]) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48962 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12(a)gmail.com --- Comment #6 from Zebediah Figura <z.figura12(a)gmail.com> --- Perhaps better would be to pass 0 as the final argument. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48962 --- Comment #7 from Kyle_Katarn <contact(a)kcsoftwares.com> --- (In reply to Zebediah Figura from comment #6)
Perhaps better would be to pass 0 as the final argument.
Final argument to what ? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48962 --- Comment #8 from Zebediah Figura <z.figura12(a)gmail.com> --- (In reply to Kyle_Katarn from comment #7)
(In reply to Zebediah Figura from comment #6)
Perhaps better would be to pass 0 as the final argument.
Final argument to what ?
As the final argument to LoadStringW(). In that case it will return a constant pointer to the resource in the third argument. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48962 --- Comment #9 from Kyle_Katarn <contact(a)kcsoftwares.com> --- OK but the point here to is change WCHAR buf[16] in to WCHAR buf[24] in order to accept longer strings. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48962 --- Comment #10 from Kyle_Katarn <contact(a)kcsoftwares.com> --- (In reply to Kyle_Katarn from comment #9)
OK but the point here to is change WCHAR buf[16] in to WCHAR buf[24] in order to accept longer strings.
Good point.... i'll che(In reply to Zebediah Figura from comment #8)
(In reply to Kyle_Katarn from comment #7)
(In reply to Zebediah Figura from comment #6)
Perhaps better would be to pass 0 as the final argument.
Final argument to what ?
As the final argument to LoadStringW(). In that case it will return a constant pointer to the resource in the third argument.
Good point indeed. I'll check ! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48962 --- Comment #11 from Fabian Maurer <dark.shadow4(a)web.de> --- Still present as of wine-7.20. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48962 --- Comment #12 from Kyle_Katarn <contact(a)kcsoftwares.com> --- (In reply to Fabian Maurer from comment #11)
Still present as of wine-7.20.
Fixed locally in ReactOS and working fine, waiting for a later fix in Wine : https://github.com/reactos/reactos/commit/9c682e4c1670be4f23d02503b21256886e... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48962 --- Comment #13 from Fabian Maurer <dark.shadow4(a)web.de> ---
Fixed locally in ReactOS and working fine, waiting for a later fix in Wine
I don't see how that would help, the problem is that the label is too small. Even with the patch from ROS, it still doesn't work for me using Wine. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48962 --- Comment #14 from Kyle_Katarn <contact(a)kcsoftwares.com> --- (In reply to Fabian Maurer from comment #13)
Fixed locally in ReactOS and working fine, waiting for a later fix in Wine
I don't see how that would help, the problem is that the label is too small. Even with the patch from ROS, it still doesn't work for me using Wine.
Do you have a specific test case / screenshot ? I'd be pleased to test ReactOS against it -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48962 --- Comment #15 from Fabian Maurer <dark.shadow4(a)web.de> ---
Do you have a specific test case / screenshot ? I'd be pleased to test ReactOS against it
Well, the one attached here: Export in Regedit. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla