[Bug 53686] New: The 64-bit kernel32:console is broken on Windows in the GitLab WineTest builds
https://bugs.winehq.org/show_bug.cgi?id=53686 Bug ID: 53686 Summary: The 64-bit kernel32:console is broken on Windows in the GitLab WineTest builds Product: Wine Version: unspecified Hardware: x86-64 OS: Windows Status: NEW Severity: normal Priority: P2 Component: kernel32 Assignee: wine-bugs(a)winehq.org Reporter: fgouget(a)codeweavers.com The 64-bit kernel32:console is broken on Windows in the GitLab WineTest builds: console.c:2352: Test failed: [9] Expected count to be 0, got 9303856 console.c:2352: Test failed: [13] Expected count to be 0, got 9303952 console.c:2352: Test failed: [15] Expected count to be 0, got 9304144 console.c:2442: Test failed: [9] Expected count to be 0, got 9303856 console.c:2442: Test failed: [13] Expected count to be 0, got 9303952 console.c:2442: Test failed: [15] Expected count to be 0, got 9304144 console.c:2532: Test failed: [9] Expected count to be 0, got 7 console.c:2532: Test failed: [13] Expected count to be 0, got 9 console.c:2532: Test failed: [15] Expected count to be 0, got 13 console.c:2948: Test failed: [9] Expected count to be 0, got 7 console.c:2948: Test failed: [13] Expected count to be 0, got 9 console.c:2948: Test failed: [15] Expected count to be 0, got 13 console.c:3038: Test failed: [9] Expected count to be 0, got 7 console.c:3038: Test failed: [13] Expected count to be 0, got 9 console.c:3038: Test failed: [15] Expected count to be 0, got 13 console.c:3127: Test failed: [9] Expected count to be 0, got 7 console.c:3127: Test failed: [13] Expected count to be 0, got 9 console.c:3127: Test failed: [15] Expected count to be 0, got 13 https://test.winehq.org/data/patterns.html#kernel32:console The failures started on 2022-07-26 which is when the WineTest builds switched from the old build system to GitLab. A test with winetest-889fe64d9f2e.exe (built on 2022-07-25) confirms that this test still succeeds when using binaries from the old build system. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53686 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source, testcase CC| |julliard(a)winehq.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53686 Hugh McMaster <hugh.mcmaster(a)outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hugh.mcmaster(a)outlook.com --- Comment #1 from Hugh McMaster <hugh.mcmaster(a)outlook.com> --- This looks like the WriteConsoleOutput* functions are creating an uninitialized internal DWORD and setting the pointer address for lpNumberOfCharsWritten before returning. As the function failures, the DWORD's value is never set, so the test is just accessing random values. IMHO, this sort of test has limited value. So, While I take your point about the failures starting on build system changeover, is it worth investigating these errors too much? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53686 --- Comment #2 from François Gouget <fgouget(a)codeweavers.com> --- The failures clearly need to be fixed and if the test makes no sense then the best way to do so is by removing the test. So feel free to submit a patch doing that. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53686 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |c7b8da649d899ad90f6949b6d6b | |d96d0e760cdcd Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from François Gouget <fgouget(a)codeweavers.com> --- This got fixed by the commit below: commit c7b8da649d899ad90f6949b6d6bd96d0e760cdcd Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Mon Oct 17 22:28:34 2022 +1100 kernel32/tests: Remove tests comparing expected output in certain functions. The Windows versions of [Read|Write]ConsoleOutput[Attribute|Character] appear to assign an uninitialized internal DWORD to the given pointer address before returning. As the functions fail (intentionally) in these tests, the value of the DWORD is never set, so the tests end up comparing the expected value of zero with random values. This value of this test is very limited and is best removed. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53686 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53686 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 8.0-rc1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla