[Bug 51327] New: GdipCreateFont initializes font with ANSI_CHARSET
https://bugs.winehq.org/show_bug.cgi?id=51327 Bug ID: 51327 Summary: GdipCreateFont initializes font with ANSI_CHARSET Product: Wine Version: 6.11 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: gdiplus Assignee: wine-bugs(a)winehq.org Reporter: galtgendo(a)o2.pl Distribution: --- I'm not sure whether it's a bug or not, but wouldn't DEFAULT_CHARSET be a more proper initial value for the charset field ? Depending on locale, these two may differ. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51327 Esme Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madewokherd(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51327 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51327 Bartosz <gang65(a)poczta.onet.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gang65(a)poczta.onet.pl -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51327 --- Comment #1 from Bartosz <gang65(a)poczta.onet.pl> --- The function is implemented here: https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/gdiplus/font.c?ref_ty... more information: https://learn.microsoft.com/en-us/windows/win32/api/gdiplusheaders/nf-gdiplu...) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51327 --- Comment #2 from Bartosz <gang65(a)poczta.onet.pl> --- According to documentation, default charset is LANG_NEUTRAL: https://learn.microsoft.com/en-us/windows/win32/api/gdiplusheaders/nf-gdiplu... Could you explain where it is set to ANSI_CHARSET? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51327 --- Comment #3 from Rafał Mużyło <galtgendo(a)o2.pl> --- Well, obviously in this line: memset(&lfw, 0, sizeof(lfw)); - quirk of enum values. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51327 --- Comment #4 from Rafał Mużyło <galtgendo(a)o2.pl> --- Note, that currently in wine GdipGetFamilyName(fontFamily, lfw.lfFaceName, LANG_NEUTRAL); is pretty much a no-op wrt. last arg. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51327 --- Comment #5 from Rafał Mużyło <galtgendo(a)o2.pl> --- Also, on a semi-random note, it seems update_font_code_page in win32u was written based upon how things are supposed to work, not how they actually work in wine (bugs like my bug 42606 might be a result of that). Just sticking with CP_ACP would likely be more consistent. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51327 --- Comment #6 from Bartosz <gang65(a)poczta.onet.pl> --- GdipGetFamilyName doesn't support different languages: https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/gdiplus/font.c#L798 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51327 --- Comment #7 from Rafał Mużyło <galtgendo(a)o2.pl> --- Indeed. I never said it did, just making sure *you* knew it didn't. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51327 Jeff Smith <whydoubt(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |whydoubt(a)gmail.com --- Comment #8 from Jeff Smith <whydoubt(a)gmail.com> --- The behavior was changed with this commit: https://gitlab.winehq.org/wine/wine/-/commit/a51c15ff720f414fe383b62a3047a42... This bug item should now be closed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51327 Esme Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |a51c15ff720f414fe383b62a304 | |7a4208d489bb8 Status|UNCONFIRMED |RESOLVED --- Comment #9 from Esme Povirk <madewokherd(a)gmail.com> --- Reported fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51327 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #10 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 8.17. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla