[Bug 46480] New: Invalid write of size 2 in ntoskrnl.exe/tests/ntoskrnl.c
https://bugs.winehq.org/show_bug.cgi?id=46480 Bug ID: 46480 Summary: Invalid write of size 2 in ntoskrnl.exe/tests/ntoskrnl.c Product: Wine Version: 4.0-rc6 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: ntoskrnl Assignee: wine-bugs(a)winehq.org Reporter: sven.wine(a)gmail.com Distribution: --- This was introduced in db8f599863b2158fe854b3d937db8257c660bab5. Note that it was not present in the original patch by Gijs, but was introduced by the changes made by Alexandre. The problem is that one extra WCHAR is copied, but I'm not sure why Alexandre decided to use offsetof, so I'm not sure how to fix it either. ==20740== Invalid write of size 2 ==20740== at 0x4034F03: memcpy (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so) ==20740== by 0x4CD885D: func_ntoskrnl (ntoskrnl.c:163) ==20740== by 0x4CD9005: run_test (test.h:617) ==20740== by 0x4CD7CED: main (test.h:701) ==20740== Address 0x4980818 is 0 bytes after a block of size 80 alloc'd ==20740== at 0x7BC507B3: RtlAllocateHeap (heap.c:260) ==20740== by 0x4CD8801: func_ntoskrnl (heap.h:29) ==20740== by 0x4CD9005: run_test (test.h:617) ==20740== by 0x4CD7CED: main (test.h:701) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46480 Sven <sven.wine(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |db8f599863b2158fe854b3d937d | |b8257c660bab5 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46480 Sven <sven.wine(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46480 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |5bfa5f1e3994a43ba0b0c2f8ed2 | |735e096722578 --- Comment #1 from Alexandre Julliard <julliard(a)winehq.org> --- offsetof is more correct because of structure padding. But of course the terminating null needs to be included in the length, sorry about that. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46480 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #2 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 4.0-rc7. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org