[Bug 43124] New: FlashWindowEx: WM_NCACTIVATE behavior is incorrect
https://bugs.winehq.org/show_bug.cgi?id=43124 Bug ID: 43124 Summary: FlashWindowEx: WM_NCACTIVATE behavior is incorrect Product: Wine Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs(a)winehq.org Reporter: gamax92(a)aol.com Distribution: --- Created attachment 58328 --> https://bugs.winehq.org/attachment.cgi?id=58328 FlashWindowEx dwFlags parameter tests Depending on the dwFlags parameter, FlashWindowEx may send a WM_NCACTIVATE message with the wrong wParam value. Some flags should not send a WM_NCACTIVATE message at all. Attached is a document I've made from testing FlashWindowEx with various flags and having the window active/inactive. This issue seems to be related to Overwatch losing focus on respawn, it calls FlashWindowEx with dwFlags = 0xE (FLASHW_TIMERNOFG + FLASHW_TRAY), which according to my tests should send a WM_NCACTIVATE message with 1, but wine sends 0 instead. Forcing FlashWindowEx to send TRUE instead did resolve the loss of focus. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43124 James Coonradt <gamax92(a)aol.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58328|0 |1 is obsolete| | --- Comment #1 from James Coonradt <gamax92(a)aol.com> --- Created attachment 58337 --> https://bugs.winehq.org/attachment.cgi?id=58337 FlashWindowEx behavior documentation -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43124 --- Comment #2 from James Coonradt <gamax92(a)aol.com> --- The old document did not take into account the count or timeout values (both were set to zero), so further testing was done with various flags, count, and timeout values and a new document was attached. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43124 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian(a)fds-team.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43124 Jactry Zeng <jactry92(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jactry92(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43124 winetest(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest(a)luukku.com --- Comment #3 from winetest(a)luukku.com --- Are you able to form a patch and sent it over wine-patches? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43124 --- Comment #4 from James Coonradt <gamax92(a)aol.com> --- Yes, I'll be making a patch over this weekend, still have a couple of changes to this documentation regarding the return values and calling the function multiple times but I'll have a patch soon. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43124 Matteo Bruni <matteo.mystral(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Staged patchset| |https://github.com/wine-sta | |ging/wine-staging/tree/mast | |er/patches/user32-FlashWind | |owEx Ever confirmed|0 |1 Status|UNCONFIRMED |STAGED --- Comment #5 from Matteo Bruni <matteo.mystral(a)gmail.com> --- It looks like James' patch is currently in staging. I don't think it was ever sent for inclusion upstream. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43124 --- Comment #6 from James Coonradt <gamax92(a)aol.com> --- I never got to submitting a patch for upstream due to confusing testing results, untested combinations, and missing behavior that I was unable to properly replicate. Also due to design issues whether wine should even try to replicate this behavior like the periodic message sending anyway since X11 doesn't have as dynamic of a window alert system than Windows. My apologies. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43124 Jeremy Newman <jnewman(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jnewman(a)codeweavers.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=43124 Zeb Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|STAGED |RESOLVED Fixed by SHA1| |d4b2865eb7f2612e52b3fee6ae1 | |21e59c2d28296 Summary|FlashWindowEx: |Overwatch loses focus on |WM_NCACTIVATE behavior is |respawn |incorrect | Resolution|--- |FIXED CC| |z.figura12(a)gmail.com --- Comment #7 from Zeb Figura <z.figura12(a)gmail.com> --- Overwatch was fixed upstream by d4b2865eb7f2612e52b3fee6ae121e59c2d28296, so I'm adjusting the bug and marking this as fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=43124 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #8 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 10.16. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla