[Bug 6588] New: Strange return value of the GraphBuilder_Connect function

[Wine Bugs]

http://bugs.winehq.org/show_bug.cgi?id=6588

           Summary: Strange return value of the GraphBuilder_Connect
                    function
           Product: Wine
           Version: 0.9.24.
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: wine-directx-dshow
        AssignedTo: wine-bugs(a)winehq.org
        ReportedBy: linine(a)freesurf.ch


Hello, looking at the quartz.dll sources (filtergraph.c file) noticed the following:

static HRESULT WINAPI GraphBuilder_Connect(IGraphBuilder *iface,
					   IPin *ppinOut,
					   IPin *ppinIn)
{
    ...
    
    hr = IEnumMediaTypes_Next(penummt, 1, &mt, &nbmt);
    if (FAILED(hr)) {
        ERR("IEnumMediaTypes_Next (%x)\n", hr);
        return hr;
    }

    if (!nbmt) {
        ERR("No media type found!\n");
        return S_OK; // is this really OK? - DL
    }
    ...
}

If the pins were not connected - is S_OK the suitable return value?

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.